diff options
| author | Shawn O. Pearce <spearce@spearce.org> | 2010-02-09 15:58:37 -0800 |
|---|---|---|
| committer | Shawn O. Pearce <spearce@spearce.org> | 2010-02-09 19:51:36 -0800 |
| commit | efdcb16be3d34e97bb05d9ddaea538ba2d906eca (patch) | |
| tree | c0c1aa5b4762b7e512e6d428f534be2b5ab23f36 /org.eclipse.jgit/src | |
| parent | 3dd067042f60cabe970b0f5bc05d13988c93ddb3 (diff) | |
| download | jgit-efdcb16be3d34e97bb05d9ddaea538ba2d906eca.tar.gz jgit-efdcb16be3d34e97bb05d9ddaea538ba2d906eca.zip | |
Remove pointless boolean during native push
The boolean field sentCommand is always true at this point, as it
was assigned just 5 lines above. So we always set the status of
the update command object to AWAITING_REPORT.
Simplify the logic by dropping the ?: operator. I assume this is
older code from an attempt to manage dry-run push support within
the native connection, but in fact dry-run support is done higher
up inside of PushProcess.
Change-Id: I450d491bbbb5afecdbf5444ab7169222e856a3bb
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Diffstat (limited to 'org.eclipse.jgit/src')
| -rw-r--r-- | org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java index b1ce28d35f..2603ca2879 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/BasePackPushConnection.java @@ -178,7 +178,7 @@ class BasePackPushConnection extends BasePackConnection implements } pckOut.writeString(sb.toString()); - rru.setStatus(sentCommand ? Status.AWAITING_REPORT : Status.OK); + rru.setStatus(Status.AWAITING_REPORT); if (!rru.isDelete()) writePack = true; } |