aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/FooterLineTest.java20
-rw-r--r--org.eclipse.jgit/src/org/eclipse/jgit/revwalk/FooterLine.java2
2 files changed, 21 insertions, 1 deletions
diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/FooterLineTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/FooterLineTest.java
index d199f04ccb..9538a06b48 100644
--- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/FooterLineTest.java
+++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/FooterLineTest.java
@@ -306,6 +306,26 @@ public class FooterLineTest extends RepositoryTestCase {
assertEquals("Main Tain Er <mte@example.com>", footers.get(1));
}
+ public void testMatchesBugId() {
+ final RevCommit commit = parse("this is a commit subject for test\n"
+ + "\n" // paragraph break, now footers appear in final block
+ + "Simple-Bug-Id: 42\n");
+ final List<FooterLine> footers = commit.getFooterLines();
+
+ assertNotNull(footers);
+ assertEquals(1, footers.size());
+
+ final FooterLine line = footers.get(0);
+ assertNotNull(line);
+ assertEquals("Simple-Bug-Id", line.getKey());
+ assertEquals("42", line.getValue());
+
+ final FooterKey bugid = new FooterKey("Simple-Bug-Id");
+ assertTrue("matches Simple-Bug-Id", line.matches(bugid));
+ assertFalse("not Signed-off-by", line.matches(FooterKey.SIGNED_OFF_BY));
+ assertFalse("not CC", line.matches(FooterKey.CC));
+ }
+
private RevCommit parse(final String msg) {
final StringBuilder buf = new StringBuilder();
buf.append("tree " + ObjectId.zeroId().name() + "\n");
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/FooterLine.java b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/FooterLine.java
index 541f2748e7..530200b0ca 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/FooterLine.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/FooterLine.java
@@ -90,7 +90,7 @@ public final class FooterLine {
int bPtr = keyStart;
if (keyEnd - bPtr != len)
return false;
- for (int kPtr = 0; bPtr < len;) {
+ for (int kPtr = 0; kPtr < len;) {
byte b = buffer[bPtr++];
if ('A' <= b && b <= 'Z')
b += 'a' - 'A';