1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
|
/*
* Copyright (C) 2022 Nail Samatov <sanail@yandex.ru> and others
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Distribution License v. 1.0 which is available at
* https://www.eclipse.org/org/documents/edl-v10.php.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
package org.eclipse.jgit.lfs.internal;
import static org.eclipse.jgit.lib.Constants.DEFAULT_REMOTE_NAME;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThrows;
import static org.junit.Assert.assertTrue;
import java.io.File;
import java.io.IOException;
import java.io.PrintWriter;
import java.io.StringWriter;
import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.RemoteAddCommand;
import org.eclipse.jgit.attributes.FilterCommandRegistry;
import org.eclipse.jgit.junit.RepositoryTestCase;
import org.eclipse.jgit.lfs.CleanFilter;
import org.eclipse.jgit.lfs.Protocol;
import org.eclipse.jgit.lfs.SmudgeFilter;
import org.eclipse.jgit.lfs.errors.LfsConfigInvalidException;
import org.eclipse.jgit.lfs.lib.Constants;
import org.eclipse.jgit.lib.ConfigConstants;
import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.lib.StoredConfig;
import org.eclipse.jgit.transport.URIish;
import org.eclipse.jgit.transport.http.HttpConnection;
import org.eclipse.jgit.util.HttpSupport;
import org.junit.AfterClass;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
public class LfsConnectionFactoryTest extends RepositoryTestCase {
private static final String SMUDGE_NAME = org.eclipse.jgit.lib.Constants.BUILTIN_FILTER_PREFIX
+ Constants.ATTR_FILTER_DRIVER_PREFIX
+ org.eclipse.jgit.lib.Constants.ATTR_FILTER_TYPE_SMUDGE;
private static final String CLEAN_NAME = org.eclipse.jgit.lib.Constants.BUILTIN_FILTER_PREFIX
+ Constants.ATTR_FILTER_DRIVER_PREFIX
+ org.eclipse.jgit.lib.Constants.ATTR_FILTER_TYPE_CLEAN;
private final static String LFS_SERVER_URL1 = "https://lfs.server1/test/uri";
private final static String LFS_SERVER_URL2 = "https://lfs.server2/test/uri";
private final static String ORIGIN_URL = "https://git.server/test/uri";
private Git git;
@BeforeClass
public static void installLfs() {
FilterCommandRegistry.register(SMUDGE_NAME, SmudgeFilter.FACTORY);
FilterCommandRegistry.register(CLEAN_NAME, CleanFilter.FACTORY);
}
@AfterClass
public static void removeLfs() {
FilterCommandRegistry.unregister(SMUDGE_NAME);
FilterCommandRegistry.unregister(CLEAN_NAME);
}
@Override
@Before
public void setUp() throws Exception {
super.setUp();
git = new Git(db);
// Just to have a non empty repo
writeTrashFile("Test.txt", "Hello world from the LFS Factory Test");
git.add().addFilepattern("Test.txt").call();
git.commit().setMessage("Initial commit").call();
}
@Test
public void lfsUrlFromRemoteUrlWithDotGit() throws Exception {
addRemoteUrl("https://localhost/repo.git");
checkLfsUrl("https://localhost/repo.git/info/lfs");
}
@Test
public void lfsUrlFromRemoteUrlWithoutDotGit() throws Exception {
addRemoteUrl("https://localhost/repo");
checkLfsUrl("https://localhost/repo.git/info/lfs");
}
@Test
public void lfsUrlFromLocalConfig() throws Exception {
addRemoteUrl("https://localhost/repo");
@SuppressWarnings("restriction")
StoredConfig cfg = db.getConfig();
cfg.setString(ConfigConstants.CONFIG_SECTION_LFS,
null,
ConfigConstants.CONFIG_KEY_URL,
"https://localhost/repo/lfs");
cfg.save();
checkLfsUrl("https://localhost/repo/lfs");
}
@Test
public void lfsUrlFromOriginConfig() throws Exception {
addRemoteUrl("https://localhost/repo");
@SuppressWarnings("restriction")
StoredConfig cfg = db.getConfig();
cfg.setString(ConfigConstants.CONFIG_SECTION_LFS,
org.eclipse.jgit.lib.Constants.DEFAULT_REMOTE_NAME,
ConfigConstants.CONFIG_KEY_URL,
"https://localhost/repo/lfs");
cfg.save();
checkLfsUrl("https://localhost/repo/lfs");
}
@Test
public void lfsUrlNotConfigured() throws Exception {
assertThrows(LfsConfigInvalidException.class,
() -> LfsConnectionFactory.getLfsConnection(db,
HttpSupport.METHOD_POST, Protocol.OPERATION_DOWNLOAD));
}
@Test
public void checkGetLfsConnection_lfsurl_lfsconfigFromWorkingDir()
throws Exception {
writeLfsConfig();
checkLfsUrl(LFS_SERVER_URL1);
}
@Test
public void checkGetLfsConnection_lfsurl_lfsconfigFromIndex()
throws Exception {
writeLfsConfig();
git.add().addFilepattern(Constants.DOT_LFS_CONFIG).call();
deleteTrashFile(Constants.DOT_LFS_CONFIG);
checkLfsUrl(LFS_SERVER_URL1);
}
@Test
public void checkGetLfsConnection_lfsurl_lfsconfigFromHEAD()
throws Exception {
writeLfsConfig();
git.add().addFilepattern(Constants.DOT_LFS_CONFIG).call();
git.commit().setMessage("Commit LFS Config").call();
/*
* reading .lfsconfig from HEAD seems only testable using a bare repo,
* since otherwise working tree or index are used
*/
File directory = createTempDirectory("testBareRepo");
try (Repository bareRepoDb = Git.cloneRepository()
.setDirectory(directory)
.setURI(db.getDirectory().toURI().toString()).setBare(true)
.call().getRepository()) {
checkLfsUrl(LFS_SERVER_URL1);
}
}
@Test
public void checkGetLfsConnection_remote_lfsconfigFromWorkingDir()
throws Exception {
addRemoteUrl(ORIGIN_URL);
writeLfsConfig(LFS_SERVER_URL1, "lfs", DEFAULT_REMOTE_NAME, "url");
checkLfsUrl(LFS_SERVER_URL1);
}
/**
* Test the config file precedence.
*
* Checking only with the local repository config is sufficient since from
* that point the "normal" precedence is used.
*
* @throws Exception
*/
@Test
public void checkGetLfsConnection_ConfigFilePrecedence_lfsconfigFromWorkingDir()
throws Exception {
writeLfsConfig();
checkLfsUrl(LFS_SERVER_URL1);
StoredConfig config = git.getRepository().getConfig();
config.setString(ConfigConstants.CONFIG_SECTION_LFS, null,
ConfigConstants.CONFIG_KEY_URL, LFS_SERVER_URL2);
config.save();
checkLfsUrl(LFS_SERVER_URL2);
}
@Test
public void checkGetLfsConnection_InvalidLfsConfig_WorkingDir()
throws Exception {
writeInvalidLfsConfig();
LfsConfigInvalidException actualException = assertThrows(
LfsConfigInvalidException.class, () -> {
LfsConnectionFactory.getLfsConnection(db, HttpSupport.METHOD_POST,
Protocol.OPERATION_DOWNLOAD);
});
assertTrue(getStackTrace(actualException)
.contains("Invalid line in config file"));
}
@Test
public void checkGetLfsConnection_InvalidLfsConfig_Index()
throws Exception {
writeInvalidLfsConfig();
git.add().addFilepattern(Constants.DOT_LFS_CONFIG).call();
deleteTrashFile(Constants.DOT_LFS_CONFIG);
LfsConfigInvalidException actualException = assertThrows(
LfsConfigInvalidException.class, () -> {
LfsConnectionFactory.getLfsConnection(db, HttpSupport.METHOD_POST,
Protocol.OPERATION_DOWNLOAD);
});
assertTrue(getStackTrace(actualException)
.contains("Invalid line in config file"));
}
@Test
public void checkGetLfsConnection_InvalidLfsConfig_HEAD() throws Exception {
writeInvalidLfsConfig();
git.add().addFilepattern(Constants.DOT_LFS_CONFIG).call();
git.commit().setMessage("Commit LFS Config").call();
/*
* reading .lfsconfig from HEAD seems only testable using a bare repo,
* since otherwise working tree or index are used
*/
File directory = createTempDirectory("testBareRepo");
try (Repository bareRepoDb = Git.cloneRepository()
.setDirectory(directory)
.setURI(db.getDirectory().toURI().toString()).setBare(true)
.call().getRepository()) {
LfsConfigInvalidException actualException = assertThrows(
LfsConfigInvalidException.class,
() -> {
LfsConnectionFactory.getLfsConnection(db,
HttpSupport.METHOD_POST,
Protocol.OPERATION_DOWNLOAD);
});
assertTrue(getStackTrace(actualException)
.contains("Invalid line in config file"));
}
}
private void addRemoteUrl(String remotUrl) throws Exception {
RemoteAddCommand add = git.remoteAdd();
add.setUri(new URIish(remotUrl));
add.setName(org.eclipse.jgit.lib.Constants.DEFAULT_REMOTE_NAME);
add.call();
}
/**
* Returns the stack trace of the provided exception as string
*
* @param actualException
* @return The exception stack trace as string
*/
private String getStackTrace(Exception actualException) {
StringWriter sw = new StringWriter();
PrintWriter pw = new PrintWriter(sw);
actualException.printStackTrace(pw);
return sw.toString();
}
private void writeLfsConfig() throws IOException {
writeLfsConfig(LFS_SERVER_URL1, "lfs", "url");
}
private void writeLfsConfig(String lfsUrl, String section, String name)
throws IOException {
writeLfsConfig(lfsUrl, section, null, name);
}
/*
* Write simple lfs config with single entry. Do not use FileBasedConfig to
* avoid introducing new dependency (for now).
*/
private void writeLfsConfig(String lfsUrl, String section,
String subsection, String name) throws IOException {
StringBuilder config = new StringBuilder();
config.append("[");
config.append(section);
if (subsection != null) {
config.append(" \"");
config.append(subsection);
config.append("\"");
}
config.append("]\n");
config.append(" ");
config.append(name);
config.append(" = ");
config.append(lfsUrl);
writeTrashFile(Constants.DOT_LFS_CONFIG, config.toString());
}
private void writeInvalidLfsConfig() throws IOException {
writeTrashFile(Constants.DOT_LFS_CONFIG,
"{lfs]\n url = " + LFS_SERVER_URL1);
}
private void checkLfsUrl(String lfsUrl) throws IOException {
HttpConnection lfsServerConn;
lfsServerConn = LfsConnectionFactory.getLfsConnection(db,
HttpSupport.METHOD_POST, Protocol.OPERATION_DOWNLOAD);
assertEquals(lfsUrl + Protocol.OBJECTS_LFS_ENDPOINT,
lfsServerConn.getURL().toString());
}
}
|