1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
|
/*
* Copyright (C) 2023, Google LLC. and others
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Distribution License v. 1.0 which is available at
* https://www.eclipse.org/org/documents/edl-v10.php.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
package org.eclipse.jgit.internal.storage.dfs;
import static org.eclipse.jgit.lib.ConfigConstants.CONFIG_KEY_MIN_BYTES_OBJ_SIZE_INDEX;
import static org.eclipse.jgit.lib.ConfigConstants.CONFIG_PACK_SECTION;
import static org.eclipse.jgit.lib.Constants.OBJ_BLOB;
import static org.eclipse.jgit.lib.Constants.OBJ_COMMIT;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import java.io.IOException;
import java.util.HashMap;
import java.util.Map;
import org.eclipse.jgit.internal.storage.dfs.DfsObjDatabase.PackSource;
import org.eclipse.jgit.internal.storage.dfs.DfsReader.PackLoadListener;
import org.eclipse.jgit.internal.storage.pack.PackExt;
import org.eclipse.jgit.junit.JGitTestUtil;
import org.eclipse.jgit.junit.TestRng;
import org.eclipse.jgit.lib.ObjectId;
import org.eclipse.jgit.lib.ObjectInserter;
import org.junit.Before;
import org.junit.Test;
public class DfsReaderTest {
InMemoryRepository db;
@Before
public void setUp() {
db = new InMemoryRepository(new DfsRepositoryDescription("test"));
// These tests assume the object size index is enabled.
db.getObjectDatabase().getReaderOptions().setUseObjectSizeIndex(true);
}
@Test
public void getObjectSize_noIndex_blob() throws IOException {
ObjectId obj = insertBlobWithSize(100);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
long size = ctx.getObjectSize(obj, OBJ_BLOB);
assertEquals(100, size);
}
}
@Test
public void getObjectSize_noIndex_commit() throws IOException {
ObjectId obj = insertObjectWithSize(OBJ_COMMIT, 110);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
long size = ctx.getObjectSize(obj, OBJ_COMMIT);
assertEquals(110, size);
}
}
@Test
public void getObjectSize_index_indexedBlob() throws IOException {
setObjectSizeIndexMinBytes(100);
ObjectId obj = insertBlobWithSize(200);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
long size = ctx.getObjectSize(obj, OBJ_BLOB);
assertEquals(200, size);
}
}
@Test
public void getObjectSize_index_nonIndexedBlob() throws IOException {
setObjectSizeIndexMinBytes(100);
ObjectId obj = insertBlobWithSize(50);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
long size = ctx.getObjectSize(obj, OBJ_BLOB);
assertEquals(50, size);
}
}
@Test
public void getObjectSize_index_commit() throws IOException {
setObjectSizeIndexMinBytes(100);
insertBlobWithSize(110);
ObjectId obj = insertObjectWithSize(OBJ_COMMIT, 120);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
long size = ctx.getObjectSize(obj, OBJ_COMMIT);
assertEquals(120, size);
}
}
@Test
public void isNotLargerThan_objAboveThreshold() throws IOException {
setObjectSizeIndexMinBytes(100);
ObjectId obj = insertBlobWithSize(200);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
assertFalse("limit < threshold < obj",
ctx.isNotLargerThan(obj, OBJ_BLOB, 50));
assertEquals(1, ctx.stats.isNotLargerThanCallCount);
assertEquals(1, ctx.stats.objectSizeIndexHit);
assertEquals(0, ctx.stats.objectSizeIndexMiss);
assertFalse("limit = threshold < obj",
ctx.isNotLargerThan(obj, OBJ_BLOB, 100));
assertEquals(2, ctx.stats.isNotLargerThanCallCount);
assertEquals(2, ctx.stats.objectSizeIndexHit);
assertEquals(0, ctx.stats.objectSizeIndexMiss);
assertFalse("threshold < limit < obj",
ctx.isNotLargerThan(obj, OBJ_BLOB, 150));
assertEquals(3, ctx.stats.isNotLargerThanCallCount);
assertEquals(3, ctx.stats.objectSizeIndexHit);
assertEquals(0, ctx.stats.objectSizeIndexMiss);
assertTrue("threshold < limit = obj",
ctx.isNotLargerThan(obj, OBJ_BLOB, 200));
assertEquals(4, ctx.stats.isNotLargerThanCallCount);
assertEquals(4, ctx.stats.objectSizeIndexHit);
assertEquals(0, ctx.stats.objectSizeIndexMiss);
assertTrue("threshold < obj < limit",
ctx.isNotLargerThan(obj, OBJ_BLOB, 250));
assertEquals(5, ctx.stats.isNotLargerThanCallCount);
assertEquals(5, ctx.stats.objectSizeIndexHit);
assertEquals(0, ctx.stats.objectSizeIndexMiss);
}
}
@Test
public void isNotLargerThan_objBelowThreshold() throws IOException {
setObjectSizeIndexMinBytes(100);
insertBlobWithSize(1000); // index not empty
ObjectId obj = insertBlobWithSize(50);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
assertFalse("limit < obj < threshold",
ctx.isNotLargerThan(obj, OBJ_BLOB, 10));
assertEquals(1, ctx.stats.isNotLargerThanCallCount);
assertEquals(0, ctx.stats.objectSizeIndexHit);
assertEquals(1, ctx.stats.objectSizeIndexMiss);
assertTrue("limit = obj < threshold",
ctx.isNotLargerThan(obj, OBJ_BLOB, 50));
assertEquals(2, ctx.stats.isNotLargerThanCallCount);
assertEquals(0, ctx.stats.objectSizeIndexHit);
assertEquals(2, ctx.stats.objectSizeIndexMiss);
assertTrue("obj < limit < threshold",
ctx.isNotLargerThan(obj, OBJ_BLOB, 80));
assertEquals(3, ctx.stats.isNotLargerThanCallCount);
assertEquals(0, ctx.stats.objectSizeIndexHit);
assertEquals(3, ctx.stats.objectSizeIndexMiss);
assertTrue("obj < limit = threshold",
ctx.isNotLargerThan(obj, OBJ_BLOB, 100));
assertEquals(4, ctx.stats.isNotLargerThanCallCount);
assertEquals(0, ctx.stats.objectSizeIndexHit);
assertEquals(4, ctx.stats.objectSizeIndexMiss);
assertTrue("obj < threshold < limit",
ctx.isNotLargerThan(obj, OBJ_BLOB, 120));
assertEquals(5, ctx.stats.isNotLargerThanCallCount);
assertEquals(0, ctx.stats.objectSizeIndexHit);
assertEquals(5, ctx.stats.objectSizeIndexMiss);
}
}
@Test
public void isNotLargerThan_emptyIdx() throws IOException {
setObjectSizeIndexMinBytes(100);
ObjectId obj = insertBlobWithSize(10);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
assertFalse(ctx.isNotLargerThan(obj, OBJ_BLOB, 0));
assertTrue(ctx.isNotLargerThan(obj, OBJ_BLOB, 10));
assertTrue(ctx.isNotLargerThan(obj, OBJ_BLOB, 40));
assertTrue(ctx.isNotLargerThan(obj, OBJ_BLOB, 50));
assertTrue(ctx.isNotLargerThan(obj, OBJ_BLOB, 100));
assertEquals(5, ctx.stats.isNotLargerThanCallCount);
assertEquals(5, ctx.stats.objectSizeIndexMiss);
assertEquals(0, ctx.stats.objectSizeIndexHit);
}
}
@Test
public void isNotLargerThan_noObjectSizeIndex() throws IOException {
setObjectSizeIndexMinBytes(-1);
ObjectId obj = insertBlobWithSize(10);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
assertFalse(ctx.isNotLargerThan(obj, OBJ_BLOB, 0));
assertTrue(ctx.isNotLargerThan(obj, OBJ_BLOB, 10));
assertTrue(ctx.isNotLargerThan(obj, OBJ_BLOB, 40));
assertTrue(ctx.isNotLargerThan(obj, OBJ_BLOB, 50));
assertTrue(ctx.isNotLargerThan(obj, OBJ_BLOB, 100));
assertEquals(5, ctx.stats.isNotLargerThanCallCount);
assertEquals(0, ctx.stats.objectSizeIndexMiss);
assertEquals(0, ctx.stats.objectSizeIndexHit);
}
}
@Test
public void packLoadListener_noInvocations() throws IOException {
insertBlobWithSize(100);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
CounterPackLoadListener listener = new CounterPackLoadListener();
ctx.addPackLoadListener(listener);
assertEquals(null, listener.callsPerExt.get(PackExt.INDEX));
}
}
@Test
public void packLoadListener_has_openIdx() throws IOException {
ObjectId obj = insertBlobWithSize(100);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
CounterPackLoadListener listener = new CounterPackLoadListener();
ctx.addPackLoadListener(listener);
boolean has = ctx.has(obj);
assertTrue(has);
assertEquals(Integer.valueOf(1),
listener.callsPerExt.get(PackExt.INDEX));
}
}
@Test
public void packLoadListener_notLargerThan_openMultipleIndices()
throws IOException {
setObjectSizeIndexMinBytes(100);
ObjectId obj = insertBlobWithSize(200);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
CounterPackLoadListener listener = new CounterPackLoadListener();
ctx.addPackLoadListener(listener);
boolean notLargerThan = ctx.isNotLargerThan(obj, OBJ_BLOB, 1000);
assertTrue(notLargerThan);
assertEquals(Integer.valueOf(1),
listener.callsPerExt.get(PackExt.INDEX));
assertEquals(Integer.valueOf(1),
listener.callsPerExt.get(PackExt.OBJECT_SIZE_INDEX));
}
}
@Test
public void packLoadListener_has_openMultipleIndices() throws IOException {
setObjectSizeIndexMinBytes(100);
insertBlobWithSize(200);
insertBlobWithSize(230);
insertBlobWithSize(100);
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
CounterPackLoadListener listener = new CounterPackLoadListener();
ctx.addPackLoadListener(listener);
ObjectId oid = ObjectId
.fromString("aa48de2aa61d9dffa8a05439dc115fe82f10f129");
boolean has = ctx.has(oid);
assertFalse(has);
// Open 3 indices trying to find the pack
assertEquals(Integer.valueOf(3),
listener.callsPerExt.get(PackExt.INDEX));
}
}
@Test
public void packLoadListener_has_repeatedCalls_openMultipleIndices()
throws IOException {
// Two objects NOT in the repo
ObjectId oid = ObjectId
.fromString("aa48de2aa61d9dffa8a05439dc115fe82f10f129");
ObjectId oid2 = ObjectId
.fromString("aa48de2aa61d9dffa8a05439dc115fe82f10f130");
setObjectSizeIndexMinBytes(100);
insertBlobWithSize(200);
insertBlobWithSize(230);
insertBlobWithSize(100);
CounterPackLoadListener listener = new CounterPackLoadListener();
try (DfsReader ctx = db.getObjectDatabase().newReader()) {
ctx.addPackLoadListener(listener);
boolean has = ctx.has(oid);
ctx.has(oid);
ctx.has(oid2);
assertFalse(has);
// The 3 indices were loaded only once each
assertEquals(Integer.valueOf(3),
listener.callsPerExt.get(PackExt.INDEX));
}
}
private static class CounterPackLoadListener implements PackLoadListener {
final Map<PackExt, Integer> callsPerExt = new HashMap<>();
@SuppressWarnings("boxing")
@Override
public void onIndexLoad(String packName, PackSource src, PackExt ext,
long size, Object loadedIdx) {
callsPerExt.merge(ext, 1, Integer::sum);
}
@Override
public void onBlockLoad(String packName, PackSource src, PackExt ext,
long size, DfsBlockData dfsBlockData) {
// empty
}
}
private ObjectId insertBlobWithSize(int size) throws IOException {
return insertObjectWithSize(OBJ_BLOB, size);
}
private ObjectId insertObjectWithSize(int object_type, int size)
throws IOException {
TestRng testRng = new TestRng(JGitTestUtil.getName());
ObjectId oid;
try (ObjectInserter ins = db.newObjectInserter()) {
oid = ins.insert(object_type, testRng.nextBytes(size));
ins.flush();
}
return oid;
}
private void setObjectSizeIndexMinBytes(int threshold) {
db.getConfig().setInt(CONFIG_PACK_SECTION, null,
CONFIG_KEY_MIN_BYTES_OBJ_SIZE_INDEX, threshold);
}
}
|
