1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
|
/*
* Copyright (C) 2009, Google Inc. and others
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Distribution License v. 1.0 which is available at
* https://www.eclipse.org/org/documents/edl-v10.php.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
package org.eclipse.jgit.lib;
import static org.eclipse.jgit.junit.Assert.assertEquals;
import static org.junit.Assert.assertEquals;
import org.eclipse.jgit.junit.MockSystemReader;
import org.eclipse.jgit.util.SystemReader;
import org.junit.Test;
public class ValidRefNameTest {
private static void assertValid(boolean exp, String name) {
SystemReader instance = SystemReader.getInstance();
try {
setUnixSystemReader();
assertEquals("\"" + name + "\"", exp,
Repository.isValidRefName(name));
setWindowsSystemReader();
assertEquals("\"" + name + "\"", exp,
Repository.isValidRefName(name));
} finally {
SystemReader.setInstance(instance);
}
}
private static void setWindowsSystemReader() {
SystemReader.setInstance(new MockSystemReader() {
{
setWindows();
}
});
}
private static void setUnixSystemReader() {
SystemReader.setInstance(new MockSystemReader() {
{
setUnix();
}
});
}
private static void assertInvalidOnWindows(String name) {
SystemReader instance = SystemReader.getInstance();
try {
setUnixSystemReader();
assertEquals("\"" + name + "\"", true,
Repository.isValidRefName(name));
setWindowsSystemReader();
assertEquals("\"" + name + "\"", false,
Repository.isValidRefName(name));
} finally {
SystemReader.setInstance(instance);
}
}
private static void assertNormalized(final String name,
final String expected) {
SystemReader instance = SystemReader.getInstance();
try {
setUnixSystemReader();
String normalized = Repository.normalizeBranchName(name);
assertEquals("Normalization of " + name, expected, normalized);
assertEquals("\"" + normalized + "\"", true,
Repository.isValidRefName(Constants.R_HEADS + normalized));
setWindowsSystemReader();
normalized = Repository.normalizeBranchName(name);
assertEquals("Normalization of " + name, expected, normalized);
assertEquals("\"" + normalized + "\"", true,
Repository.isValidRefName(Constants.R_HEADS + normalized));
} finally {
SystemReader.setInstance(instance);
}
}
@Test
public void testEmptyString() {
assertValid(false, "");
assertValid(false, "/");
}
@Test
public void testMustHaveTwoComponents() {
assertValid(false, "master");
assertValid(true, "heads/master");
}
@Test
public void testValidHead() {
assertValid(true, "refs/heads/master");
assertValid(true, "refs/heads/pu");
assertValid(true, "refs/heads/z");
assertValid(true, "refs/heads/FoO");
}
@Test
public void testValidTag() {
assertValid(true, "refs/tags/v1.0");
}
@Test
public void testNoLockSuffix() {
assertValid(false, "refs/heads/master.lock");
}
@Test
public void testNoDirectorySuffix() {
assertValid(false, "refs/heads/master/");
}
@Test
public void testNoSpace() {
assertValid(false, "refs/heads/i haz space");
}
@Test
public void testNoAsciiControlCharacters() {
for (char c = '\0'; c < ' '; c++)
assertValid(false, "refs/heads/mast" + c + "er");
}
@Test
public void testNoBareDot() {
assertValid(false, "refs/heads/.");
assertValid(false, "refs/heads/..");
assertValid(false, "refs/heads/./master");
assertValid(false, "refs/heads/../master");
}
@Test
public void testNoLeadingOrTrailingDot() {
assertValid(false, ".");
assertValid(false, "refs/heads/.bar");
assertValid(false, "refs/heads/..bar");
assertValid(false, "refs/heads/bar.");
}
@Test
public void testContainsDot() {
assertValid(true, "refs/heads/m.a.s.t.e.r");
assertValid(false, "refs/heads/master..pu");
}
@Test
public void testNoMagicRefCharacters() {
assertValid(false, "refs/heads/master^");
assertValid(false, "refs/heads/^master");
assertValid(false, "^refs/heads/master");
assertValid(false, "refs/heads/master~");
assertValid(false, "refs/heads/~master");
assertValid(false, "~refs/heads/master");
assertValid(false, "refs/heads/master:");
assertValid(false, "refs/heads/:master");
assertValid(false, ":refs/heads/master");
}
@Test
public void testShellGlob() {
assertValid(false, "refs/heads/master?");
assertValid(false, "refs/heads/?master");
assertValid(false, "?refs/heads/master");
assertValid(false, "refs/heads/master[");
assertValid(false, "refs/heads/[master");
assertValid(false, "[refs/heads/master");
assertValid(false, "refs/heads/master*");
assertValid(false, "refs/heads/*master");
assertValid(false, "*refs/heads/master");
}
@Test
public void testValidSpecialCharacterUnixs() {
assertValid(true, "refs/heads/!");
assertValid(true, "refs/heads/#");
assertValid(true, "refs/heads/$");
assertValid(true, "refs/heads/%");
assertValid(true, "refs/heads/&");
assertValid(true, "refs/heads/'");
assertValid(true, "refs/heads/(");
assertValid(true, "refs/heads/)");
assertValid(true, "refs/heads/+");
assertValid(true, "refs/heads/,");
assertValid(true, "refs/heads/-");
assertValid(true, "refs/heads/;");
assertValid(true, "refs/heads/=");
assertValid(true, "refs/heads/@");
assertValid(true, "refs/heads/]");
assertValid(true, "refs/heads/_");
assertValid(true, "refs/heads/`");
assertValid(true, "refs/heads/{");
assertValid(true, "refs/heads/}");
// This is valid on UNIX, but not on Windows
// hence we make in invalid due to non-portability
//
assertValid(false, "refs/heads/\\");
// More invalid characters on Windows, but we allow them
assertInvalidOnWindows("refs/heads/\"");
assertInvalidOnWindows("refs/heads/<");
assertInvalidOnWindows("refs/heads/>");
assertInvalidOnWindows("refs/heads/|");
}
@Test
public void testUnicodeNames() {
assertValid(true, "refs/heads/\u00e5ngstr\u00f6m");
}
@Test
public void testRefLogQueryIsValidRef() {
assertValid(false, "refs/heads/master@{1}");
assertValid(false, "refs/heads/master@{1.hour.ago}");
}
@Test
public void testWindowsReservedNames() {
// re-using code from DirCacheCheckoutTest, hence
// only testing for one of the special names.
assertInvalidOnWindows("refs/heads/con");
assertInvalidOnWindows("refs/con/x");
assertInvalidOnWindows("con/heads/x");
assertValid(true, "refs/heads/conx");
assertValid(true, "refs/heads/xcon");
}
@Test
public void testNormalizeBranchName() {
assertEquals("", Repository.normalizeBranchName(null));
assertEquals("", Repository.normalizeBranchName(""));
assertNormalized("Bug 12345::::Hello World", "Bug_12345-Hello_World");
assertNormalized("Bug 12345 :::: Hello World", "Bug_12345_Hello_World");
assertNormalized("Bug 12345 :::: Hello::: World",
"Bug_12345_Hello-World");
assertNormalized(":::Bug 12345 - Hello World", "Bug_12345_Hello_World");
assertNormalized("---Bug 12345 - Hello World", "Bug_12345_Hello_World");
assertNormalized("Bug 12345 ---- Hello --- World",
"Bug_12345_Hello_World");
assertNormalized("Bug 12345 - Hello World!", "Bug_12345_Hello_World!");
assertNormalized("Bug 12345 : Hello World!", "Bug_12345_Hello_World!");
assertNormalized("Bug 12345 _ Hello World!", "Bug_12345_Hello_World!");
assertNormalized("Bug 12345 - Hello World!",
"Bug_12345_Hello_World!");
assertNormalized(" Bug 12345 - Hello World! ",
"Bug_12345_Hello_World!");
assertNormalized(" Bug 12345 - Hello World! ",
"Bug_12345_Hello_World!");
assertNormalized("Bug 12345 - Hello______ World!",
"Bug_12345_Hello_World!");
assertNormalized("_Bug 12345 - Hello World!", "Bug_12345_Hello_World!");
}
@Test
public void testNormalizeWithSlashes() {
assertNormalized("foo/bar/baz", "foo/bar/baz");
assertNormalized("foo/bar.lock/baz.lock", "foo/bar_lock/baz_lock");
assertNormalized("foo/.git/.git~1/bar", "foo/git/git-1/bar");
assertNormalized(".foo/aux/con/com3.txt/com0/prn/lpt1",
"foo/+aux/+con/+com3.txt/com0/+prn/+lpt1");
assertNormalized("foo/../bar///.--ba...z", "foo/bar/ba.z");
}
@Test
public void testNormalizeWithUnicode() {
assertNormalized("f\u00f6\u00f6/.b\u00e0r/*[<>|^~/b\u00e9\\z",
"f\u00f6\u00f6/b\u00e0r/b\u00e9-z");
assertNormalized("\u5165\u53e3 entrance;/.\u51fa\u53e3_*ex*it*/",
"\u5165\u53e3_entrance;/\u51fa\u53e3_ex-it");
}
@Test
public void testNormalizeAlreadyValidRefName() {
assertNormalized("refs/heads/m.a.s.t.e.r", "refs/heads/m.a.s.t.e.r");
assertNormalized("refs/tags/v1.0-20170223", "refs/tags/v1.0-20170223");
}
@Test
public void testNormalizeTrimmedUnicodeAlreadyValidRefName() {
assertNormalized(" \u00e5ngstr\u00f6m\t", "\u00e5ngstr\u00f6m");
}
}
|
