1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
|
/*
* Copyright (C) 2009, Google Inc. and others
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Distribution License v. 1.0 which is available at
* https://www.eclipse.org/org/documents/edl-v10.php.
*
* SPDX-License-Identifier: BSD-3-Clause
*/
package org.eclipse.jgit.revwalk;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import java.util.List;
import org.eclipse.jgit.junit.RepositoryTestCase;
import org.eclipse.jgit.lib.ObjectId;
import org.junit.Test;
public class FooterLineTest extends RepositoryTestCase {
@Test
public void testNoFooters_EmptyBody() {
String msg = buildMessage("");
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(0, footers.size());
}
@Test
public void testNoFooters_NewlineOnlyBody1() {
String msg = buildMessage("\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(0, footers.size());
}
@Test
public void testNoFooters_NewlineOnlyBody5() {
String msg = buildMessage("\n\n\n\n\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(0, footers.size());
}
@Test
public void testNoFooters_OneLineBodyNoLF() {
String msg = buildMessage("this is a commit");
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(0, footers.size());
}
@Test
public void testNoFooters_OneLineBodyWithLF() {
String msg = buildMessage("this is a commit\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(0, footers.size());
}
@Test
public void testNoFooters_ShortBodyNoLF() {
String msg = buildMessage("subject\n\nbody of commit");
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(0, footers.size());
}
@Test
public void testNoFooters_ShortBodyWithLF() {
String msg = buildMessage("subject\n\nbody of commit\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(0, footers.size());
}
@Test
public void testNoFooters_noRawMsg_SingleLineNoHeaders() {
String noRawMsg = "commit message with no header lines\n";
List<FooterLine> footers = FooterLine.fromMessage(noRawMsg);
assertNotNull(footers);
assertEquals(0, footers.size());
}
@Test
public void testOneFooter_noRawMsg_MultiParagraphNoHeaders() {
String noRawMsg = "subject\n\n"
+ "Not: footer\n\n"
+ "Footer: value\n";
List<FooterLine> footers = FooterLine.fromMessage(noRawMsg);
assertNotNull(footers);
assertEquals(1, footers.size());
}
@Test
public void testOneFooter_longSubject_NoHeaders() {
String noRawMsg = "50+ chars loooooooooooooong custom commit message.\n\n"
+ "Footer: value\n";
List<FooterLine> footers = FooterLine.fromMessage(noRawMsg);
assertNotNull(footers);
assertEquals(1, footers.size());
}
@Test
public void testSignedOffBy_OneUserNoLF() {
String msg = buildMessage("subject\n\nbody of commit\n" + "\n"
+ "Signed-off-by: A. U. Thor <a@example.com>");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(1, footers.size());
f = footers.get(0);
assertEquals("Signed-off-by", f.getKey());
assertEquals("A. U. Thor <a@example.com>", f.getValue());
assertEquals("a@example.com", f.getEmailAddress());
}
@Test
public void testSignedOffBy_OneUserWithLF() {
String msg = buildMessage("subject\n\nbody of commit\n" + "\n"
+ "Signed-off-by: A. U. Thor <a@example.com>\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(1, footers.size());
f = footers.get(0);
assertEquals("Signed-off-by", f.getKey());
assertEquals("A. U. Thor <a@example.com>", f.getValue());
assertEquals("a@example.com", f.getEmailAddress());
}
@Test
public void testSignedOffBy_IgnoreWhitespace() {
// We only ignore leading whitespace on the value, trailing
// is assumed part of the value.
//
String msg = buildMessage("subject\n\nbody of commit\n" + "\n"
+ "Signed-off-by: A. U. Thor <a@example.com> \n");
List<FooterLine> footers = FooterLine.fromMessage(msg); FooterLine f;
assertNotNull(footers);
assertEquals(1, footers.size());
f = footers.get(0);
assertEquals("Signed-off-by", f.getKey());
assertEquals("A. U. Thor <a@example.com> ", f.getValue());
assertEquals("a@example.com", f.getEmailAddress());
}
@Test
public void testEmptyValueNoLF() {
String msg = buildMessage("subject\n\nbody of commit\n" + "\n"
+ "Signed-off-by:");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(1, footers.size());
f = footers.get(0);
assertEquals("Signed-off-by", f.getKey());
assertEquals("", f.getValue());
assertNull(f.getEmailAddress());
}
@Test
public void testEmptyValueWithLF() {
String msg = buildMessage("subject\n\nbody of commit\n" + "\n"
+ "Signed-off-by:\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(1, footers.size());
f = footers.get(0);
assertEquals("Signed-off-by", f.getKey());
assertEquals("", f.getValue());
assertNull(f.getEmailAddress());
}
@Test
public void testShortKey() {
String msg = buildMessage("subject\n\nbody of commit\n" + "\n"
+ "K:V\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(1, footers.size());
f = footers.get(0);
assertEquals("K", f.getKey());
assertEquals("V", f.getValue());
assertNull(f.getEmailAddress());
}
@Test
public void testNonDelimtedEmail() {
String msg = buildMessage("subject\n\nbody of commit\n" + "\n"
+ "Acked-by: re@example.com\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(1, footers.size());
f = footers.get(0);
assertEquals("Acked-by", f.getKey());
assertEquals("re@example.com", f.getValue());
assertEquals("re@example.com", f.getEmailAddress());
}
@Test
public void testNotEmail() {
String msg = buildMessage("subject\n\nbody of commit\n" + "\n"
+ "Acked-by: Main Tain Er\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(1, footers.size());
f = footers.get(0);
assertEquals("Acked-by", f.getKey());
assertEquals("Main Tain Er", f.getValue());
assertNull(f.getEmailAddress());
}
@Test
public void testSignedOffBy_ManyUsers() {
String msg = buildMessage("subject\n\nbody of commit\n"
+ "Not-A-Footer-Line: this line must not be read as a footer\n"
+ "\n" // paragraph break, now footers appear in final block
+ "Signed-off-by: A. U. Thor <a@example.com>\n"
+ "CC: <some.mailing.list@example.com>\n"
+ "Acked-by: Some Reviewer <sr@example.com>\n"
+ "Signed-off-by: Main Tain Er <mte@example.com>\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(4, footers.size());
f = footers.get(0);
assertEquals("Signed-off-by", f.getKey());
assertEquals("A. U. Thor <a@example.com>", f.getValue());
assertEquals("a@example.com", f.getEmailAddress());
f = footers.get(1);
assertEquals("CC", f.getKey());
assertEquals("<some.mailing.list@example.com>", f.getValue());
assertEquals("some.mailing.list@example.com", f.getEmailAddress());
f = footers.get(2);
assertEquals("Acked-by", f.getKey());
assertEquals("Some Reviewer <sr@example.com>", f.getValue());
assertEquals("sr@example.com", f.getEmailAddress());
f = footers.get(3);
assertEquals("Signed-off-by", f.getKey());
assertEquals("Main Tain Er <mte@example.com>", f.getValue());
assertEquals("mte@example.com", f.getEmailAddress());
}
@Test
public void testSignedOffBy_SkipNonFooter() {
String msg = buildMessage("subject\n\nbody of commit\n"
+ "Not-A-Footer-Line: this line must not be read as a footer\n"
+ "\n" // paragraph break, now footers appear in final block
+ "Signed-off-by: A. U. Thor <a@example.com>\n"
+ "CC: <some.mailing.list@example.com>\n"
+ "not really a footer line but we'll skip it anyway\n"
+ "Acked-by: Some Reviewer <sr@example.com>\n"
+ "Signed-off-by: Main Tain Er <mte@example.com>\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(4, footers.size());
f = footers.get(0);
assertEquals("Signed-off-by", f.getKey());
assertEquals("A. U. Thor <a@example.com>", f.getValue());
f = footers.get(1);
assertEquals("CC", f.getKey());
assertEquals("<some.mailing.list@example.com>", f.getValue());
f = footers.get(2);
assertEquals("Acked-by", f.getKey());
assertEquals("Some Reviewer <sr@example.com>", f.getValue());
f = footers.get(3);
assertEquals("Signed-off-by", f.getKey());
assertEquals("Main Tain Er <mte@example.com>", f.getValue());
}
@Test
public void testFilterFootersIgnoreCase() {
String msg = buildMessage("subject\n\nbody of commit\n"
+ "Not-A-Footer-Line: this line must not be read as a footer\n"
+ "\n" // paragraph break, now footers appear in final block
+ "Signed-Off-By: A. U. Thor <a@example.com>\n"
+ "CC: <some.mailing.list@example.com>\n"
+ "Acked-by: Some Reviewer <sr@example.com>\n"
+ "signed-off-by: Main Tain Er <mte@example.com>\n");
List<String> footers = FooterLine.getValues(
FooterLine.fromMessage(msg), "signed-off-by");
assertNotNull(footers);
assertEquals(2, footers.size());
assertEquals("A. U. Thor <a@example.com>", footers.get(0));
assertEquals("Main Tain Er <mte@example.com>", footers.get(1));
}
@Test
public void testMatchesBugId() {
String msg = buildMessage("this is a commit subject for test\n"
+ "\n" // paragraph break, now footers appear in final block
+ "Simple-Bug-Id: 42\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(1, footers.size());
FooterLine line = footers.get(0);
assertNotNull(line);
assertEquals("Simple-Bug-Id", line.getKey());
assertEquals("42", line.getValue());
FooterKey bugid = new FooterKey("Simple-Bug-Id");
assertTrue("matches Simple-Bug-Id", line.matches(bugid));
assertFalse("not Signed-off-by", line.matches(FooterKey.SIGNED_OFF_BY));
assertFalse("not CC", line.matches(FooterKey.CC));
}
@Test
public void testMultilineFooters() {
String msg = buildMessage("subject\n\nbody of commit\n"
+ "Not-A-Footer-Line: this line must not be read as a footer\n"
+ "\n" // paragraph break, now footers appear in final block
+ "Notes: The change must not be merged until dependency ABC is\n"
+ " updated.\n"
+ "CC: <some.mailing.list@example.com>\n"
+ "not really a footer line but we'll skip it anyway\n"
+ "Acked-by: Some Reviewer <sr@example.com>\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(3, footers.size());
f = footers.get(0);
assertEquals("Notes", f.getKey());
assertEquals(
"The change must not be merged until dependency ABC is updated.",
f.getValue());
f = footers.get(1);
assertEquals("CC", f.getKey());
assertEquals("<some.mailing.list@example.com>", f.getValue());
f = footers.get(2);
assertEquals("Acked-by", f.getKey());
assertEquals("Some Reviewer <sr@example.com>", f.getValue());
}
@Test
public void testMultilineFooters_multipleWhitespaceAreAllowed() {
String msg = buildMessage("subject\n\nbody of commit\n"
+ "Not-A-Footer-Line: this line must not be read as a footer\n"
+ "\n" // paragraph break, now footers appear in final block
+ "Notes: The change must not be merged until dependency ABC is\n"
+ " updated.\n");
List<FooterLine> footers = FooterLine.fromMessage(msg);
FooterLine f;
assertNotNull(footers);
assertEquals(1, footers.size());
f = footers.get(0);
assertEquals("Notes", f.getKey());
assertEquals(
"The change must not be merged until dependency ABC is updated.",
f.getValue());
}
@Test
public void testFirstLineNeverFooter() {
String msg = buildMessage(
String.join("\n", "First-Line: is never a footer", "Foo: ter",
"1-is: also a footer"));
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(2, footers.size());
}
@Test
public void testLineAfterFooters() {
String msg = buildMessage(
String.join("\n", "Subject line: is never a footer", "Foo: ter",
"1-is: also a footer", "this is not a footer"));
List<FooterLine> footers = FooterLine.fromMessage(msg);
assertNotNull(footers);
assertEquals(2, footers.size());
}
private String buildMessage(String msg) {
StringBuilder buf = new StringBuilder();
buf.append("tree " + ObjectId.zeroId().name() + "\n");
buf.append("author A. U. Thor <a@example.com> 1 +0000\n");
buf.append("committer A. U. Thor <a@example.com> 1 +0000\n");
buf.append("\n");
buf.append(msg);
return buf.toString();
}
}
|
