aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorScott González <scott.gonzalez@gmail.com>2010-02-08 01:17:04 +0000
committerScott González <scott.gonzalez@gmail.com>2010-02-08 01:17:04 +0000
commit1402650134da47f48f6631b98b102f499936c752 (patch)
treed1e85e16d42c04ef755417bbe21ee2b3228862e7
parentf349f9080baf812a33faf742c54e7973c6411b89 (diff)
downloadjquery-ui-1402650134da47f48f6631b98b102f499936c752.tar.gz
jquery-ui-1402650134da47f48f6631b98b102f499936c752.zip
Autocomplete: Fixed a few places that got missed during the change to always keep the menu element around.
Fixes a bug where opening the menu using the arrow keys would cycle through the options, but not show the menu. There's now a bug where you have to arrow too many times to get into the menu when showing the menu by using the arrow keys.
-rw-r--r--ui/jquery.ui.autocomplete.js11
1 files changed, 4 insertions, 7 deletions
diff --git a/ui/jquery.ui.autocomplete.js b/ui/jquery.ui.autocomplete.js
index 470ae1636..c6d2e5578 100644
--- a/ui/jquery.ui.autocomplete.js
+++ b/ui/jquery.ui.autocomplete.js
@@ -92,7 +92,7 @@ $.widget( "ui.autocomplete", {
this.response = function() {
return self._response.apply( self, arguments );
};
- this.menu = $("<ul></ul>")
+ this.menu = $( "<ul></ul>" )
.addClass( "ui-autocomplete" )
.appendTo( this.element.parent() )
.menu({
@@ -139,9 +139,7 @@ $.widget( "ui.autocomplete", {
.removeAttr( "role" )
.removeAttr( "aria-autocomplete" )
.removeAttr( "aria-haspopup" );
- if ( this.menu ) {
- this.menu.element.remove();
- }
+ this.menu.element.remove();
$.Widget.prototype.destroy.call( this );
},
@@ -237,8 +235,7 @@ $.widget( "ui.autocomplete", {
},
_suggest: function( items ) {
- this.menu.element.empty();
- var ul = this.menu.element;
+ var ul = this.menu.element.empty();
$.each( items, function( index, item ) {
$( "<li></li>" )
.data( "item.autocomplete", item )
@@ -253,7 +250,7 @@ $.widget( "ui.autocomplete", {
},
_move: function( direction, event ) {
- if ( !this.menu ) {
+ if ( !this.menu.element.is(":visible") ) {
this.search( null, event );
return;
}