All: Migrate away from deprecated/removed Core APIs

Summary of the changes:

* Build: Add jQuery 3.2.0-3.4.1 to versions UI can be tested against
* Build: Load jQuery & Migrate via HTTPS
* Build: Add package-lock.json to .gitignore
* Build: Update jQuery Migrate from 3.0.0 to 3.1.0
* Build: Allow to run tests against jQuery 3.x-git
* Build: Fix formatting according to JSCS rules
* Build: Disable JSCS for the inlined jQuery Color
* All: Switch from $.isArray to Array.isArray (jQuery.isArray will be
  removed in jQuery 4.0)
* All: Switch from `$.isFunction( x )` to `typeof x === "function"`
  (jQuery.isFunction will be removed in jQuery 4.0)
* All: Inline jQuery.isWindow as it'll be removed in jQuery 4.0
* Effects: Fix a timing issue in a variable declaration. Previously,
  a jQuery object was created, chained & assigned to a variable that
  was then accessed in a callback used inside of this chained
  definition. Due to a timing difference in when the callback fired for
  the first time in latest jQuery master, it was being called before
  the variable was defined.
* Tests: Make dialog & draggable unit tests less strict (newest jQuery
  returns fractional results in some cases, making comparisons fail when
  there's a tiny difference)
* All: Migrate from $.trim to bare String.prototype.trim (jQuery.trim
  will be deprecated in jQuery 3.5)

Closes gh-1901

1 files changed, 5 insertions, 5 deletions

diff --git a/tests/unit/checkboxradio/options.js b/tests/unit/checkboxradio/options.js
index 7fe6a0710..c0fc333c3 100644
--- a/tests/unit/checkboxradio/options.js
+++ b/tests/unit/checkboxradio/options.js
@@ -137,7 +137,7 @@ QUnit.test( "label - default", function( assert ) {
 	widget = checkbox.checkboxradio( "widget" );
 	assert.strictEqual( checkbox.checkboxradio( "option", "label" ),
 		"checkbox label", "When no value passed on create text from dom is used for option" );
-	assert.strictEqual( $.trim( widget.text() ),
+	assert.strictEqual( String.prototype.trim.call( widget.text() ),
 		"checkbox label", "When no value passed on create text from dom is used in dom" );
 } );
 
@@ -152,7 +152,7 @@ QUnit.test( "label - explicit value", function( assert ) {
 
 	assert.strictEqual( checkbox.checkboxradio( "option", "label" ),
 		"foo", "When value is passed on create value is used for option" );
-	assert.strictEqual( $.trim( widget.text() ),
+	assert.strictEqual( String.prototype.trim.call( widget.text() ),
 		"foo", "When value is passed on create value is used in dom" );
 	assert.strictEqual( icon.length, 1,
 		"Icon is preserved when label is set on init when wrapped in label" );
@@ -177,7 +177,7 @@ QUnit.test( "label - explicit null value", function( assert ) {
 	widget = checkbox.checkboxradio( "widget" );
 	assert.strictEqual( checkbox.checkboxradio( "option", "label" ),
 		"checkbox label", "When null is passed on create text from dom is used for option" );
-	assert.strictEqual( $.trim( widget.text() ),
+	assert.strictEqual( String.prototype.trim.call( widget.text() ),
 		"checkbox label", "When null is passed on create text from dom is used in dom" );
 
 } );
@@ -193,13 +193,13 @@ QUnit.test( "label", function( assert ) {
 	checkbox.checkboxradio( "option", "label", "bar" );
 	assert.strictEqual( checkbox.checkboxradio( "option", "label" ),
 		"bar", "When value is passed value is used for option" );
-	assert.strictEqual( $.trim( widget.text() ),
+	assert.strictEqual( String.prototype.trim.call( widget.text() ),
 		"bar", "When value is passed value is used in dom" );
 
 	checkbox.checkboxradio( "option", "label", null );
 	assert.strictEqual( checkbox.checkboxradio( "option", "label" ),
 		"bar", "When null is passed text from dom is used for option" );
-	assert.strictEqual( $.trim( widget.text() ),
+	assert.strictEqual( String.prototype.trim.call( widget.text() ),
 		"bar", "When null is passed text from dom is used in dom" );
 } );