aboutsummaryrefslogtreecommitdiffstats
path: root/tests/unit/spinner
diff options
context:
space:
mode:
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>2020-01-22 16:44:34 +0100
committerGitHub <noreply@github.com>2020-01-22 16:44:34 +0100
commit0c860b0d92f9959f6747f8c02e9671eb2fc561aa (patch)
treeeec1af4f3a9eead707e2674593bda620b5f7c9cb /tests/unit/spinner
parent3481f50bfcf02865857d390a1caa511003a40c13 (diff)
downloadjquery-ui-0c860b0d92f9959f6747f8c02e9671eb2fc561aa.tar.gz
jquery-ui-0c860b0d92f9959f6747f8c02e9671eb2fc561aa.zip
All: Remove usage of jQuery positional selectors
jQuery positional selectors () have been deprecated in [jQuery 3.4.0](https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/) and they'll be removed in jQuery 4.0.0. This PR removes their usage. Most of the changes were possible without changing public API. However, dropping `:even` usage required a change to the [`header` option](https://api.jqueryui.com/accordion/#option-header) of the accordion widget. I made it an optional function; this will need to be documented. The polyfill for `.even()` & `.odd()` is added for jQuery <3.5.0. There was no usage of the :odd selector in the code but the `.odd()` method is also polyfilled for completeness. Closes gh-1904
Diffstat (limited to 'tests/unit/spinner')
-rw-r--r--tests/unit/spinner/options.js12
1 files changed, 6 insertions, 6 deletions
diff --git a/tests/unit/spinner/options.js b/tests/unit/spinner/options.js
index 381e1b7fa..5b1e5db98 100644
--- a/tests/unit/spinner/options.js
+++ b/tests/unit/spinner/options.js
@@ -13,18 +13,18 @@ QUnit.module( "spinner: options" );
QUnit.test( "icons: default ", function( assert ) {
assert.expect( 4 );
var element = $( "#spin" ).val( 0 ).spinner();
- assert.hasClasses( element.spinner( "widget" ).find( ".ui-icon:first" ),
+ assert.hasClasses( element.spinner( "widget" ).find( ".ui-icon" ).first(),
"ui-icon ui-icon-triangle-1-n" );
- assert.hasClasses( element.spinner( "widget" ).find( ".ui-icon:last" ),
+ assert.hasClasses( element.spinner( "widget" ).find( ".ui-icon" ).last(),
"ui-icon ui-icon-triangle-1-s" );
element.spinner( "option", "icons", {
up: "ui-icon-caret-1-n",
down: "ui-icon-caret-1-s"
} );
- assert.hasClasses( element.spinner( "widget" ).find( ".ui-icon:first" ),
+ assert.hasClasses( element.spinner( "widget" ).find( ".ui-icon" ).first(),
"ui-icon ui-icon-caret-1-n" );
- assert.hasClasses( element.spinner( "widget" ).find( ".ui-icon:last" ),
+ assert.hasClasses( element.spinner( "widget" ).find( ".ui-icon" ).last(),
"ui-icon ui-icon-caret-1-s" );
} );
@@ -36,8 +36,8 @@ QUnit.test( "icons: custom ", function( assert ) {
up: "custom-up"
}
} ).spinner( "widget" );
- assert.hasClasses( element.find( ".ui-icon:first" ), "ui-icon custom-up" );
- assert.hasClasses( element.find( ".ui-icon:last" ), "ui-icon custom-down" );
+ assert.hasClasses( element.find( ".ui-icon" ).first(), "ui-icon custom-up" );
+ assert.hasClasses( element.find( ".ui-icon" ).last(), "ui-icon custom-down" );
} );
QUnit.test( "incremental, false", function( assert ) {