diff options
| author | Jörn Zaefferer <joern.zaefferer@gmail.com> | 2012-11-09 18:26:30 +0100 |
|---|---|---|
| committer | Jörn Zaefferer <joern.zaefferer@gmail.com> | 2012-11-26 10:26:12 +0100 |
| commit | 6edce867339c5808eda428fa2566aa40da4b0202 (patch) | |
| tree | fcef6371f225cb00aa25e985b7fb88860f9f2bd6 /ui | |
| parent | f7d3a51589b30fd1be59339ca65b0e4bc6cfac8f (diff) | |
| download | jquery-ui-6edce867339c5808eda428fa2566aa40da4b0202.tar.gz jquery-ui-6edce867339c5808eda428fa2566aa40da4b0202.zip | |
Dialog: Remove attroperty workaround for title attribute. Make the default null, as it should be. No back-compat, as the behaviour doesn't change.
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/jquery.ui.dialog.js | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js index ab32219c2..451203cae 100644 --- a/ui/jquery.ui.dialog.js +++ b/ui/jquery.ui.dialog.js @@ -67,7 +67,7 @@ $.widget("ui.dialog", { }, resizable: true, show: null, - title: "", + title: null, width: 300, // callbacks @@ -85,16 +85,11 @@ $.widget("ui.dialog", { _create: function() { this.originalTitle = this.element.attr( "title" ); - // #5742 - .attr() might return a DOMElement - // TODO WTF? - if ( typeof this.originalTitle !== "string" ) { - this.originalTitle = ""; - } + this.options.title = this.options.title || this.originalTitle; this.oldPosition = { parent: this.element.parent(), index: this.element.parent().children().index( this.element ) }; - this.options.title = this.options.title || this.originalTitle; var that = this, options = this.options, |