aboutsummaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
* Tabs: Properly handle decoded/encoded anchor hashes & panel IDsMichał Gołębiowski-Owczarek4 days2-0/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to jQuery UI 1.14.1, hashes in anchor hrefs were used directly. In gh-2307, that was changed - by decoding - to support more complex IDs, e.g. containing emojis which are automatically encoded in `anchor.hash`. Unfortunately, that broke cases where the panel ID is decoded as well. It turns out the spec mandates checking both. In the "scrolling to a fragment" section of the HTML spec[^1]. That uses a concept of document's indicated part[^2]. Slightly below there's an algorithm to compute the indicated part[^3]. The interesting parts are steps 4 to 9: 4. Let potentialIndicatedElement be the result of finding a potential indicated element given document and fragment. 5. If potentialIndicatedElement is not null, then return potentialIndicatedElement. 6. Let fragmentBytes be the result of percent-decoding fragment. 7. Let decodedFragment be the result of running UTF-8 decode without BOM on fragmentBytes. 8. Set potentialIndicatedElement to the result of finding a potential indicated element given document and decodedFragment. 9. If potentialIndicatedElement is not null, then return potentialIndicatedElement. First, in steps 4-5, the algorithm tries the hash as-is, without decoding. Then, if one is not found, the same is attempted with a decoded hash. This change replicates this logic by first trying the hash as-is and then decoding it. Fixes gh-2344 Closes gh-2345 Ref gh-2307 [^1]: https://html.spec.whatwg.org/#scrolling-to-a-fragment [^2]: https://html.spec.whatwg.org/#the-indicated-part-of-the-document [^3]: https://html.spec.whatwg.org/#select-the-indicated-part
* Tabs: Support URL-based credentialsMichał Gołębiowski-Owczarek4 days1-0/+26
| | | | | | | | | | | | | When credentials are provided directly in the URL, e.g.: https://username:password@www.example.com/ `location.href` strips out the auth part, but anchor links contain them, making our `isLocal` computation broken. This fixes it by only looking at `origin`, `pathname` & `search`. Fixes gh-2213 Closes gh-2345
* Spinner: Prevent double mousewheel & wheel event handlingMichał Gołębiowski-Owczarek2025-03-215-8/+167
| | | | | | | | | | | | | | | | | As of gh-2338, if one has loaded the jQuery MouseWheel plugin, the `mousewheel` handler would fire the `wheel` one, but the `wheel` one would also run in response to the native `wheel` event, resulting in double the distance handled by the spinner. To prevent the issue, only fire the `wheel` handler from inside the `mousewheel` on if the event was triggered by jQuery - jQuery will not care that the underlying event is `wheel` and will only fire handlers for `mousewheel`. Also, add an iframe test using jQuery MouseWheel to not affect all the other tests. Plus, migrate from `QUnit.reset` to `QUnit.done` (see qunitjs/qunit#354). Closes gh-2342 Ref gh-2338
* Spinner: Drop dependency on jQuery MousewheelMichał Gołębiowski-Owczarek2025-03-181-1/+41
| | | | | | | 1. Listen to the native `wheel` event without depending on any wrapper plugins. 2. Keep listening to the `mousewheel` event for compatibility with projects using the jQuery Mousewheel plugin but route it to the `wheel` handler. Closes gh-2338
* Build: Remove an obsolete `test/.eslintrc.json` fileMichał Gołębiowski-Owczarek2025-03-181-26/+0
| | | | | | The file was erroneously left in during the migration to the flat config. Closes gh-2340 Ref gh-2336
* Tests: Migrate test runner to jquery-test-runnerTimmy Willison2025-01-1423-1849/+0
| | | Closes gh-2325
* Widget: Don't let widget name affect `$.ui` prototype & constructorMichał Gołębiowski-Owczarek2024-10-301-0/+22
| | | | | | This is an edge case and it only affects code accepting untrusted input as a widget name, but it's still technically correct to filter these out. Closes gh-2310
* Build: Fix an XSS in the test server HTML serving logicMichał Gołębiowski-Owczarek2024-10-281-1/+1
| | | | | | | | | | | The test server has a rule for `/tests/unit/*/*.html` paths that serves a proper local file. However, the parameters after `/unit/` so far accepted many characters that have special meaning, leading to possibly reading a file from outside of the Git repository. Fix that by only accepting alphanumeric characters, `-` or `_`. This should resolve one CodeQL alert. Closes gh-2309
* Tabs: Use `CSS.escape` for sanitizing selectorsMichał Gołębiowski-Owczarek2024-10-272-2/+32
| | | | | | The previous private `_sanitizeSelector` API was not correctly escaping backslashes and is now removed. The native API should always be correct. Closes gh-2307
* Tests: Fix titles of `jquery-patch.js` testsMichał Gołębiowski-Owczarek2024-10-252-2/+2
| | | | | The pages were erroneously titled after "Form Reset Mixin". Closes gh-2308
* Demos: Remove deprecated button APIsMichał Gołębiowski-Owczarek2024-09-301-7/+3
| | | | | | | | Remove usage of deprecated button options: * `icons`: https://jqueryui.com/upgrade-guide/1.12/#deprecated-icons-options-in-favor-of-icon-and-iconposition * `text`: https://jqueryui.com/upgrade-guide/1.12/#deprecated-text-option-in-favor-of-showlabel Fixes gh-2295 Closes gh-2296
* Effect: Remove demos & visual tests of the transfer effectMichał Gołębiowski-Owczarek2024-09-162-14/+0
| | | | | | | | | The transfer effect is deprecated and not present unless `$.uiBackCompat` is set to `true`. In previous UI versions, the default was including the backwards compat layer so these demos & tests worked; now they do not by default. Just remove them. Fixes gh-2278 Closes gh-2291
* Resizable: Fix content shrink on resizeDaniel García2024-09-092-7/+123
| | | | | | | Make resizable elements not shrink on resize when they have scrollbars and "box-sizing: content-box". Fixes: gh-2277 Closes gh-2281
* Dialog: Add option to put the dialog title in a header elementRalf Koller2024-09-093-0/+40
| | | | | | | | | Implement a new option: `uiDialogTitleHeadingLevel`, allowing to change the `span` wrapping the dialog title into a heading element (`h1`-`h6`). Value `0` represents the `span`, values 1-6 - a heading at the specified level. Fixes gh-2271 Closes gh-2275
* Tests: Properly check `$.uiBackCompat` in common widget testsMichał Gołębiowski-Owczarek2024-09-091-3/+14
| | | | | | | | | | | | | The "common widget" tests, checking if a widget doesn't overwrite some core widget APIs wasn't running as it was incorrectly checking for `$.uiBackCompat === false` instead of `$.uiBackCompat !== true` after the default changed in gh-2250. Fixing the check uncovered that the draggable & sortable modules do overwrite the `_trigger` method. Add an exception in the test for that; at this stage of the project we don't plan to change the implementation. Closes gh-2286 Ref gh-2250
* Datepicker: Hide the UI on destroyPorter Clevidence2024-08-051-1/+10
| | | | | | | | | | | | When the datepicker UI is shown and then destroyed programmatically: ```js $( "#datepicker" ).datepicker( "destroy" ); ``` hide the datepicker UI without the need for an explicit user action. Previously, in 1.12 the UI would not disappear immediately but only after the first `mousedown`. In later 1.13 versions, the UI would not disappear at all. Fixes gh-2178 Closes gh-2268
* Tests: Update jQuery Migrate from 3.4.1 to 3.5.2, simplify Migrate setupMichał Gołębiowski-Owczarek2024-07-301-2/+2
| | | | | | | | Apart from updating jQuery Migrate, the setup is now changed so that exact Migrate versions are only references when fetching npm packages; other than that, they're represented as `jquery-migrate-1.x` & `jquery-migrate-3.x`. This will allow smaller changes when updating jQuery Migrate in the future. Closes gh-2273
* Dialog: Add aria-modal supportRalf Koller2024-06-141-0/+33
| | | | | | | | | | | | Reflect the `modal` dialog option into the `aria-modal` attribute - when `modal` is `true`, set `aria-modal` to `"true"`. This helps some accessibility tools like VoiceOver with their rotor functionality as it reduces the number of elements presented. Fixes gh-2246 Closes gh-2257 Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
* Tests: remove testswarm grunt taskTimmy Willison2024-06-111-3/+0
| | | Closes gh-2263
* Tests: remove code supporting jenkins and testswarmTimmy Willison2024-05-152-14/+4
| | | Close gh-2251
* Tests: Fix form-reset-mixin test module name, add to the tests HTMLMichał Gołębiowski-Owczarek2024-05-152-1/+2
| | | | Ref gh-2249
* All: Remove the deprecated `ui/core.js` fileMichał Gołębiowski-Owczarek2024-05-151-10/+4
| | | | | | Also, fix checkboxradio visual tests. Ref gh-2249
* All: Stop relying on jquery-patch.js internally, add testsMichał Gołębiowski-Owczarek2024-05-158-9/+207
| | | | | | | | | | | | Avoid relying on jQuery patches. Instead: * use `CSS.escape` instead of `jQuery.escapeSelector` * use `.filter()` with a proper handler instead of `.even()` Keep `jquery-patch.js` for backwards compatibility, though. Also, add tests for jquery-patch. Ref gh-2249
* All: Drop support for IE & some other browsers (but mostly IE)Michał Gołębiowski-Owczarek2024-05-1516-304/+170
| | | | Closes gh-2249
* All: Drop support for jQueries different than the latest for each majorMichał Gołębiowski-Owczarek2024-05-1512-156/+32
| | | | | | Also, remove the ability to run the test suite in jQuery <1.12.4 & <2.2.4. Closes gh-2249
* Core: Make back compat disabled by defaultMichał Gołębiowski-Owczarek2024-05-136-17/+18
| | | Closes gh-2250
* Docs: Update leftover HTTP Trac URLs to HTTPSMichał Gołębiowski-Owczarek2024-04-264-15/+15
|
* Docs: Change a few most common domains from HTTP to HTTPSMichał Gołębiowski-Owczarek2024-04-2610-21/+21
| | | | | Also, update a few stale URLs to what they redirect now to. Closes gh-2244
* Tests: Skip a problematic keyboard test in IE with jQuery 3.6Michał Gołębiowski-Owczarek2024-04-121-1/+7
| | | | | | jQuery 3.6 has issues with focus handling in IE which breaks this test. The issues were fixed in jQuery 3.7, so we just accept them here. Closes gh-2231
* Tests: Increase robustness of a draggable `revert` testMichał Gołębiowski-Owczarek2024-04-121-2/+3
| | | | | | | | One of the changes is increasing `revertDuration` from 200 to 300. For some reason, when jQuery 3.1 is used in an iframe (which TestSwarm uses) the timings are lower than expected and `setTimeout` too slow and the check for animation happens too late. Closes gh-2230
* Tests: Workaround a jQuery 1.8 issue with one dialog testMichał Gołębiowski-Owczarek2024-04-121-0/+18
| | | | | | | The test "#8958: dialog can be opened while opening" had special behavior in jQuery 1.8 and the patch from commit 7adb13ac7c30a7ba33f1db256952be77b9e7a310 broke those assumptions. Adjust the test so that it passes again. Closes gh-2229
* Tests: align test runner with other reposTimmy Willison2024-04-0917-240/+882
| | | Close gh-2234
* Tests: replace grunt-contrib-qunit with jQuery test runnerTimmy Willison2024-03-2922-13/+1217
| | | | | - add filestash workflow Close gh-2221
* Tests: Fix tests with the Git Core buildMichał Gołębiowski-Owczarek2024-03-261-1/+2
| | | | | | jQuery PR jquery/jquery#5452 removed special handling of boolean attributes. Thankfully, this only broke a single jQuery UI test. Closes gh-2220
* Build: Add jQuery 3.7.0Michał Gołębiowski-Owczarek2023-05-123-1/+3
|
* Tests: Workaround IE issues in qunit-assert-domequalMichał Gołębiowski-Owczarek2023-05-101-16/+19
| | | | | | | | | | In IE, `option` elements may have different initial `option` colors. They may initially all be transparent, but later the selected option gets a blue background with white text; we now ignore it. The logic of `qunit-assert-domequal` was also fixed to use the same method of fetching styles in all browsers; IE used to get a legacy one meant for IE <9 due to a mistake in the performed check.
* Tests: Make resizable tests a bit more forgivingMichał Gołębiowski-Owczarek2023-05-101-6/+16
|
* Tests: Workaround a dialog test issue by a proper cleanupMichał Gołębiowski-Owczarek2023-05-101-2/+9
| | | | | The `#favorite-animal` focus & blur handlers used to not be cleaned up after the test automatically, leading to issues with some jQuery versions.
* Tests: Fix selectmenu width tests in Firefox with jQuery 3.0 & 3.1Michał Gołębiowski-Owczarek2023-05-101-2/+3
| | | | | | | | jQuery 3.0 & 3.1 used `getBoundingClientRect()` in its `width`/`height` calculations and that causes minor differences in fractional width computations. Allow a tiny delta in tests to fix those tests breaking in Firefox. Ref jquery/jquery#3561 Closes gh-2159
* Selectmenu: Fix selecting options following hidden onesMichał Gołębiowski-Owczarek2023-05-101-3/+62
| | | | | | | | | | | Change a2b25ef6caae3e1a272214839b815a6387618124 made options with the `hidden` attribute skipped when rendering. However, that makes indexes misaligned with native options as hidden ones maintain their index values. Instead, don't skip hidden options but add the `hidden` attribute to the respective jQuery UI elements as well. Fixes gh-2082 Closes gh-2144 Ref a2b25ef6caae3e1a272214839b815a6387618124
* Build: Add jQuery 3.6.4, update Migrate to 3.4.1Michał Gołębiowski-Owczarek2023-05-103-4/+4
| | | Closes gh-2161
* Build: Fork vendors to remove QUnit deprecated API usageMichał Gołębiowski-Owczarek2023-05-1036-69/+920
| | | | | | | | | | | | Changes: * add `tests/lib/vendor/**/*` to `.eslintignore` * move `qunit-composite` to `tests/lib` so that we can modify it * move `qunit-assert-classes` to `tests/lib` so that we can modify it * move `qunit-assert-close` to `tests/lib` so that we can modify it * replace `assert.push` with `assert.pushResult` * remove usage of `QUnit.extend` Closes gh-2157
* Tests: Make Puppeter really fire Chrome on macOSMichał Gołębiowski-Owczarek2023-05-102-0/+22
| | | | | | | | | | | Also, workaround issues with QUnit Chrome bridge: the Chrome bridge from `grunt-contrib-qunit` is now getting injected into every single iframe, including an empty one that has no intention of running QUnit tests. Since that bridge requires QUnit, it fails with an error in such cases. Workaround the issue by wrapping the bridge in another function that bails early if QUnit is not defined. Ref gh-2157
* Tests: Switch from QUnit.jsDump to QUnit.dumpMichał Gołębiowski-Owczarek2023-05-101-1/+1
| | | | | | `QUnit.jsDump` was renamed to `QUnit.dump` in QUnit 2.0. Ref gh-2157
* Tests: Fix tooltip tests by destroying tooltipsMichał Gołębiowski-Owczarek2023-05-105-5/+34
| | | | | | | Some tests were not properly destroying tooltips which made tests start to fail with the new QUnit. Ref gh-2157
* Demos:Tests: Avoid self-closing HTML tagsMichał Gołębiowski-Owczarek2023-05-103-15/+15
| | | | | | | | | Self-closing tags are reported by newer versions of the htmllint Grunt plugin. They also don't make sense in our HTML files since they are not XHTML-compliant and they run in HTML mode anyway. Ref gh-2157
* Tests: Test only valid values for Datepicker defaultDate, min/maxDateKenneth DeBacker2023-03-301-14/+14
| | | | | | | The docs say that valid periods when using string value and period pairs as relative dates are "y", "m", "w", and "d" https://api.jqueryui.com/datepicker/ Closes gh-2143
* Build: Add jQuery 3.6.1-3.6.3, update Migrate to 3.4.0Michał Gołębiowski-Owczarek2023-01-153-4/+4
|
* Resizable: Fix resizing of elems with `box-sizing: border-box`Matías Cánepa2022-10-101-0/+26
| | | | Fixes gh-1979 Closes gh-2012
* Checkboxradio: Don't re-evaluate text labels as HTMLMichał Gołębiowski-Owczarek2022-07-143-0/+87
| | | | | | | | | | | | | If you generate a Checkboxradio from a checkbox/radio with a label that contains encoded HTML, e.g. `&lt;em&gt;test&lt;/em&gt;` this will work fine at first. If, however a refresh is triggered on that instance (explicitly or e.g. by turning it into a `Controlgroup`), the previously escaped HTML will now be evaluated. If the label was created based on some user input, this could lead to unexpected code execution even though the initial output was escaped. Fixes gh-2101 Closes gh-2102
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-05 00:18:46 +0000