diff options
| author | Timmy Willison <4timmywil@gmail.com> | 2018-12-03 12:03:04 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-03 12:03:04 -0500 |
| commit | 13f3cd1611d7905c6fadcf2f8a533096b347a6ad (patch) | |
| tree | d4605170163c6e9733c685309a145d504ddc457f | |
| parent | 315199c156c5b822a857ca236bda123f01a2da37 (diff) | |
| download | jquery-13f3cd1611d7905c6fadcf2f8a533096b347a6ad.tar.gz jquery-13f3cd1611d7905c6fadcf2f8a533096b347a6ad.zip | |
Tests: fix dimensions tests in testswarm
Close gh-4248
| -rw-r--r-- | test/unit/dimensions.js | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/test/unit/dimensions.js b/test/unit/dimensions.js index 36b07f11e..223e17b0a 100644 --- a/test/unit/dimensions.js +++ b/test/unit/dimensions.js @@ -757,7 +757,11 @@ QUnit.test( "outerWidth/Height for table cells and textarea with border-box in I $firstTh = jQuery( "<th style='width: 200px;padding: 5px' />" ), $secondTh = jQuery( "<th style='width: 190px;padding: 5px' />" ), $thirdTh = jQuery( "<th style='width: 180px;padding: 5px' />" ), - $td = jQuery( "<td style='height: 20px;padding: 5px;border: 1px solid'>text</td>" ), + // Support Firefox 63, Edge 16-17, Android 8, iOS 7-11 + // These browsers completely ignore the border-box and height settings + // The computed height is instead just line-height + border + // Either way, what we're doing in css.js is correct + $td = jQuery( "<td style='height: 20px;padding: 5px;border: 1px solid;line-height:18px'>text</td>" ), $tbody = jQuery( "<tbody />" ).appendTo( $table ), $textarea = jQuery( "<textarea style='height: 0;padding: 2px;border: 1px solid;box-sizing: border-box' />" ).appendTo( "#qunit-fixture" ); jQuery( "<tr />" ).appendTo( $thead ).append( $firstTh ); |