aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortimmywil <tim.willison@thisismedium.com>2011-05-07 22:01:10 -0400
committertimmywil <tim.willison@thisismedium.com>2011-05-07 22:01:10 -0400
commit18b1cf2942cc082c1c97a2ac9bc33ad77f42d775 (patch)
tree6e573b7cfeda188cb0e27205254b9cbd2c955086
parent90f37aaf7aa7c6da96ab15488b63b2eb45a2e799 (diff)
downloadjquery-18b1cf2942cc082c1c97a2ac9bc33ad77f42d775.tar.gz
jquery-18b1cf2942cc082c1c97a2ac9bc33ad77f42d775.zip
Remove value check from formHook; other elements can use value hook
-rw-r--r--src/attributes.js3
-rw-r--r--test/unit/attributes.js4
2 files changed, 3 insertions, 4 deletions
diff --git a/src/attributes.js b/src/attributes.js
index 4d1644706..c207a001c 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -495,9 +495,6 @@ if ( !jQuery.support.getSetAttribute ) {
formHook = jQuery.attrHooks.name = jQuery.attrHooks.value = jQuery.valHooks.button = {
get: function( elem, name ) {
var ret;
- if ( name === "value" && !jQuery.nodeName( elem, "button" ) ) {
- return elem.getAttribute( name );
- }
ret = elem.getAttributeNode( name );
// Return undefined if nodeValue is empty string
return ret && ret.nodeValue !== "" ?
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 37e93d0a1..ce7775d1d 100644
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -144,7 +144,7 @@ test("attr(Hash)", function() {
});
test("attr(String, Object)", function() {
- expect(58);
+ expect(59);
var div = jQuery("div").attr("foo", "bar"),
fail = false;
@@ -244,6 +244,8 @@ test("attr(String, Object)", function() {
table.attr("cellspacing", "2");
equals( table[0].cellSpacing, "2", "Check cellspacing is correctly set" );
+ equals( jQuery("#area1").attr("value"), undefined, "Value attribute retrieved correctly on textarea." );
+
// for #1070
jQuery("#name").attr("someAttr", "0");
equals( jQuery("#name").attr("someAttr"), "0", "Set attribute to a string of \"0\"" );