aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>2019-10-28 20:38:33 +0100
committerMichał Gołębiowski-Owczarek <m.goleb@gmail.com>2019-10-28 20:43:39 +0100
commita612733be0c68d337647a6fcc8f8e0cabc1fc36b (patch)
tree0aec25343cd5dea540329b4c30291f91d400421c
parent323575fb9bb330a852718d89e323f7ec79549100 (diff)
downloadjquery-a612733be0c68d337647a6fcc8f8e0cabc1fc36b.tar.gz
jquery-a612733be0c68d337647a6fcc8f8e0cabc1fc36b.zip
Tests: Skip a "width/height on a table row with phantom borders" test in Firefox
Firefox 70 & newer fail this test but the issue there is more profound - Firefox doesn't subtract borders from table row computed widths. Closes gh-4537 Ref jquery/jquery#4529 Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1590837 Ref w3c/csswg-drafts#4444 (cherry picked from commit c79e1d5fefc50b1df0a1c2ca3f06b567e79c0f9b)
-rw-r--r--test/unit/dimensions.js9
1 files changed, 8 insertions, 1 deletions
diff --git a/test/unit/dimensions.js b/test/unit/dimensions.js
index d20a56c3b..35fd13151 100644
--- a/test/unit/dimensions.js
+++ b/test/unit/dimensions.js
@@ -627,7 +627,14 @@ QUnit.test( "width/height on an inline element with percentage dimensions (gh-36
}
);
-QUnit.test( "width/height on a table row with phantom borders (gh-3698)", function( assert ) {
+// Support: Firefox 70+
+// Firefox 70 & newer fail this test but the issue there is more profound - Firefox doesn't
+// subtract borders from table row computed widths.
+// See https://github.com/jquery/jquery/issues/4529
+// See https://bugzilla.mozilla.org/show_bug.cgi?id=1590837
+// See https://github.com/w3c/csswg-drafts/issues/4444
+QUnit[ /firefox/i.test( navigator.userAgent ) ? "skip" : "test" ](
+ "width/height on a table row with phantom borders (gh-3698)", function( assert ) {
assert.expect( 4 );
jQuery( "<table id='gh3698' style='border-collapse: separate; border-spacing: 0;'><tbody>" +