aboutsummaryrefslogtreecommitdiffstats
path: root/test/unit/css.js
diff options
context:
space:
mode:
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>2024-11-26 00:23:19 +0100
committerGitHub <noreply@github.com>2024-11-26 00:23:19 +0100
commit640d5825df5ff223560c5690f1a268681c32f9fa (patch)
tree8122dd698b06a171a482e3bbab2bf07de39975ff /test/unit/css.js
parente4b5e6227717039a9c695b12e40d3f73ffec31b0 (diff)
downloadjquery-640d5825df5ff223560c5690f1a268681c32f9fa.tar.gz
jquery-640d5825df5ff223560c5690f1a268681c32f9fa.zip
CSS: Drop the cache in finalPropName
The `finalPropName` util caches properties detected to require a vendor prefix. This used to cache unprefixed properties as well, but it was reported that this logic broke accidentally during a refactor. Since fewer & fewer properties require a vendor prefix and caching a few basic checks likely has negligible perf benefits, opt to saving a few bytes and remove the cache. Closes gh-5583 Ref gh-5582
Diffstat (limited to 'test/unit/css.js')
-rw-r--r--test/unit/css.js34
1 files changed, 24 insertions, 10 deletions
diff --git a/test/unit/css.js b/test/unit/css.js
index d872e52bb..e232f5db0 100644
--- a/test/unit/css.js
+++ b/test/unit/css.js
@@ -1705,7 +1705,7 @@ QUnit.test( "Do not throw on frame elements from css method (trac-15098)", funct
( function() {
var vendorPrefixes = [ "Webkit", "Moz", "ms" ];
- QUnit.test( "Don't default to a cached previously used wrong prefixed name (gh-2015)", function( assert ) {
+ QUnit.test( "Don't default to a previously used wrong prefixed name (gh-2015)", function( assert ) {
// Note: this test needs a property we know is only supported in a prefixed version
// by at least one of our main supported browsers. This may get out of date so let's
@@ -1759,18 +1759,32 @@ QUnit.test( "Do not throw on frame elements from css method (trac-15098)", funct
assert.equal( elemStyle.undefined, undefined, "Nothing writes to node.style.undefined" );
} );
- QUnit.test( "Don't detect fake set properties on a node when caching the prefixed version", function( assert ) {
- assert.expect( 1 );
+} )();
- var elem = jQuery( "<div></div>" ),
- style = elem[ 0 ].style;
- style.MozFakeProperty = "old value";
- elem.css( "fakeProperty", "new value" );
+QUnit.test( "Don't update existing unsupported prefixed properties", function( assert ) {
+ assert.expect( 1 );
- assert.equal( style.MozFakeProperty, "old value", "Fake prefixed property is not cached" );
- } );
+ var elem = jQuery( "<div></div>" ),
+ style = elem[ 0 ].style;
+ style.MozFakeProperty = "old value";
+ elem.css( "fakeProperty", "new value" );
-} )();
+ assert.equal( style.MozFakeProperty, "old value", "Fake prefixed property is not set" );
+} );
+
+QUnit.test( "Don't set fake prefixed properties when a regular one is missing", function( assert ) {
+ assert.expect( 5 );
+
+ var elem = jQuery( "<div></div>" ),
+ style = elem[ 0 ].style;
+ elem.css( "fakeProperty", "fake value" );
+
+ assert.strictEqual( style.fakeProperty, "fake value", "Fake unprefixed property is set" );
+ assert.strictEqual( style.webkitFakeProperty, undefined, "Fake prefixed property is not set (webkit)" );
+ assert.strictEqual( style.WebkitFakeProperty, undefined, "Fake prefixed property is not set (Webkit)" );
+ assert.strictEqual( style.MozFakeProperty, undefined, "Fake prefixed property is not set (Moz)" );
+ assert.strictEqual( style.msFakeProperty, undefined, "Fake prefixed property is not set (ms)" );
+} );
// IE doesn't support CSS variables.
QUnit.testUnlessIE( "css(--customProperty)", function( assert ) {