diff options
| author | Michał Gołębiowski-Owczarek <m.goleb@gmail.com> | 2023-02-01 13:46:44 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-01 13:46:44 +0100 |
| commit | 0b9c5037f707a0b8e0dbb11776b690ae7dde7123 (patch) | |
| tree | 4672b38c1e2c883e4818df7be41640ec077ffabb /test | |
| parent | 6d1364431b63b0d3bbe1c5fd604131f9db453396 (diff) | |
| download | jquery-0b9c5037f707a0b8e0dbb11776b690ae7dde7123.tar.gz jquery-0b9c5037f707a0b8e0dbb11776b690ae7dde7123.zip | |
Deferred: Respect source maps in jQuery.Deferred.exceptionHook
So far, `jQuery.Deferred.exceptionHook` used to log error message and stack
separately. However, that breaks browser applying source maps against the stack
trace - most browsers require logging an error instance. This change makes us
do exactly that.
One drawback of the change is that in IE 11 previously stack was printed
directly and now just the error summary; to get to the actual stack
trace, three clicks are required. This seems to be a low price to pay
for having source maps work in all the other browsers, though.
Safari with the new change requires one click to get to the stack trace
which sounds manageable.
Fixes gh-3179
Closes gh-5192
Ref https://crbug.com/622227
Diffstat (limited to 'test')
| -rw-r--r-- | test/unit/deferred.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/unit/deferred.js b/test/unit/deferred.js index 535dc0115..8a215ff99 100644 --- a/test/unit/deferred.js +++ b/test/unit/deferred.js @@ -575,9 +575,9 @@ QUnit.test( "jQuery.Deferred.exceptionHook", function( assert ) { defer = jQuery.Deferred(), oldWarn = window.console.warn; - window.console.warn = function() { - var msg = Array.prototype.join.call( arguments, " " ); - assert.ok( /barf/.test( msg ), "Message: " + msg ); + window.console.warn = function( _intro, error ) { + assert.ok( /barf/.test( error.message + "\n" + error.stack ), + "Error mentions the method: " + error.message + "\n" + error.stack ); }; jQuery.when( |