df4e6bab69
Merge pull request #29115 from nextcloud/work/carl/correct-permissions-when-copying
Fix permissions when copying from ObjectStorage
2 years ago
bfa60aaf27
Fix permissions when copying from ObjectStorage
Make sure that when a user copy a file from a directory they don't have
all permissions to a directory where they have more permissions, the
permissions are correctly set to the one from the parent taget folder.
This was caused by the ObjectStoreStorage::copyFromStorage using
the jailed storage and cache entry instead of the unjailed one like other
storages (the local one).
Steps to reproduce
+ Use object storage
+ Create a groupfolder with one group having full permission and another one
who can just read files.
+ With an user who is in the second group, copy a file from the groupfolder to
the home folder of this user.
+ The file in the home folder of the user will be read only and can't be deleted
even though it is in their home folder and they are the owner. In oc_filecache,
the permissions stored for this file are 1 (READ)
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2 years ago
74cfe7348d
Merge pull request #29444 from nextcloud/bugfix/noid/public-api-for-trusted-domain-helpers
Add an OCP for trusted domain helper
2 years ago
c42f5bc5f6
Add an OCP for trusted domain helper
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 years ago
9b7258fca5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2 years ago
1666bb0790
Merge pull request #29454 from nextcloud/bugfix/noid/detect-mimetype-by-content-only-with-content
Detect mimetype by content only with content
2 years ago
3f8ca991fc
Merge pull request #29453 from nextcloud/bugfix/noid/improve-wording
2 years ago
7a6d559f19
Detect mimetype by content only with content
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 years ago
ac7930bf1f
Merge pull request #29327 from nextcloud/bugfix/noid/do-not-make-actionbuttons-spans-too-transparent
2 years ago
9a18bd7abf
Improve wording
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 years ago
325606c8e4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2 years ago
bb39a21079
Merge pull request #29436 from nextcloud/fix/profile-link-action-registration
2 years ago
7b1cdf1fa6
Prevent unnecesary profile action registrations
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2 years ago
1b366a033a
Merge pull request #29435 from nextcloud/explicitly-name-profile-link-action
2 years ago
f9629c0cb1
Merge pull request #26841 from nextcloud/bugfix/files-search-filter
Implement local filtering in file list
2 years ago
b691f30af1
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2 years ago
9f8eae3f50
Use more explicit naming for profile link action
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2 years ago
9177afe8ab
Merge pull request #29318 from nextcloud/fix/dav-availability-settings-timezone-id
Read and write time zone ID when updating CalDAV availability
2 years ago
9c937a63bf
Move to combined files entrypoint
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2 years ago
584d275a50
Fix "No entries in this …" template
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
df0efe0d62
Implement local filtering in file list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
a34f94df69
Get VTIMEZONE data from a time zone database lib
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2 years ago
9356124700
Merge pull request #29021 from nextcloud/work/smb/additional-logging
2 years ago
317d97309f
Merge pull request #27949 from CarlSchwan/work/carl/password-reset-autocomplete
Add autocompletion for password reset
2 years ago
9b6238aabd
Read and write time zone ID when updating CalDAV availability
Tiny bug/limitation of #27466
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2 years ago
d231d2618d
Merge pull request #29425 from nextcloud/revert-28138-zorn-v-patch-2
2 years ago
8ea91b4364
Merge pull request #26531 from J0WI/refactor-preview-exec
2 years ago
06611e4780
Revert "Fix "never catch" catches in OC_App"
2 years ago
dc9b05256c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2 years ago
7629bc83d8
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2 years ago
047cab8dd2
Use findBinaryPath for previews
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
3 years ago
623ac8c706
Merge pull request #28389 from alanmeeson/bugfix/22077/default-encryption-module
2 years ago
16f70e8647
Add type hint to fread_block $blockSize param & apply cs:fix.
Signed-off-by: alanmeeson <alan@carefullycalculated.co.uk>
2 years ago
44c332a46e
Fix truncation of files upon read when using object store and encryption.
When using and object store as primary storage and using the default
encryption module at the same time, any encrypted file would be truncated
when read, and a text error message added to the end.
This was caused by a combination of the reliance of the read functions on
on knowing the unencrypted file size, and a bug in the function which
calculated the unencrypted file size for a given file.
In order to calculate the unencrypted file size, the function would first
skip the header block, then use fseek to skip to the last encrypted block
in the file. Because there was a corresponence between the encrypted and
unencrypted blocks, this would also be the last encrypted block. It would
then read the final block and decrypt it to get the unencrypted length of
the last block. With that, the number of blocks, and the unencrypted block
size, it could calculate the unencrypted file size.
The trouble was that when using an object store, an fread call doesn't
always get you the number of bytes you asked for, even if they are
available. To resolve this I adapted the stream_read_block function from
lib/private/Files/Streams/Encryption.php to work here. This function
wraps the fread call in a loop and repeats until it has the entire set of
bytes that were requested, or there are no more to get.
This fixes the imediate bug, and should (with luck) allow people to get
their encrypted files out of Nextcloud now. (The problem was purely on
the decryption side). In the future it would be nice to do some
refactoring here.
I have tested this with image files ranging from 1kb to 10mb using
Nextcloud version 22.1.0 (the nextcloud:22.1-apache docker image), with
sqlite and a Linode object store as the primary storage.
Signed-off-by: Alan Meeson <alan@carefullycalculated.co.uk>
2 years ago
2b651cc022
Merge pull request #29400 from nextcloud/fix/noid/undef-index-error
fixes an undefined index when getAccessList returns an empty array
2 years ago
f4e4a85fcf
Merge pull request #27440 from nextcloud/is-file-handle
2 years ago
c5e9f379bd
Merge pull request #28138 from nextcloud/zorn-v-patch-2
2 years ago
a06001e085
Merge pull request #29363 from nextcloud/fair-use-push
2 years ago
7e117da435
Merge pull request #29397 from nextcloud/fix/noid/profile-missing-def-values
2 years ago
811670a3ad
Merge pull request #29413 from nextcloud/dependabot/npm_and_yarn/testing-library/user-event-13.5.0
2 years ago
6bd9076427
Merge pull request #29412 from nextcloud/dependabot/npm_and_yarn/webpack-cli-4.9.1
2 years ago
8885f31b82
Merge pull request #29408 from nextcloud/dependabot/composer/build/integration/behat/behat-approx-3.9.0
2 years ago
5136fcc35a
Merge pull request #29402 from nextcloud/dependabot/npm_and_yarn/sass-1.43.3
2 years ago
475d3a6521
Bump @testing-library/user-event from 13.4.1 to 13.5.0
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event ) from 13.4.1 to 13.5.0.
- [Release notes](https://github.com/testing-library/user-event/releases )
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md )
- [Commits](https://github.com/testing-library/user-event/compare/v13.4.1...v13.5.0 )
---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
12171669c5
Merge pull request #29401 from nextcloud/dependabot/npm_and_yarn/babel-loader-8.2.3
2 years ago
7c2d8d3e82
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2 years ago
6f36a97d34
Bump webpack-cli from 4.9.0 to 4.9.1
Bumps [webpack-cli](https://github.com/webpack/webpack-cli ) from 4.9.0 to 4.9.1.
- [Release notes](https://github.com/webpack/webpack-cli/releases )
- [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack/webpack-cli/compare/webpack-cli@4.9.0...webpack-cli@4.9.1 )
---
updated-dependencies:
- dependency-name: webpack-cli
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
400f1a7938
Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat ) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases )
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md )
- [Commits](https://github.com/Behat/Behat/compare/v3.8.0...v3.9.0 )
---
updated-dependencies:
- dependency-name: behat/behat
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
f664fa8c84
Bump sass from 1.43.2 to 1.43.3
Bumps [sass](https://github.com/sass/dart-sass ) from 1.43.2 to 1.43.3.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.43.2...1.43.3 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
20c613af47
Bump babel-loader from 8.2.2 to 8.2.3
Bumps [babel-loader](https://github.com/babel/babel-loader ) from 8.2.2 to 8.2.3.
- [Release notes](https://github.com/babel/babel-loader/releases )
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel-loader/compare/v8.2.2...v8.2.3 )
---
updated-dependencies:
- dependency-name: babel-loader
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2 years ago
Carl Schwan
Joas Schilling
Joas Schilling
Nextcloud bot
blizzz
John Molakvoæ
Christopher Ng
Vincent Petry
Christoph Wurst
Julius Härtl
Christoph Wurst
Louis
J0WI
alanmeeson
dependabot[bot]