It's perfectly safe to delete NULL pointers, so simplify things by
removing these checks.

Gives us a more meaningful error rather than just "Error in push/pull
function".

Having this early check means that we somewhat randomly get different
exception behaviours on errors in deeper layers as some exceptions are
allowed to propagate unhindered and some are not (since they are thrown
in the pull function).

Give GnuTLS the correct errno from deeper layers, in the cases where we
know it. In most cases GnuTLS doesn't care, but just in case...

Travis has unfortunately been severely rate limited by Docker Hub so we
have to switch to GitHub, which has an agreement with Docker to avoid
the rate limiting.

No TTY is provided in GitHub's environment, so we cannot have this flag.

Otherwise cmake breaks as it requires a newer version without properly
listing that in its dependencies.

These are incompatible with functions such as gettext() as clang hasn't
implemented the function attribute function_arg.

A initial workflow needs to be defined for actions to trigger on pull
requests, so just add a minimal, dummy one.

CharArray should always be null-terminated. There is a potential
scenario where this all might lead to crash. In Password we call
memset(), passing length of the array we get with strlen(), but
this won't return correct value when the array is not properly
null-terminated.

Give people a chance to know about the documentation.

It's almost mandatory to specify "session", but fairly rare to need to
set "desktop", so let's tweak the examples to avoid confusion and
mistakes.

The new vnc_home_t type for HOME/.vnc directory was added to the policy,
backed by a name transition. The vnc_session_t domain can manage files
and directories of this type.

The permissions set to manage directories and files with the nfs_t type
is allowed when the use_nfs_home_dirs boolean is turned on.

Resolves: https://github.com/TigerVNC/tigervnc/issues/1189

Sections and rules blocks reordered according to the Style guide.

https://github.com/TresysTechnology/refpolicy/wiki/StyleGuide

Style guide [1] issues only. No impact on policy functionality.

[1] - https://github.com/TresysTechnology/refpolicy/wiki/StyleGuide

Build flags control where this file ends up, so avoid assuming a
specific path in the HOWTO.

The line width was very inconsitent in this file, so standardise on the
common 72 characters.

The old method used a very slow frame rate with small steps,
which made it obnoxious during use.  The new method has a few
improvements:

- Calculates "edge" region width automatically, as a ratio of
  the viewport size.  Default is 1/16th.

- Uses a different edge width for x and y, which works better
  on very wide or very tall screens.

- Increased default frame rate from 10 fps to 60 fps.

- Replaced hardcoded frame rate with a #define.

- Reduced maximum movement per frame slightly, because the
  frame rate is so much faster.  The overall result is still much
  faster, but also easier to do small adjustments with.

- Fixed off-by-one error in scroll rate calculation formula.  Left/up
  scrolls were faster than down/right, but this is fixed.

This makes it more comfortable to use TigerVNC on a small screen
to work on a larger screen for hours at a time.

Incorrect format strings can cause crashes, so we want to catch those
early.

Trying to dynamically track the DPI did not really work as we'd
start accumulating errors and eventually the DPI would start to
drift. Instead maintain a fixed, sensible DPI at all times.

Thanks @Raulkumar for finding this in #1118

This change makes it possible for re-synchronizing the remote cursor on
the vncviewer when in fullscreen mode. This is done by locally moving
the cursor position to what the server thinks it should be.

Now SDL games should work!

stderr has been redirected to /dev/null so all logging needs to go to
syslog.

This change adds support for the VMware Mouse Position
pseudo-encoding[1], which is used to notify VNC clients when X11 clients
call `XWarpPointer()`[2]. This function is called by SDL (and other
similar libraries)  when they detect that the server does not support
native relative motion, like some RFB clients.

With this, RFB clients can choose to adjust the local cursor position
under certain circumstances to match what the server has set. For
instance, if pointer lock has been enabled on the client's machine and
the cursor is not being drawn locally, the local position of the cursor
is irrelevant, so the RFB client can use what the server sends as the
canonical absolute position of the cursor. This ultimately enables the
possibility of games (especially FPS games) to behave how users expect
(if the clients implement the corresponding change).

Part of: #619

1: https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#vmware-cursor-position-pseudo-encoding
2: https://tronche.com/gui/x/xlib/input/XWarpPointer.html
3: https://hg.libsdl.org/SDL/file/28e3b60e2131/src/events/SDL_mouse.c#l804

Or rpmbuild gets grumpy.

This reverts commit d6e39658ae. Apparently
this is broken on macOS so it's not something we can make use of.

Some of these were incorrectly calculated so the server or client would
wait too long before proceeding with decoding.

Change all of these to be a more explicit calculation to avoid such
issues in the future.

TCP_CORK is a Linux thing and BSD has TCP_NOPUSH instead.

We didn't include the proper headers to get the correct define, so
corking was never enabled.

Otherwise we might end up owners of something we cannot deliver data on,
which can hang applications.