소스 검색

Fix NPE check in BindingValidationStatus (#10964)

tags/8.5.0.alpha2
Olli Tietäväinen 6 년 전
부모
커밋
8a756b89c2

+ 1
- 1
server/src/main/java/com/vaadin/data/BinderValidationStatus.java 파일 보기

@@ -90,7 +90,7 @@ public class BinderValidationStatus<BEAN> implements Serializable {
public BinderValidationStatus(Binder<BEAN> source,
List<BindingValidationStatus<?>> bindingStatuses,
List<ValidationResult> binderStatuses) {
Objects.requireNonNull(binderStatuses,
Objects.requireNonNull(bindingStatuses,
"binding statuses cannot be null");
Objects.requireNonNull(binderStatuses,
"binder statuses cannot be null");

+ 13
- 0
server/src/test/java/com/vaadin/data/BinderValidationStatusTest.java 파일 보기

@@ -8,9 +8,11 @@ import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.atomic.AtomicReference;

import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;

@@ -485,4 +487,15 @@ public class BinderValidationStatusTest
assertEquals(1, results.size());
assertFalse(results.get(0).isError());
}

@Test
public void binderValidationStatus_nullBindingStatuses() {
try {
new BinderValidationStatus<>(new Binder<Person>(), null,
new ArrayList<>());
Assert.fail("Binder should throw an NPE");
} catch (NullPointerException npe) {
assertNotNull(npe.getMessage());
}
}
}

Loading…
취소
저장