Add a simple waitForApplication for servlet integration tests
This waitForApplication checks if an UI element exists on the page. If
not, then it will wait 10 seconds in order for it to appear. This should
reduce the amount of false negatives in server tests.
Change-Id: I37a398e60c247920fd56fc05b747e0f93f3f2dd2
Use simple date format for BasicCrudGridEditorRow test UI
This patch also forces locales to US for all the date formats to avoid
issues on different default locales.
Change-Id: I7445f4ff1a25d83ab9dbb0633caefcea56d50acc
Fix ScrollbarBundle to not round down pixel values (#19421)
Since Escalator now uses subpixels in most cases, scrollbar calculation
fails when ScrollbarBundle calls Math.floor for the offset size. Removed
rounding, added a pixel epsilon check that we don't make a scrollbar
when it's not really needed.
Change-Id: I228fd7dd48d4506e5b2b7bb799291c9a122ea3fe
Added the custom attributes href and target to the Link component to
match the attribute names used by Link.readDesign() and
Link.writeDesign()
Change-Id: I7f257fcf89cb78d14d9632aa1be548e92f3010c3
Revert changes which were previously reverted from only 7.5 (#19424)
Revert "Take Window special case into account for invalid layouts (#17598)"
This reverts commit abc1c5dff6.
Revert "Render nested invalid layouts correctly (#17598)"
This reverts commit ac4e85f4e3.
Added test to ensure a similar problem is not reintroduced later
Change-Id: I892896e953637d793d0c0a788f28f3b61494d441
Fix WidgetRenderer column cells not correctly init on change (#19086)
When changing to a widget renderer with an existing column, the widget
renderer expects that the cells would be initialized to have a correct
widget for it. Because of original design where you could not change
renderers, this was not taken into account and cells did not get
reinitialized when changing the renderer.
This patch showed another underlying detach problem from removing a
widget renderer and destroying complex renderers. These both are also
addressed to make this bug possible to test correctly.
Patch includes a client-side test that verifies the integrity of the
renderer state in different stages of its lifecycle.
Change-Id: I67330e5d07c95047cb69040e8355a17dc8a96f08
Long tap causes problems in embedded browsers on iOS (text
selection is performed and/or the OS native context menu is shown).
The support should be re-enabled in the future (see #19406).
Change-Id: I842df12675482c8e529e8bb061958414cc8c0b90
Fix left padding for ComboBox inside Grid editor (#16838)
This fix applies especially to the themes Base, Chameleon and Runo.
Reindeer and Valo were already covered by earlier changes.
Filed #19407 for fixing incorrect positioning of DateField button in
Base theme.
Change-Id: Iefda0d23b93c74274ad83c60907c0198e5c2f237
Atmosphere will disconnect the push connection when going offline and reconnect it
when going online again. There are no events sent when this happens, which means the
reconnect logic cannot take this into account.
Having it enabled leads to something like:
1. Browser goes offline, push is disconnected
2. Framework sees it as a normal close and does not show the reconnect dialog
3. The user does something, the framework tries to send a websocket request
4. A new Atmosphere request is created and enters a try-to-reconnect loop as expected
5. The browser goes online, and the online event re-initializes the old connection
although a try-to-reconnect loop is already running
Change-Id: I5dcef768783142e2c7b4e7c821353addb0ec3d28
Fix Grid column resize to take account min width for cells (#16597)
Use Escalator cell size calculation without content to determine the
absolute minimum size for cells. This is used in Grid when drag resizing
or sorting columns to prevent cells from overflowing to the next row.
Change-Id: I2d598232d7d2b8729b11fe190b68ca3e42ee3652
Teemu Suo-Anttila
Leif Åstrand
Andreas Höhmann
Henri Sara
Johannes Dahlström
Artur Signell
John Ahlroos
maxschuster
Marlon Richert