Fix improper merge of 3d0ff32b from 7.1 to master (#13620)
Correctly call PushConnection.disconnect instead of setting to null.
Also remove the obsolete PushHandler.disconnectCallback.
Change-Id: Ied055d489a269b016318947cd89cf0b46003c596
Ignore irrelevant header lines in checkstyle configuration
* Ignores the empty lines that may have trailing white-space in the
license header. This allows formatting of the license header either
with or without trailing white-space, which differs between different
versions of Eclipse (as well as between IDEs).
Change-Id: If97d2cfe169accd6d05e44521c9ca5265d715772
- Add a couple of parameters in order make jetty context
reload whenever a class is modified.
- Remove deprecated SSL API calls.
Change-Id: I737fb92e78ce5573a4473639f25fcdad606f3c55
This makes it impossible to run this script by mistake, as it should
no longer be used with the new master based workflow.
Change-Id: I0400ecb20bb135c09e0414196f692dd8e9ffa510
Modified vaadinBootstrap to send v-loc as POST instead of GET (#13685).
Since there seems to be no difference, moved also almost all other
parameters from GET to POST for consistency.
Change-Id: I528963c4c832339a9853fbee97cebcb8fabb35e1
Prevent scroll position reset on GridLayout hierarchy change (#13386)
State change handling by default clears measured size if the size is set
to undefined; this would cause GridLayout to shrink to zero size because
its child cells have position: absolute. The layout phase recomputes the
size, but in some cases the browser reflows first, affecting the scroll
position of the layout parent. This patch prevents GridLayout from
clearing once-computed sizes during state change.
Change-Id: Id6e066c3ea360083d16d3fcc5c6d7d4bb6cea8b7
Fix TextArea with enter keyboard shortcut (#12424)
When a keyboardshortcut has been added to anywhere on the page,
the previous behaviour would cause the keyboardshortcut event to
be processeed before the newline was processed. The end result
was that newlines were never added when typing in the TextArea.
Keyboard shortcuts operate on KeyDown events. By adding a listener
for these events and stopping their propagation when the ENTER key
is pressed, this unwanted behaviour can be averted, and the user
can enter multi-line text in a TextArea even when Enter is used as
a keyboard shortcut.
Obviously, this means that the keyboard shortcut will not work as
long as the TextArea widget has focus. This is the new intended
behaviour.
Change-Id: Ied438acb8589df498e5634271e486517bf6ac41e
9c29442 Replace SelectionRangeDragging TB2 test with TB3 test
9fa230d Avoid eagerly layouting from VScrollTable.updateFromUIDL (#13188)
Change-Id: I4f1395a13e8b1eae44a0030a3679475a3db9160a
0d4080b ContainerEventProvider returns style names from container. Fixes #107186e91bdf Add test for TransactionalPropertyWrapper memory leaks
f0aaf89 Fixed resetting of ComboBox if focused and new items allowed (#13413).
e033fcd Always initialize WebBrowser for new sessions (#13571)
168de1f Revert "Drag image for text-area should contain text of text-area (#13557)"
35e2a34 Fix FieldGroup and TransactionalPropertyWrapper memory leaks (#13438)
7e5d44d Introduce a drag threshold for Drag and Drop (#13381)
f227f0c Drag image for text-area should contain text of text-area (#13557).
Change-Id: Idb01471f8ab0c7118fa884c364e6bc200d13948a
Fix findUI throwing NullPointerException when extending Vaadin (#13556)
findUI sometimes threw a NPE when the session wasn't set but the UI ID
was. Doesn't occur in normal use, just when doing custom things with
requestStart/requestEnd or runPendingAccessTasks
Change-Id: Id7733567923fa30dcab4946c43b73200c2a0fac2
Add caching support for PublishedFileHandler (#13574)
Add caching support for PublishedFileHandler similar to VaadinServlet.
Testing is done manually as browser caching is difficult to develop
tests for.
Change-Id: I314745766c9feb60758547dba77eb9e13976ce91
Clean Table.propertyValueConverters if the property is removed (#8168)
Clean Table.propertyValueConverters if the property it attached to
is removed, or if the container is changed and the new container does
not contain a property with that identifier with a matching type.
Change-Id: I894ee6462ea7b9c1f9138a24fcb84db829165c7d
Avoid eagerly layouting from VScrollTable.updateFromUIDL (#13188)
Closing a modal sub-window at the same time when TreeTable item is
removed, caused the detached Window being re-opened by
WindowConnector.postLayout() call.
This change adds a check in postLayout: continue operation only if the
window is attached to DOM. Or else, log a warning message about the
invalid postLayout call. Another change is in TreeTableConnector and
VScrollTable to disallow Util.notifyParentOfSizeChange(Widget, boolean)
with a boolean 'false' argument, when rendering is in progress. 'false'
causes an immediate LayoutManager.layoutNow() call, which is the main
reason for this issue.
Change-Id: I6f3e331b0feff9e7814ae1d749f6f7812dcd49ac
Clarify lock check assert message if another session is locked (#13473)
Picking this to the 7.2 branch since the other part of the ticket was already included in 7.2.
Change-Id: I1120ad5acd553e22db95e3635fffbd453fd26310
(cherry picked from commit 134c3bb96b)
Artur Signell
Johannes Dahlström
Jonatan Kronqvist
Sauli Tähkäpää
Teemu Suo-Anttila
John Ahlroos
Manolo Carrasco
Dmitrii Rogozin
Teemu Pöntelin
Denis Anisimov
Tapio Aali
Juuso Valli
mtzukanov
Markus Koivisto
Markus Koivisto
Tomi Virtanen
Leif Åstrand