Revert "Displaying tooltip in slot for touch devices (#15353)" (#17151)
Should not have been merged since there were still stuff pending ("This
patchset doesn't include styling for the error message") that was not
addressed before submitting.
This reverts commit 05fc5806e7.
Change-Id: Idd723f22f42e2e8ee71059b9591d44fafadea27e
Fix invalid assumptions about empty Grid (#16734, #16684)
* Don't reset to default column sizes when adding row to emtpy escalator
* Don't wait for data after size is explicilty reset to 0
* Don't assume there were previous rows when adjusting focus on add
Change-Id: I59e8c0ef0c5633cf3678db63a660e3f1d1ca7d2a
This change removes the method LayoutDependenyTree.setNeedsMeasure which
takes a connectorId as first param.
In all places where it is used, the ComponentConnector is actually known,
so this change avoids looking it up over and over again.
Also The lookup would need to lookup the ConnectorMap every time.
Change-Id: I2593b0bede05cd69889ba68aac854cfba43f70b1
LayoutManager uses shortcut when delaying overflow fixes (#16963).
This change introduces an extracted method which will quick return if
a component needs a delayedOverflowFix.
Change-Id: I0d6ab100964a59e2f445a81271863a8212538d4d
Improve performance of getMeasureTargetsJsArray (#16973).
This change optimizes the method
LayoutDependenyTree.getMeasureTargetsJsArray.
The previous code dumps both MeasureQueues and then iterates over the
vertical one and then checks if it is present in the horizontal one.
If it is not present it pushes the element to the array (which usually
invokes an arraycopy in js).
The new code adds both Queues to a new FastStringSet which does deal
with duplicates nicely.
While this is not much faster than the dumps, it avoids the array
allocations and the separate iteration for duplicate checking.
Change-Id: I2f643a2d0b32e4c2517efff16c196387f38f0d8a
Chrome has started auto-updating even though auto updates are
disabled on the test machines. TestBench 2 works with Chrome 41 (latest)
but opens the test in a new tab instead of in a new window and therefore
is unable to resize the browser to the correct size for screenshots.
Change-Id: Ib7f05a9115a9c82f5b3b384d73c47d6becbfbe79
Ensure refresh message is sent on invalid CSRF (#17042)
If we create an AtmospherePushConnection and a broadcaster like before we would
need to suspend the connection to ensure the AtmosphereResource is actually
added to the broadcaster
Change-Id: I7265ac0594b7a4da2c7a49fa34ebfbb27e1abdff
Fixes subpixel allocation accuracy and speed (#16614, #16750)
This reverts workarounds used in subpixel quick fix commit
6133b2cffd. New logic uses Escalator's
more optimised multiple column width setting method.
Change-Id: I0863f9774e6efc26f01ebdb736b4847e4ef5354c
Fix text input of PopupCalendar in Internet Explorer (#16677).
Similarly to VTextField, VTextualDate now uses KeyDownHandler with IE to
process the pressing of the return key.
Change-Id: I139134fc38678ad46f0c46f30e3de25547b9a3c6
Revert "Hide button caption overflow in reindeer and valo. (#11864)"
This reverts commit c9586c93b9.
This fix will break button focus outline in Valo. The overflow hidden needs to be placed on the inner element (v-button-wrap).
For Reindeer the fix is okay, but for consistency it might make sense to move it there to the inner element also.
Change-Id: I6cac9fc6a1c8ae6be9969b8dc8533b9cad118d6a
Improve performance of Util.collectionEquals (#16968).
This change checks the length of both collections first before iterating
them. This massively speeds up the comparison in case the collections do
not have the same length.
Also in the case where the lengths are equal, this saves the
collection2.hasNext() checks.
Change-Id: If1325f3581d12bf742d77fbf8b0f89511fa11252
LayoutManager reuses shortcut Element instance for measure (#16964).
This change prevents the duplicate getter chain lookup
connector.getWidget().getElement() on the very hot measureConnector
method.
Change-Id: Ia59c9ef2e6bbcf9402424bc565bc9ee3977e3c6e
Leif Åstrand
Artur Signell
Teemu Suo-Anttila
Sauli Tähkäpää
Henrik Paul
Fabian Lange
Alexey Fansky
Miki
Pekka Hyvönen
Mika Murtojarvi
Jouni Koivuviita