diff options
| author | Morris Jobke <hey@morrisjobke.de> | 2017-12-14 09:50:17 +0100 |
|---|---|---|
| committer | Morris Jobke <hey@morrisjobke.de> | 2017-12-14 09:56:53 +0100 |
| commit | 54c227b6c4cf7c4597a45aa255be93cd4c14d1ec (patch) | |
| tree | 736e7ac8079696701d05df00a1708e21c530118b | |
| parent | ce12763ab7e29d8b41ef1b0594923f7911decea9 (diff) | |
| download | nextcloud-server-54c227b6c4cf7c4597a45aa255be93cd4c14d1ec.tar.gz nextcloud-server-54c227b6c4cf7c4597a45aa255be93cd4c14d1ec.zip | |
Use cached app list
Followup to #7264
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
| -rw-r--r-- | lib/private/Installer.php | 4 | ||||
| -rw-r--r-- | tests/lib/InstallerTest.php | 1 |
2 files changed, 3 insertions, 2 deletions
diff --git a/lib/private/Installer.php b/lib/private/Installer.php index 48bd57f4c10..eb1f8a456bf 100644 --- a/lib/private/Installer.php +++ b/lib/private/Installer.php @@ -396,10 +396,10 @@ class Installer { } if ($this->apps === null) { - $apps = $this->appFetcher->get(); + $this->apps = $this->appFetcher->get(); } - foreach($apps as $app) { + foreach($this->apps as $app) { if($app['id'] === $appId) { $currentVersion = OC_App::getAppVersion($appId); $newestVersion = $app['releases'][0]['version']; diff --git a/tests/lib/InstallerTest.php b/tests/lib/InstallerTest.php index 897bc472103..c7e4bfeacfb 100644 --- a/tests/lib/InstallerTest.php +++ b/tests/lib/InstallerTest.php @@ -156,6 +156,7 @@ class InstallerTest extends TestCase { $installer = $this->getInstaller(); $this->assertSame($updateAvailable, $installer->isUpdateAvailable('files')); + $this->assertSame($updateAvailable, $installer->isUpdateAvailable('files'), 'Cached result should be returned and fetcher should be only called once'); } /** |