aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJonas Meurer <jonas@freesources.org>2021-10-19 10:56:07 +0200
committerJonas Meurer <jonas@freesources.org>2021-10-20 11:33:37 +0200
commit65cfe9df4650fbc877d2104a7f3c21e002e87b5d (patch)
tree4462f8958dfa341d24ac3164e80aa1588583b5b7
parent3fe267b77279a44dcd9f4ccf75cd2f7ac8321c7b (diff)
downloadnextcloud-server-65cfe9df4650fbc877d2104a7f3c21e002e87b5d.tar.gz
nextcloud-server-65cfe9df4650fbc877d2104a7f3c21e002e87b5d.zip
Add integration tests for user_status API
Signed-off-by: Jonas Meurer <jonas@freesources.org>
-rw-r--r--build/integration/collaboration_features/user_status.feature20
-rw-r--r--build/integration/features/bootstrap/CollaborationContext.php91
-rw-r--r--build/integration/features/bootstrap/Provisioning.php1
3 files changed, 112 insertions, 0 deletions
diff --git a/build/integration/collaboration_features/user_status.feature b/build/integration/collaboration_features/user_status.feature
new file mode 100644
index 00000000000..759d6e31795
--- /dev/null
+++ b/build/integration/collaboration_features/user_status.feature
@@ -0,0 +1,20 @@
+Feature: user_status
+ Background:
+ Given using api version "2"
+ And user "user0" exists
+ And user "user0" has status "dnd"
+
+ Scenario: listing recent user statuses with default settings
+ Then user statuses for "admin" list "user0" with status "dnd"
+
+ Scenario: empty recent user statuses with disabled/limited user enumeration
+ When parameter "shareapi_allow_share_dialog_user_enumeration" of app "core" is set to "no"
+ Then user statuses for "admin" are empty
+ When parameter "shareapi_allow_share_dialog_user_enumeration" of app "core" is set to "yes"
+ When parameter "shareapi_restrict_user_enumeration_to_group" of app "core" is set to "yes"
+ Then user statuses for "admin" are empty
+ When parameter "shareapi_restrict_user_enumeration_to_group" of app "core" is set to "no"
+ When parameter "shareapi_restrict_user_enumeration_to_phone" of app "core" is set to "yes"
+ Then user statuses for "admin" are empty
+ When parameter "shareapi_restrict_user_enumeration_to_phone" of app "core" is set to "no"
+ Then user statuses for "admin" list "user0" with status "dnd"
diff --git a/build/integration/features/bootstrap/CollaborationContext.php b/build/integration/features/bootstrap/CollaborationContext.php
index 17eb820c77d..4ac3b6e3971 100644
--- a/build/integration/features/bootstrap/CollaborationContext.php
+++ b/build/integration/features/bootstrap/CollaborationContext.php
@@ -25,6 +25,7 @@ declare(strict_types=1);
*/
use Behat\Behat\Context\Context;
use Behat\Gherkin\Node\TableNode;
+use GuzzleHttp\Client;
use PHPUnit\Framework\Assert;
require __DIR__ . '/../../vendor/autoload.php';
@@ -70,4 +71,94 @@ class CollaborationContext implements Context {
$this->deleteServerConfig('core', 'shareapi_restrict_user_enumeration_full_match');
$this->deleteServerConfig('core', 'shareapi_only_share_with_group_members');
}
+
+ /**
+ * @Given /^user "([^"]*)" has status "([^"]*)"$/
+ * @param string $user
+ * @param string $status
+ */
+ public function assureUserHasStatus($user, $status) {
+ $fullUrl = $this->baseUrl . "v{$this->apiVersion}.php/apps/user_status/api/v1/user_status/status";
+ $client = new Client();
+ $options = [
+ 'headers' => [
+ 'OCS-APIREQUEST' => 'true',
+ ],
+ ];
+ if ($user === 'admin') {
+ $options['auth'] = $this->adminUser;
+ } else {
+ $options['auth'] = [$user, $this->regularUser];
+ }
+
+ $options['form_params'] = [
+ 'statusType' => $status
+ ];
+
+ $this->response = $client->put($fullUrl, $options);
+ $this->theHTTPStatusCodeShouldBe(200);
+
+ $fullUrl = $this->baseUrl . "v{$this->apiVersion}.php/apps/user_status/api/v1/user_status";
+ unset($options['form_params']);
+ $this->response = $client->get($fullUrl, $options);
+ $this->theHTTPStatusCodeShouldBe(200);
+
+ $returnedStatus = json_decode(json_encode(simplexml_load_string($this->response->getBody()->getContents())->data), true)['status'];
+ Assert::assertEquals($status, $returnedStatus);
+ }
+
+ /**
+ * @param string $user
+ * @return null|array
+ */
+ public function getStatusList(string $user): ?array {
+ $fullUrl = $this->baseUrl . "v{$this->apiVersion}.php/apps/user_status/api/v1/statuses";
+ $client = new Client();
+ $options = [
+ 'headers' => [
+ 'OCS-APIREQUEST' => 'true',
+ ],
+ ];
+ if ($user === 'admin') {
+ $options['auth'] = $this->adminUser;
+ } else {
+ $options['auth'] = [$user, $this->regularUser];
+ }
+
+ $this->response = $client->get($fullUrl, $options);
+ $this->theHTTPStatusCodeShouldBe(200);
+
+ $contents = $this->response->getBody()->getContents();
+ return json_decode(json_encode(simplexml_load_string($contents)->data), true);
+ }
+
+ /**
+ * @Given /^user statuses for "([^"]*)" list "([^"]*)" with status "([^"]*)"$/
+ * @param string $user
+ * @param string $statusUser
+ * @param string $status
+ */
+ public function assertStatusesList(string $user, string $statusUser, string $status): void {
+ $statusList = $this->getStatusList($user);
+ Assert::assertArrayHasKey('element', $statusList, 'Returned status list empty or broken');
+ if (array_key_exists('userId', $statusList['element'])) {
+ // If only one user has a status set, the API returns their status directly
+ Assert::assertArrayHasKey('status', $statusList['element'], 'Returned status list empty or broken');
+ $filteredStatusList = [ $statusList['element']['userId'] => $statusList['element']['status'] ];
+ } else {
+ // If more than one user have their status set, the API returns an array of their statuses
+ $filteredStatusList = array_column($statusList['element'], 'status', 'userId');
+ }
+ Assert::assertArrayHasKey($statusUser, $filteredStatusList, 'User not listed in statuses: ' . $statusUser);
+ Assert::assertEquals($status, $filteredStatusList[$statusUser]);
+ }
+
+ /**
+ * @Given /^user statuses for "([^"]*)" are empty$/
+ * @param string $user
+ */
+ public function assertStatusesEmpty(string $user): void {
+ $statusList = $this->getStatusList($user);
+ Assert::assertEmpty($statusList);
+ }
}
diff --git a/build/integration/features/bootstrap/Provisioning.php b/build/integration/features/bootstrap/Provisioning.php
index e51339c081e..1b01a636918 100644
--- a/build/integration/features/bootstrap/Provisioning.php
+++ b/build/integration/features/bootstrap/Provisioning.php
@@ -13,6 +13,7 @@
* @author Sergio Bertolín <sbertolin@solidgear.es>
* @author Thomas Müller <thomas.mueller@tmit.eu>
* @author Vincent Petry <vincent@nextcloud.com>
+ * @author Jonas Meurer <jonas@freesources.org>
*
* @license GNU AGPL version 3 or any later version
*