diff options
author | Arthur Schiwon <blizzz@arthur-schiwon.de> | 2020-02-13 22:03:44 +0100 |
---|---|---|
committer | Arthur Schiwon <blizzz@arthur-schiwon.de> | 2020-02-13 22:03:44 +0100 |
commit | b1a6f66fd9676e9d7c9ceed5a10d07806790ae02 (patch) | |
tree | 8fc4033b149bf128ef82d07d8d447c8c8aa092cc | |
parent | 869277b005027e8d1e13ae1a5e48923fa278da6f (diff) | |
download | nextcloud-server-b1a6f66fd9676e9d7c9ceed5a10d07806790ae02.tar.gz nextcloud-server-b1a6f66fd9676e9d7c9ceed5a10d07806790ae02.zip |
when we receive intentional empty whats new info, do not try to show it
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
-rw-r--r-- | lib/private/Updater/ChangesCheck.php | 6 | ||||
-rw-r--r-- | tests/lib/Updater/ChangesCheckTest.php | 4 |
2 files changed, 9 insertions, 1 deletions
diff --git a/lib/private/Updater/ChangesCheck.php b/lib/private/Updater/ChangesCheck.php index f1f44cc59c8..7346ceab6b1 100644 --- a/lib/private/Updater/ChangesCheck.php +++ b/lib/private/Updater/ChangesCheck.php @@ -55,7 +55,11 @@ class ChangesCheck { public function getChangesForVersion(string $version): array { $version = $this->normalizeVersion($version); $changesInfo = $this->mapper->getChanges($version); - return json_decode($changesInfo->getData(), true); + $changesData = json_decode($changesInfo->getData(), true); + if(empty($changesData)) { + throw new DoesNotExistException(); + } + return $changesData; } /** diff --git a/tests/lib/Updater/ChangesCheckTest.php b/tests/lib/Updater/ChangesCheckTest.php index a979007573d..30cb9df2956 100644 --- a/tests/lib/Updater/ChangesCheckTest.php +++ b/tests/lib/Updater/ChangesCheckTest.php @@ -279,6 +279,10 @@ class ChangesCheckTest extends TestCase { ], ] ], + [ # 4 - empty + '', + [] + ], ]; } |