aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobin Appelman <icewind@owncloud.com>2015-12-09 14:13:05 +0100
committerRobin Appelman <icewind@owncloud.com>2015-12-09 14:53:24 +0100
commite191953942fe6b32917c5e01f27879db87e369ce (patch)
treefd7afb26e4222b01a7e1f3e0a648105d7ab71015
parent5c95939bf388111a21ca94461e37b1b0b0b38159 (diff)
downloadnextcloud-server-e191953942fe6b32917c5e01f27879db87e369ce.tar.gz
nextcloud-server-e191953942fe6b32917c5e01f27879db87e369ce.zip
Remove all locks after ttl from the db
-rw-r--r--lib/private/lock/dblockingprovider.php6
-rw-r--r--tests/lib/lock/dblockingprovider.php8
2 files changed, 4 insertions, 10 deletions
diff --git a/lib/private/lock/dblockingprovider.php b/lib/private/lock/dblockingprovider.php
index 90657e6725f..8d6ab52737c 100644
--- a/lib/private/lock/dblockingprovider.php
+++ b/lib/private/lock/dblockingprovider.php
@@ -235,10 +235,10 @@ class DBLockingProvider extends AbstractLockingProvider {
/**
* cleanup empty locks
*/
- public function cleanEmptyLocks() {
+ public function cleanExpiredLocks() {
$expire = $this->timeFactory->getTime();
$this->connection->executeUpdate(
- 'DELETE FROM `*PREFIX*file_locks` WHERE `lock` = 0 AND `ttl` < ?',
+ 'DELETE FROM `*PREFIX*file_locks` WHERE `ttl` < ?',
[$expire]
);
}
@@ -262,7 +262,7 @@ class DBLockingProvider extends AbstractLockingProvider {
public function __destruct() {
try {
- $this->cleanEmptyLocks();
+ $this->cleanExpiredLocks();
} catch (\Exception $e) {
// If the table is missing, the clean up was successful
if ($this->connection->tableExists('file_locks')) {
diff --git a/tests/lib/lock/dblockingprovider.php b/tests/lib/lock/dblockingprovider.php
index d679b1ea677..2032110f4f0 100644
--- a/tests/lib/lock/dblockingprovider.php
+++ b/tests/lib/lock/dblockingprovider.php
@@ -85,13 +85,7 @@ class DBLockingProvider extends LockingProvider {
$this->assertEquals(3, $this->getLockEntryCount());
- $this->instance->cleanEmptyLocks();
-
- $this->assertEquals(3, $this->getLockEntryCount());
-
- $this->instance->releaseAll();
-
- $this->instance->cleanEmptyLocks();
+ $this->instance->cleanExpiredLocks();
$this->assertEquals(2, $this->getLockEntryCount());
}