fix(caldav): event links in shared calendar notifications

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

2 files changed, 24 insertions, 16 deletions

diff --git a/apps/dav/lib/CalDAV/Activity/Provider/Event.php b/apps/dav/lib/CalDAV/Activity/Provider/Event.php
index 13f0036b0b0..a24ea791e74 100644
--- a/apps/dav/lib/CalDAV/Activity/Provider/Event.php
+++ b/apps/dav/lib/CalDAV/Activity/Provider/Event.php
@@ -81,7 +81,7 @@ class Event extends Base {
 	 * @param array $eventData
 	 * @return array
 	 */
-	protected function generateObjectParameter(array $eventData) {
+	protected function generateObjectParameter(array $eventData, string $affectedUser): array {
 		if (!isset($eventData['id']) || !isset($eventData['name'])) {
 			throw new \InvalidArgumentException();
 		}
@@ -97,7 +97,15 @@ class Event extends Base {
 				// The calendar app needs to be manually loaded for the routes to be loaded
 				OC_App::loadApp('calendar');
 				$linkData = $eventData['link'];
-				$objectId = base64_encode($this->url->getWebroot() . '/remote.php/dav/calendars/' . $linkData['owner'] . '/' . $linkData['calendar_uri'] . '/' . $linkData['object_uri']);
+				if ($affectedUser === $linkData['owner']) {
+					$objectId = base64_encode($this->url->getWebroot() . '/remote.php/dav/calendars/' . $linkData['owner'] . '/' . $linkData['calendar_uri'] . '/' . $linkData['object_uri']);
+				} else {
+					// Can't use the "real" owner and calendar names here because we create a custom
+					// calendar for incoming shares with the name "<calendar>_shared_by_<sharer>".
+					// Hack: Fix the link by generating it for the incoming shared calendar instead,
+					//       as seen from the affected user.
+					$objectId = base64_encode($this->url->getWebroot() . '/remote.php/dav/calendars/' . $affectedUser . '/' . $linkData['calendar_uri'] . '_shared_by_' . $linkData['owner'] . '/' . $linkData['object_uri']);
+				}
 				$link = [
 					'view' => 'dayGridMonth',
 					'timeRange' => 'now',
@@ -189,7 +197,7 @@ class Event extends Base {
 					return [
 						'actor' => $this->generateUserParameter($parameters['actor']),
 						'calendar' => $this->generateCalendarParameter($parameters['calendar'], $this->l),
-						'event' => $this->generateClassifiedObjectParameter($parameters['object']),
+						'event' => $this->generateClassifiedObjectParameter($parameters['object'], $event->getAffectedUser()),
 					];
 				case self::SUBJECT_OBJECT_ADD . '_event_self':
 				case self::SUBJECT_OBJECT_DELETE . '_event_self':
@@ -198,7 +206,7 @@ class Event extends Base {
 				case self::SUBJECT_OBJECT_RESTORE . '_event_self':
 					return [
 						'calendar' => $this->generateCalendarParameter($parameters['calendar'], $this->l),
-						'event' => $this->generateClassifiedObjectParameter($parameters['object']),
+						'event' => $this->generateClassifiedObjectParameter($parameters['object'], $event->getAffectedUser()),
 					];
 			}
 		}
@@ -210,13 +218,13 @@ class Event extends Base {
 						'actor' => $this->generateUserParameter($parameters['actor']),
 						'sourceCalendar' => $this->generateCalendarParameter($parameters['sourceCalendar'], $this->l),
 						'targetCalendar' => $this->generateCalendarParameter($parameters['targetCalendar'], $this->l),
-						'event' => $this->generateClassifiedObjectParameter($parameters['object']),
+						'event' => $this->generateClassifiedObjectParameter($parameters['object'], $event->getAffectedUser()),
 					];
 				case self::SUBJECT_OBJECT_MOVE . '_event_self':
 					return [
 						'sourceCalendar' => $this->generateCalendarParameter($parameters['sourceCalendar'], $this->l),
 						'targetCalendar' => $this->generateCalendarParameter($parameters['targetCalendar'], $this->l),
-						'event' => $this->generateClassifiedObjectParameter($parameters['object']),
+						'event' => $this->generateClassifiedObjectParameter($parameters['object'], $event->getAffectedUser()),
 					];
 			}
 		}
@@ -233,22 +241,22 @@ class Event extends Base {
 				return [
 					'actor' => $this->generateUserParameter($parameters[0]),
 					'calendar' => $this->generateLegacyCalendarParameter($event->getObjectId(), $parameters[1]),
-					'event' => $this->generateObjectParameter($parameters[2]),
+					'event' => $this->generateObjectParameter($parameters[2], $event->getAffectedUser()),
 				];
 			case self::SUBJECT_OBJECT_ADD . '_event_self':
 			case self::SUBJECT_OBJECT_DELETE . '_event_self':
 			case self::SUBJECT_OBJECT_UPDATE . '_event_self':
 				return [
 					'calendar' => $this->generateLegacyCalendarParameter($event->getObjectId(), $parameters[1]),
-					'event' => $this->generateObjectParameter($parameters[2]),
+					'event' => $this->generateObjectParameter($parameters[2], $event->getAffectedUser()),
 				];
 		}
 
 		throw new \InvalidArgumentException();
 	}
 
-	private function generateClassifiedObjectParameter(array $eventData) {
-		$parameter = $this->generateObjectParameter($eventData);
+	private function generateClassifiedObjectParameter(array $eventData, string $affectedUser): array {
+		$parameter = $this->generateObjectParameter($eventData, $affectedUser);
 		if (!empty($eventData['classified'])) {
 			$parameter['name'] = $this->l->t('Busy');
 		}
diff --git a/apps/dav/lib/CalDAV/Activity/Provider/Todo.php b/apps/dav/lib/CalDAV/Activity/Provider/Todo.php
index e2ddb99a1af..e4518ff49c2 100644
--- a/apps/dav/lib/CalDAV/Activity/Provider/Todo.php
+++ b/apps/dav/lib/CalDAV/Activity/Provider/Todo.php
@@ -104,7 +104,7 @@ class Todo extends Event {
 					return [
 						'actor' => $this->generateUserParameter($parameters['actor']),
 						'calendar' => $this->generateCalendarParameter($parameters['calendar'], $this->l),
-						'todo' => $this->generateObjectParameter($parameters['object']),
+						'todo' => $this->generateObjectParameter($parameters['object'], $event->getAffectedUser()),
 					];
 				case self::SUBJECT_OBJECT_ADD . '_todo_self':
 				case self::SUBJECT_OBJECT_DELETE . '_todo_self':
@@ -113,7 +113,7 @@ class Todo extends Event {
 				case self::SUBJECT_OBJECT_UPDATE . '_todo_needs_action_self':
 					return [
 						'calendar' => $this->generateCalendarParameter($parameters['calendar'], $this->l),
-						'todo' => $this->generateObjectParameter($parameters['object']),
+						'todo' => $this->generateObjectParameter($parameters['object'], $event->getAffectedUser()),
 					];
 			}
 		}
@@ -125,13 +125,13 @@ class Todo extends Event {
 						'actor' => $this->generateUserParameter($parameters['actor']),
 						'sourceCalendar' => $this->generateCalendarParameter($parameters['sourceCalendar'], $this->l),
 						'targetCalendar' => $this->generateCalendarParameter($parameters['targetCalendar'], $this->l),
-						'todo' => $this->generateObjectParameter($parameters['object']),
+						'todo' => $this->generateObjectParameter($parameters['object'], $event->getAffectedUser()),
 					];
 				case self::SUBJECT_OBJECT_MOVE . '_todo_self':
 					return [
 						'sourceCalendar' => $this->generateCalendarParameter($parameters['sourceCalendar'], $this->l),
 						'targetCalendar' => $this->generateCalendarParameter($parameters['targetCalendar'], $this->l),
-						'todo' => $this->generateObjectParameter($parameters['object']),
+						'todo' => $this->generateObjectParameter($parameters['object'], $event->getAffectedUser()),
 					];
 			}
 		}
@@ -150,7 +150,7 @@ class Todo extends Event {
 				return [
 					'actor' => $this->generateUserParameter($parameters[0]),
 					'calendar' => $this->generateLegacyCalendarParameter($event->getObjectId(), $parameters[1]),
-					'todo' => $this->generateObjectParameter($parameters[2]),
+					'todo' => $this->generateObjectParameter($parameters[2], $event->getAffectedUser()),
 				];
 			case self::SUBJECT_OBJECT_ADD . '_todo_self':
 			case self::SUBJECT_OBJECT_DELETE . '_todo_self':
@@ -159,7 +159,7 @@ class Todo extends Event {
 			case self::SUBJECT_OBJECT_UPDATE . '_todo_needs_action_self':
 				return [
 					'calendar' => $this->generateLegacyCalendarParameter($event->getObjectId(), $parameters[1]),
-					'todo' => $this->generateObjectParameter($parameters[2]),
+					'todo' => $this->generateObjectParameter($parameters[2], $event->getAffectedUser()),
 				];
 		}