aboutsummaryrefslogtreecommitdiffstats
path: root/apps/files/tests
diff options
context:
space:
mode:
authorFerdinand Thiessen <opensource@fthiessen.de>2023-08-16 20:11:31 +0200
committerFerdinand Thiessen <opensource@fthiessen.de>2023-08-19 15:08:39 +0200
commitcb5c1725d17aafbaf5686d86052538a281c6f222 (patch)
tree8beb7d2d4e2185844b0309c0c575eed701e59ce8 /apps/files/tests
parentcb894ebede0360807bf801c19abca112779a6c80 (diff)
downloadnextcloud-server-cb5c1725d17aafbaf5686d86052538a281c6f222.tar.gz
nextcloud-server-cb5c1725d17aafbaf5686d86052538a281c6f222.zip
fix(files): Fix legacy files list sorting
The sorting was not saved since files2vue changes in Nextcloud 27, as a new API endpoint was introduced and the old one was dropped without adjusting the legacy file list to use it. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Diffstat (limited to 'apps/files/tests')
-rw-r--r--apps/files/tests/js/filelistSpec.js32
1 files changed, 17 insertions, 15 deletions
diff --git a/apps/files/tests/js/filelistSpec.js b/apps/files/tests/js/filelistSpec.js
index f2caa176973..b7f9fb2ff39 100644
--- a/apps/files/tests/js/filelistSpec.js
+++ b/apps/files/tests/js/filelistSpec.js
@@ -2561,10 +2561,11 @@ describe('OCA.Files.FileList tests', function() {
});
it('Toggles the sort indicator when clicking on a column header', function() {
- var ASC_CLASS = fileList.SORT_INDICATOR_ASC_CLASS;
- var DESC_CLASS = fileList.SORT_INDICATOR_DESC_CLASS;
+ const ASC_CLASS = fileList.SORT_INDICATOR_ASC_CLASS;
+ const DESC_CLASS = fileList.SORT_INDICATOR_DESC_CLASS;
var request;
- var sortingUrl = OC.generateUrl('/apps/files/api/v1/sorting');
+ const sortingDirectionUrl = OC.generateUrl('/apps/files/api/v1/views/files/sorting_direction');
+ const sortingModeUrl = OC.generateUrl('/apps/files/api/v1/views/files/sorting_mode');
fileList.$el.find('.column-size .columntitle').click();
// moves triangle to size column, check indicator on name is hidden
expect(
@@ -2578,9 +2579,9 @@ describe('OCA.Files.FileList tests', function() {
fileList.$el.find('.column-size .sort-indicator').hasClass(DESC_CLASS)
).toEqual(true);
// check if changes are persisted
- expect(fakeServer.requests.length).toEqual(1);
- request = fakeServer.requests[0];
- expect(request.url).toEqual(sortingUrl);
+ expect(fakeServer.requests.length).toEqual(2);
+ expect(fakeServer.requests.some((request) => request.url === sortingDirectionUrl)).toBe(true)
+ expect(fakeServer.requests.some((request) => request.url === sortingModeUrl)).toBe(true)
// click again on size column, reverses direction
fileList.$el.find('.column-size .columntitle').click();
@@ -2591,9 +2592,9 @@ describe('OCA.Files.FileList tests', function() {
fileList.$el.find('.column-size .sort-indicator').hasClass(ASC_CLASS)
).toEqual(true);
// check if changes are persisted
- expect(fakeServer.requests.length).toEqual(2);
- request = fakeServer.requests[1];
- expect(request.url).toEqual(sortingUrl);
+ expect(fakeServer.requests.length).toEqual(4);
+ expect(fakeServer.requests.slice(2).some((request) => request.url === sortingDirectionUrl)).toBe(true)
+ expect(fakeServer.requests.slice(2).some((request) => request.url === sortingModeUrl)).toBe(true)
// click again on size column, reverses direction
fileList.$el.find('.column-size .columntitle').click();
@@ -2603,9 +2604,9 @@ describe('OCA.Files.FileList tests', function() {
expect(
fileList.$el.find('.column-size .sort-indicator').hasClass(DESC_CLASS)
).toEqual(true);
- expect(fakeServer.requests.length).toEqual(3);
- request = fakeServer.requests[2];
- expect(request.url).toEqual(sortingUrl);
+ expect(fakeServer.requests.length).toEqual(6);
+ expect(fakeServer.requests.slice(4).some((request) => request.url === sortingDirectionUrl)).toBe(true)
+ expect(fakeServer.requests.slice(4).some((request) => request.url === sortingModeUrl)).toBe(true)
// click on mtime column, moves indicator there
fileList.$el.find('.column-mtime .columntitle').click();
@@ -2618,10 +2619,11 @@ describe('OCA.Files.FileList tests', function() {
expect(
fileList.$el.find('.column-mtime .sort-indicator').hasClass(DESC_CLASS)
).toEqual(true);
- expect(fakeServer.requests.length).toEqual(4);
- request = fakeServer.requests[3];
- expect(request.url).toEqual(sortingUrl);
+ expect(fakeServer.requests.length).toEqual(8);
+ expect(fakeServer.requests.slice(6).some((request) => request.url === sortingDirectionUrl)).toBe(true)
+ expect(fakeServer.requests.slice(6).some((request) => request.url === sortingModeUrl)).toBe(true)
});
+
it('Uses correct sort comparator when inserting files', function() {
testFiles.sort(OCA.Files.FileList.Comparators.size);
testFiles.reverse(); //default is descending