diff options
| author | Josh <josh.t.richards@gmail.com> | 2024-02-19 17:49:03 -0500 |
|---|---|---|
| committer | nextcloud-command <nextcloud-command@users.noreply.github.com> | 2024-02-19 22:59:20 +0000 |
| commit | aff8b5620c0b136afba8131762978917f90b6d02 (patch) | |
| tree | 03cf0a5c4d650eea620cce75d6c327a82d0d70c3 /apps/files | |
| parent | 1bc8129623d15b369a7b6bf7ac65931b0e83455e (diff) | |
| download | nextcloud-server-aff8b5620c0b136afba8131762978917f90b6d02.tar.gz nextcloud-server-aff8b5620c0b136afba8131762978917f90b6d02.zip | |
fix(files): Dont't warn re: full storage on either zero or unlimited quotas
Fixes #43535
Fixes #43280
Replaces #43544
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Diffstat (limited to 'apps/files')
| -rw-r--r-- | apps/files/src/components/NavigationQuota.vue | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/apps/files/src/components/NavigationQuota.vue b/apps/files/src/components/NavigationQuota.vue index 943d61cf0f5..8f96481232d 100644 --- a/apps/files/src/components/NavigationQuota.vue +++ b/apps/files/src/components/NavigationQuota.vue @@ -88,8 +88,17 @@ export default { }, mounted() { - // Warn the user if the available storage is 0 on page load - if (this.storageStats?.free <= 0) { + // If the user has a quota set, warn if the available account storage is <=0 + // + // NOTE: This doesn't catch situations where actual *server* + // disk (non-quota) space is low, but those should probably + // be handled differently anyway since a regular user can't + // can't do much about them (If we did want to indicate server disk + // space matters to users, we'd probably want to use a warning + // specific to that situation anyhow. So this covers warning covers + // our primary day-to-day concern (individual account quota usage). + // + if (this.storageStats?.quota > 0 && this.storageStats?.free <= 0) { this.showStorageFullWarning() } }, @@ -122,8 +131,9 @@ export default { throw new Error('Invalid storage stats') } - // Warn the user if the available storage changed from > 0 to 0 - if (this.storageStats?.free > 0 && response.data.data?.free <= 0) { + // Warn the user if the available account storage changed from > 0 to 0 + // (unless only because quota was intentionally set to 0 by admin in the interim) + if (this.storageStats?.free > 0 && response.data.data?.free <= 0 && response.data.data?.quota > 0) { this.showStorageFullWarning() } |