More tests

* PreviewController test
* PublicPreview test
* Versions Preview test
* Trash Preview test

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

2 files changed, 181 insertions, 5 deletions

diff --git a/apps/files_trashbin/lib/Controller/PreviewController.php b/apps/files_trashbin/lib/Controller/PreviewController.php
index 1e1f68e4317..c73b1c17c16 100644
--- a/apps/files_trashbin/lib/Controller/PreviewController.php
+++ b/apps/files_trashbin/lib/Controller/PreviewController.php
@@ -114,11 +114,6 @@ class PreviewController extends Controller {
 			return new Http\FileDisplayResponse($f, Http::STATUS_OK, ['Content-Type' => $f->getMimeType()]);
 		} catch (NotFoundException $e) {
 			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		} catch (\OC\PreviewNotAvailableException $e) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		}catch(\Exception $e) {
-			return new DataResponse([], Http::STATUS_INTERNAL_SERVER_ERROR);
 		}
-
 	}
 }
diff --git a/apps/files_trashbin/tests/Controller/PreviewControllerTest.php b/apps/files_trashbin/tests/Controller/PreviewControllerTest.php
new file mode 100644
index 00000000000..685e4cebfd1
--- /dev/null
+++ b/apps/files_trashbin/tests/Controller/PreviewControllerTest.php
@@ -0,0 +1,181 @@
+<?php
+/**
+ * @copyright Copyright (c) 2016, Roeland Jago Douma <roeland@famdouma.nl>
+ *
+ * @author Roeland Jago Douma <roeland@famdouma.nl>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+namespace OCA\Files_Trashbin\Tests\Controller;
+
+use OCA\Files_Trashbin\Controller\PreviewController;
+use OCP\AppFramework\Http;
+use OCP\AppFramework\Http\DataResponse;
+use OCP\AppFramework\Http\FileDisplayResponse;
+use OCP\Files\File;
+use OCP\Files\Folder;
+use OCP\Files\IMimeTypeDetector;
+use OCP\Files\IRootFolder;
+use OCP\Files\NotFoundException;
+use OCP\Files\SimpleFS\ISimpleFile;
+use OCP\IPreview;
+use OCP\IRequest;
+use Test\TestCase;
+
+class PreviewControllerTest extends TestCase {
+
+	/** @var IRootFolder|\PHPUnit_Framework_MockObject_MockObject */
+	private $rootFolder;
+
+	/** @var string */
+	private $userId;
+
+	/** @var IMimeTypeDetector|\PHPUnit_Framework_MockObject_MockObject */
+	private $mimeTypeDetector;
+
+	/** @var IPreview|\PHPUnit_Framework_MockObject_MockObject */
+	private $previewManager;
+
+	/** @var PreviewController */
+	private $controller;
+
+	public function setUp() {
+		parent::setUp();
+
+		$this->rootFolder = $this->createMock(IRootFolder::class);
+		$this->userId = 'user';
+		$this->mimeTypeDetector = $this->createMock(IMimeTypeDetector::class);
+		$this->previewManager = $this->createMock(IPreview::class);
+
+		$this->controller = new PreviewController(
+			'files_versions',
+			$this->createMock(IRequest::class),
+			$this->rootFolder,
+			$this->userId,
+			$this->mimeTypeDetector,
+			$this->previewManager
+		);
+	}
+
+	public function testInvalidFile() {
+		$res = $this->controller->getPreview('');
+		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+
+		$this->assertEquals($expected, $res);
+	}
+
+	public function testInvalidWidth() {
+		$res = $this->controller->getPreview('file', 0);
+		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+
+		$this->assertEquals($expected, $res);
+	}
+
+	public function testInvalidHeight() {
+		$res = $this->controller->getPreview('file', 10, 0);
+		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+
+		$this->assertEquals($expected, $res);
+	}
+
+	public function testValidPreview() {
+		$userFolder = $this->createMock(Folder::class);
+		$userRoot = $this->createMock(Folder::class);
+		$trash = $this->createMock(Folder::class);
+
+		$this->rootFolder->method('getUserFolder')
+			->with($this->userId)
+			->willReturn($userFolder);
+		$userFolder->method('getParent')
+			->willReturn($userRoot);
+		$userRoot->method('get')
+			->with('files_trashbin/files')
+			->willReturn($trash);
+
+		$this->mimeTypeDetector->method('detectPath')
+			->with($this->equalTo('file'))
+			->willReturn('myMime');
+
+		$file = $this->createMock(File::class);
+		$trash->method('get')
+			->with($this->equalTo('file.1234'))
+			->willReturn($file);
+		$file->method('getName')
+			->willReturn('file.1234');
+
+		$preview = $this->createMock(ISimpleFile::class);
+		$this->previewManager->method('getPreview')
+			->with($this->equalTo($file), 10, 10, true, IPreview::MODE_FILL, 'myMime')
+			->willReturn($preview);
+		$preview->method('getMimeType')
+			->willReturn('previewMime');
+
+		$res = $this->controller->getPreview('file.1234', 10, 10);
+		$expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'previewMime']);
+
+		$this->assertEquals($expected, $res);
+	}
+
+	public function testTrashFileNotFound() {
+		$userFolder = $this->createMock(Folder::class);
+		$userRoot = $this->createMock(Folder::class);
+		$trash = $this->createMock(Folder::class);
+
+		$this->rootFolder->method('getUserFolder')
+			->with($this->userId)
+			->willReturn($userFolder);
+		$userFolder->method('getParent')
+			->willReturn($userRoot);
+		$userRoot->method('get')
+			->with('files_trashbin/files')
+			->willReturn($trash);
+
+		$trash->method('get')
+			->with($this->equalTo('file.1234'))
+			->willThrowException(new NotFoundException());
+
+		$res = $this->controller->getPreview('file.1234', 10, 10);
+		$expected = new DataResponse([], Http::STATUS_NOT_FOUND);
+
+		$this->assertEquals($expected, $res);
+	}
+
+	public function testTrashFolder() {
+		$userFolder = $this->createMock(Folder::class);
+		$userRoot = $this->createMock(Folder::class);
+		$trash = $this->createMock(Folder::class);
+
+		$this->rootFolder->method('getUserFolder')
+			->with($this->userId)
+			->willReturn($userFolder);
+		$userFolder->method('getParent')
+			->willReturn($userRoot);
+		$userRoot->method('get')
+			->with('files_trashbin/files')
+			->willReturn($trash);
+
+		$folder = $this->createMock(Folder::class);
+		$trash->method('get')
+			->with($this->equalTo('folder'))
+			->willReturn($folder);
+
+		$res = $this->controller->getPreview('folder', 10, 10);
+		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+
+		$this->assertEquals($expected, $res);
+	}
+}