diff options
| author | Julius Härtl <jus@bitgrid.net> | 2023-03-13 10:57:12 +0100 |
|---|---|---|
| committer | backportbot-nextcloud[bot] <backportbot-nextcloud[bot]@users.noreply.github.com> | 2023-04-14 18:12:12 +0000 |
| commit | 75fc65e0e6b44e931404712983731afb5ca9429f (patch) | |
| tree | e058e5ae4178bd392e8c4b741b3c5b6c5bac3fc2 /apps/files_versions | |
| parent | 13340114699d07044aba67aa1f725ccd76f3162e (diff) | |
| download | nextcloud-server-75fc65e0e6b44e931404712983731afb5ca9429f.tar.gz nextcloud-server-75fc65e0e6b44e931404712983731afb5ca9429f.zip | |
fix: Check return type on rollback
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Diffstat (limited to 'apps/files_versions')
| -rw-r--r-- | apps/files_versions/lib/Versions/VersionManager.php | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/apps/files_versions/lib/Versions/VersionManager.php b/apps/files_versions/lib/Versions/VersionManager.php index 5a2480d6233..b3b6d6f85e8 100644 --- a/apps/files_versions/lib/Versions/VersionManager.php +++ b/apps/files_versions/lib/Versions/VersionManager.php @@ -95,11 +95,14 @@ class VersionManager implements IVersionManager, INameableVersionBackend, IDelet public function rollback(IVersion $version) { $backend = $version->getBackend(); $result = $backend->rollback($version); - \OC_Hook::emit('\OCP\Versions', 'rollback', [ - 'path' => $version->getVersionPath(), - 'revision' => $version->getRevisionId(), - 'node' => $version->getSourceFile(), - ]); + // rollback doesn't have a return type yet and some implementations don't return anything + if ($result === null || $result === true) { + \OC_Hook::emit('\OCP\Versions', 'rollback', [ + 'path' => $version->getVersionPath(), + 'revision' => $version->getRevisionId(), + 'node' => $version->getSourceFile(), + ]); + } return $result; } |