Add SSO for updater application

Allows logging-in into the updater application by visiting the admin panel and pressing "Open updater".

2 files changed, 179 insertions, 0 deletions

diff --git a/apps/updatenotification/tests/ResetTokenBackgroundJobTest.php b/apps/updatenotification/tests/ResetTokenBackgroundJobTest.php
new file mode 100644
index 00000000000..f3d64814ec9
--- /dev/null
+++ b/apps/updatenotification/tests/ResetTokenBackgroundJobTest.php
@@ -0,0 +1,81 @@
+<?php
+/**
+ * @author Lukas Reschke <lukas@owncloud.com>
+ *
+ * @copyright Copyright (c) 2016, ownCloud, Inc.
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+namespace OCA\UpdateNotification\Tests;
+
+use OCA\UpdateNotification\ResetTokenBackgroundJob;
+use OCP\AppFramework\Utility\ITimeFactory;
+use OCP\IConfig;
+use Test\TestCase;
+
+class ResetTokenBackgroundJobTest extends TestCase {
+	/** @var IConfig */
+	private $config;
+	/** @var ResetTokenBackgroundJob */
+	private $resetTokenBackgroundJob;
+	/** @var ITimeFactory */
+	private $timeFactory;
+
+	public function setUp() {
+		parent::setUp();
+		$this->config = $this->getMock('\\OCP\\IConfig');
+		$this->timeFactory = $this->getMock('\\OCP\\AppFramework\\Utility\\ITimeFactory');
+		$this->resetTokenBackgroundJob = new ResetTokenBackgroundJob($this->config, $this->timeFactory);
+	}
+
+	public function testRunWithNotExpiredToken() {
+		$this->timeFactory
+			->expects($this->any())
+			->method('getTime')
+			->willReturn(123);
+		$this->config
+			->expects($this->once())
+			->method('getAppValue')
+			->with('core', 'updater.secret.created', 123);
+		$this->config
+			->expects($this->never())
+			->method('deleteSystemValue')
+			->with('updater.secret');
+
+		$this->invokePrivate($this->resetTokenBackgroundJob, 'run', ['']);
+	}
+
+	public function testRunWithExpiredToken() {
+		$this->timeFactory
+			->expects($this->at(0))
+			->method('getTime')
+			->willReturn(1455131633);
+		$this->timeFactory
+			->expects($this->at(1))
+			->method('getTime')
+			->willReturn(1455045234);
+		$this->config
+			->expects($this->once())
+			->method('getAppValue')
+			->with('core', 'updater.secret.created', 1455045234);
+		$this->config
+			->expects($this->once())
+			->method('deleteSystemValue')
+			->with('updater.secret');
+
+		$this->invokePrivate($this->resetTokenBackgroundJob, 'run', ['']);
+	}
+}
diff --git a/apps/updatenotification/tests/controller/AdminControllerTest.php b/apps/updatenotification/tests/controller/AdminControllerTest.php
new file mode 100644
index 00000000000..01801626000
--- /dev/null
+++ b/apps/updatenotification/tests/controller/AdminControllerTest.php
@@ -0,0 +1,98 @@
+<?php
+/**
+ * @author Lukas Reschke <lukas@owncloud.com>
+ *
+ * @copyright Copyright (c) 2016, ownCloud, Inc.
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+namespace OCA\UpdateNotification\Tests\Controller;
+
+use OCA\UpdateNotification\Controller\AdminController;
+use OCP\AppFramework\Http\DataResponse;
+use OCP\AppFramework\Http\TemplateResponse;
+use OCP\AppFramework\Utility\ITimeFactory;
+use OCP\BackgroundJob\IJobList;
+use OCP\IConfig;
+use OCP\IRequest;
+use OCP\Security\ISecureRandom;
+use Test\TestCase;
+
+class AdminControllerTest extends TestCase {
+	/** @var IRequest */
+	private $request;
+	/** @var IJobList */
+	private $jobList;
+	/** @var ISecureRandom */
+	private $secureRandom;
+	/** @var IConfig */
+	private $config;
+	/** @var AdminController */
+	private $adminController;
+	/** @var ITimeFactory */
+	private $timeFactory;
+
+	public function setUp() {
+		parent::setUp();
+
+		$this->request = $this->getMock('\\OCP\\IRequest');
+		$this->jobList = $this->getMock('\\OCP\\BackgroundJob\\IJobList');
+		$this->secureRandom = $this->getMock('\\OCP\\Security\\ISecureRandom');
+		$this->config = $this->getMock('\\OCP\\IConfig');
+		$this->timeFactory = $this->getMock('\\OCP\\AppFramework\\Utility\\ITimeFactory');
+
+		$this->adminController = new AdminController(
+			'updatenotification',
+			$this->request,
+			$this->jobList,
+			$this->secureRandom,
+			$this->config,
+			$this->timeFactory
+		);
+	}
+
+	public function testDisplayPanel() {
+		$expected = new TemplateResponse('updatenotification', 'admin', [], '');
+		$this->assertEquals($expected, $this->adminController->displayPanel());
+	}
+
+	public function testCreateCredentials() {
+		$this->jobList
+			->expects($this->once())
+			->method('add')
+			->with('OCA\UpdateNotification\ResetTokenBackgroundJob');
+		$this->secureRandom
+			->expects($this->once())
+			->method('generate')
+			->with(32)
+			->willReturn('MyGeneratedToken');
+		$this->config
+			->expects($this->once())
+			->method('setSystemValue')
+			->with('updater.secret', 'MyGeneratedToken');
+		$this->timeFactory
+			->expects($this->once())
+			->method('getTime')
+			->willReturn(12345);
+		$this->config
+			->expects($this->once())
+			->method('setAppValue')
+			->with('core', 'updater.secret.created', 12345);
+
+		$expected = new DataResponse('MyGeneratedToken');
+		$this->assertEquals($expected, $this->adminController->createCredentials());
+	}
+}