summaryrefslogtreecommitdiffstats
path: root/apps/user_ldap/tests
diff options
context:
space:
mode:
authorArthur Schiwon <blizzz@arthur-schiwon.de>2017-09-11 12:10:32 +0200
committerMorris Jobke <hey@morrisjobke.de>2017-09-14 13:20:51 +0200
commit89f4e16cdb90d4fe84597255a4c989adc2f8402a (patch)
treea1f04ca4374dc79556e3c57e9d3b2f2b3f2db7c0 /apps/user_ldap/tests
parent7698781a1e47263c941533b42d2401092284b76b (diff)
downloadnextcloud-server-89f4e16cdb90d4fe84597255a4c989adc2f8402a.tar.gz
nextcloud-server-89f4e16cdb90d4fe84597255a4c989adc2f8402a.zip
fix limit-flaw in search on paged results
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Diffstat (limited to 'apps/user_ldap/tests')
-rw-r--r--apps/user_ldap/tests/Integration/Lib/IntegrationTestPaging.php13
1 files changed, 9 insertions, 4 deletions
diff --git a/apps/user_ldap/tests/Integration/Lib/IntegrationTestPaging.php b/apps/user_ldap/tests/Integration/Lib/IntegrationTestPaging.php
index 44ee1c3bb5c..f9be6d6f675 100644
--- a/apps/user_ldap/tests/Integration/Lib/IntegrationTestPaging.php
+++ b/apps/user_ldap/tests/Integration/Lib/IntegrationTestPaging.php
@@ -47,6 +47,13 @@ class IntegrationTestPaging extends AbstractIntegrationTest {
$this->backend = new User_LDAP($this->access, \OC::$server->getConfig(), \OC::$server->getNotificationManager());
}
+ public function initConnection() {
+ parent::initConnection();
+ $this->connection->setConfiguration([
+ 'ldapPagingSize' => 1
+ ]);
+ }
+
/**
* tests that paging works properly against a simple example (reading all
* of few users in smallest steps)
@@ -54,20 +61,18 @@ class IntegrationTestPaging extends AbstractIntegrationTest {
* @return bool
*/
protected function case1() {
- $limit = 1;
$offset = 0;
$filter = 'objectclass=inetorgperson';
$attributes = ['cn', 'dn'];
$users = [];
do {
- $result = $this->access->searchUsers($filter, $attributes, $limit, $offset);
+ $result = $this->access->searchUsers($filter, $attributes, null, $offset);
foreach($result as $user) {
$users[] = $user['cn'];
}
- $offset += $limit;
+ $offset += count($users);
} while ($this->access->hasMoreResults());
-
if(count($users) === 2) {
return true;
}