diff options
| author | MichaIng <micha@dietpi.com> | 2023-12-22 04:10:07 +0100 |
|---|---|---|
| committer | backportbot[bot] <backportbot[bot]@users.noreply.github.com> | 2024-02-23 20:29:43 +0000 |
| commit | 54f47f53a80241a3962f4da7bab583a2217a14c9 (patch) | |
| tree | 0e103c35687a2c79d23a980953aac2b11f385f04 /apps | |
| parent | 5087de9f9892e97f5f72b96230a7067fbe8063ea (diff) | |
| download | nextcloud-server-54f47f53a80241a3962f4da7bab583a2217a14c9.tar.gz nextcloud-server-54f47f53a80241a3962f4da7bab583a2217a14c9.zip | |
fix(dav): fallback realm for HTTP authentication
By default, the name of the Nextcloud instance is an empty string, until changed by the admin. This leads to an empty realm sent with the WWW-Authenticate header, while the realm is mandatory for Basic HTTP authentication. Some clients have issues with an empty realm, e.g. Thunderbird cannot store passwords in this case.
This commit applies "Nextcloud" as fallback for the realm, in case the name of the Nextcloud instance is not set.
Solves: https://help.nextcloud.com/t/thunderbird-dont-save-caldav-password-because-of-missing-httprealm-or-formsubmiturl/93233
Signed-off-by: MichaIng <micha@dietpi.com>
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/dav/lib/Connector/PublicAuth.php | 2 | ||||
| -rw-r--r-- | apps/dav/lib/Connector/Sabre/Auth.php | 2 | ||||
| -rw-r--r-- | apps/dav/lib/Connector/Sabre/BearerAuth.php | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/apps/dav/lib/Connector/PublicAuth.php b/apps/dav/lib/Connector/PublicAuth.php index d613a5a188f..65b20ca661a 100644 --- a/apps/dav/lib/Connector/PublicAuth.php +++ b/apps/dav/lib/Connector/PublicAuth.php @@ -61,7 +61,7 @@ class PublicAuth extends AbstractBasic { // setup realm $defaults = new \OCP\Defaults(); - $this->realm = $defaults->getName(); + $this->realm = $defaults->getName() ?: 'Nextcloud'; } /** diff --git a/apps/dav/lib/Connector/Sabre/Auth.php b/apps/dav/lib/Connector/Sabre/Auth.php index 243b92e63f7..c2e343d8656 100644 --- a/apps/dav/lib/Connector/Sabre/Auth.php +++ b/apps/dav/lib/Connector/Sabre/Auth.php @@ -75,7 +75,7 @@ class Auth extends AbstractBasic { // setup realm $defaults = new \OCP\Defaults(); - $this->realm = $defaults->getName(); + $this->realm = $defaults->getName() ?: 'Nextcloud'; } /** diff --git a/apps/dav/lib/Connector/Sabre/BearerAuth.php b/apps/dav/lib/Connector/Sabre/BearerAuth.php index 4d9599b97a3..6fd61c44b34 100644 --- a/apps/dav/lib/Connector/Sabre/BearerAuth.php +++ b/apps/dav/lib/Connector/Sabre/BearerAuth.php @@ -47,7 +47,7 @@ class BearerAuth extends AbstractBearer { // setup realm $defaults = new \OCP\Defaults(); - $this->realm = $defaults->getName(); + $this->realm = $defaults->getName() ?: 'Nextcloud'; } private function setupUserFs($userId) { |