diff options
| author | Carl Schwan <carl@carlschwan.eu> | 2022-02-11 22:14:04 +0100 |
|---|---|---|
| committer | Carl Schwan <carl@carlschwan.eu> | 2022-02-16 11:35:57 +0100 |
| commit | 7dddbd0c355d1b4761466f9f86b30aed8b112ba1 (patch) | |
| tree | b782783ff0b88277e79a5ce3b5115f47a4b240f0 /apps | |
| parent | fbbbc2ec3445aa777f56c97a0a383a2e8566be54 (diff) | |
| download | nextcloud-server-7dddbd0c355d1b4761466f9f86b30aed8b112ba1.tar.gz nextcloud-server-7dddbd0c355d1b4761466f9f86b30aed8b112ba1.zip | |
Improve caching policy
* Cache css with version in url. This makes most js and css requests to
be cached by the browser
* Force caching previews, the etag is in the url so that if the propfind
gives a new etag, we will refresh it otherwise it's no use to try to
fetch the new etag and do tons of DB queries
Tested with firefox and 'debug' => false (important so that the js/css
urls are generated with ?v= parameter)
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/theming/lib/Controller/IconController.php | 2 | ||||
| -rw-r--r-- | apps/theming/tests/Controller/IconControllerTest.php | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/apps/theming/lib/Controller/IconController.php b/apps/theming/lib/Controller/IconController.php index 45d3ee14e47..173b5210394 100644 --- a/apps/theming/lib/Controller/IconController.php +++ b/apps/theming/lib/Controller/IconController.php @@ -96,7 +96,7 @@ class IconController extends Controller { $iconFile = $this->imageManager->setCachedImage('icon-' . $app . '-' . str_replace('/', '_',$image), $icon); } $response = new FileDisplayResponse($iconFile, Http::STATUS_OK, ['Content-Type' => 'image/svg+xml']); - $response->cacheFor(86400); + $response->cacheFor(86400, false, true); return $response; } diff --git a/apps/theming/tests/Controller/IconControllerTest.php b/apps/theming/tests/Controller/IconControllerTest.php index 04954782168..470709a3fab 100644 --- a/apps/theming/tests/Controller/IconControllerTest.php +++ b/apps/theming/tests/Controller/IconControllerTest.php @@ -104,7 +104,7 @@ class IconControllerTest extends TestCase { ->with('icon-core-filetypes_folder.svg') ->willReturn($file); $expected = new FileDisplayResponse($file, Http::STATUS_OK, ['Content-Type' => 'image/svg+xml']); - $expected->cacheFor(86400); + $expected->cacheFor(86400, false, true); $this->assertEquals($expected, $this->iconController->getThemedIcon('core', 'filetypes/folder.svg')); } |