Merge pull request #38034 from nextcloud/automated/noid/master-update-psalm-baseline

[master] Update psalm-baseline.xml

1 files changed, 75 insertions, 112 deletions

diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml
index ac20e6ffbad..e7359123151 100644
--- a/build/psalm-baseline.xml
+++ b/build/psalm-baseline.xml
@@ -92,7 +92,7 @@
   </file>
   <file src="apps/dav/appinfo/v1/webdav.php">
     <InvalidArgument>
-      <code><![CDATA['OCA\DAV\Connector\Sabre::addPlugin']]></code>
+      <code>'OCA\DAV\Connector\Sabre::addPlugin'</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>dispatch</code>
@@ -324,7 +324,7 @@
     </RedundantCast>
     <RedundantCondition>
       <code><![CDATA[!empty($modified['old']) && is_array($modified['old'])]]></code>
-      <code><![CDATA[is_array($modified['old'])]]></code>
+      <code>is_array($modified['old'])</code>
     </RedundantCondition>
   </file>
   <file src="apps/dav/lib/CalDAV/Schedule/IMipService.php">
@@ -335,8 +335,8 @@
   </file>
   <file src="apps/dav/lib/CalDAV/Schedule/Plugin.php">
     <InvalidArgument>
-      <code><![CDATA[[$aclPlugin, 'propFind']]]></code>
-      <code><![CDATA[[$aclPlugin, 'propFind']]]></code>
+      <code>[$aclPlugin, 'propFind']</code>
+      <code>[$aclPlugin, 'propFind']</code>
     </InvalidArgument>
     <UndefinedInterfaceMethod>
       <code>get</code>
@@ -368,12 +368,12 @@
   </file>
   <file src="apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php">
     <TypeDoesNotContainType>
-      <code><![CDATA[!is_array($newProps['filters']['comps'])]]></code>
-      <code><![CDATA[!is_array($newProps['filters']['params'])]]></code>
-      <code><![CDATA[!is_array($newProps['filters']['props'])]]></code>
-      <code><![CDATA[!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])]]></code>
-      <code><![CDATA[!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])]]></code>
-      <code><![CDATA[!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])]]></code>
+      <code>!is_array($newProps['filters']['comps'])</code>
+      <code>!is_array($newProps['filters']['params'])</code>
+      <code>!is_array($newProps['filters']['props'])</code>
+      <code>!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])</code>
+      <code>!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])</code>
+      <code>!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])</code>
     </TypeDoesNotContainType>
   </file>
   <file src="apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php">
@@ -397,7 +397,7 @@
       <code>false</code>
     </FalsableReturnStatement>
     <TypeDoesNotContainType>
-      <code><![CDATA[$addressBooks[$row['id']][$readOnlyPropertyName] === 0]]></code>
+      <code>$addressBooks[$row['id']][$readOnlyPropertyName] === 0</code>
     </TypeDoesNotContainType>
   </file>
   <file src="apps/dav/lib/CardDAV/MultiGetExportPlugin.php">
@@ -442,7 +442,7 @@
       <code>200</code>
     </InvalidArgument>
     <InvalidScalarArgument>
-      <code><![CDATA[$args['datetime']]]></code>
+      <code>$args['datetime']</code>
     </InvalidScalarArgument>
     <UndefinedFunction>
       <code>\Sabre\HTTP\toDate($value)</code>
@@ -515,7 +515,7 @@
       <code>$resultFileIds</code>
     </NullableReturnStatement>
     <TooManyArguments>
-      <code><![CDATA[new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)]]></code>
+      <code>new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)</code>
     </TooManyArguments>
     <UndefinedClass>
       <code>\OCA\Circles\Api\v1\Circles</code>
@@ -786,8 +786,8 @@
   </file>
   <file src="apps/dav/lib/Server.php">
     <InvalidArgument>
-      <code><![CDATA['OCA\DAV\Connector\Sabre::addPlugin']]></code>
-      <code><![CDATA['OCA\DAV\Connector\Sabre::authInit']]></code>
+      <code>'OCA\DAV\Connector\Sabre::addPlugin'</code>
+      <code>'OCA\DAV\Connector\Sabre::authInit'</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>dispatch</code>
@@ -855,7 +855,7 @@
       <code>$userSession</code>
     </RedundantCondition>
     <TypeDoesNotContainType>
-      <code><![CDATA[get_class($res) === 'OpenSSLAsymmetricKey']]></code>
+      <code>get_class($res) === 'OpenSSLAsymmetricKey'</code>
     </TypeDoesNotContainType>
   </file>
   <file src="apps/encryption/lib/Crypto/Encryption.php">
@@ -875,7 +875,7 @@
   </file>
   <file src="apps/encryption/lib/Session.php">
     <TooManyArguments>
-      <code><![CDATA[new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)]]></code>
+      <code>new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)</code>
     </TooManyArguments>
   </file>
   <file src="apps/encryption/lib/Util.php">
@@ -908,7 +908,7 @@
       <code>$shareId</code>
       <code>$shareId</code>
       <code>$shareId</code>
-      <code><![CDATA[(int)$data['id']]]></code>
+      <code>(int)$data['id']</code>
     </InvalidArgument>
   </file>
   <file src="apps/federatedfilesharing/lib/Listeners/LoadAdditionalScriptsListener.php">
@@ -937,7 +937,7 @@
       <code>string</code>
     </InvalidReturnType>
     <InvalidScalarArgument>
-      <code><![CDATA[(int)$share['id']]]></code>
+      <code>(int)$share['id']</code>
     </InvalidScalarArgument>
   </file>
   <file src="apps/federation/lib/Listener/SabrePluginAuthInitListener.php">
@@ -1046,7 +1046,7 @@
   </file>
   <file src="apps/files/lib/Service/TagService.php">
     <InvalidArgument>
-      <code><![CDATA[self::class . '::' . $eventName]]></code>
+      <code>self::class . '::' . $eventName</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>dispatch</code>
@@ -1068,34 +1068,12 @@
       <code>getUniqueStorages</code>
     </UndefinedMethod>
   </file>
-  <file src="apps/files_external/lib/Lib/Storage/AmazonS3.php">
-    <InvalidReturnStatement>
-      <code><![CDATA[IteratorDirectory::wrap(array_map(function (array $item) {
-				return $item['name'];
-			}, $content))]]></code>
-    </InvalidReturnStatement>
-    <InvalidReturnType>
-      <code>opendir</code>
-    </InvalidReturnType>
-  </file>
   <file src="apps/files_external/lib/Lib/Storage/SFTP.php">
     <InternalMethod>
       <code>put</code>
     </InternalMethod>
-    <InvalidReturnStatement>
-      <code>IteratorDirectory::wrap($dirStream)</code>
-    </InvalidReturnStatement>
-    <InvalidReturnType>
-      <code>opendir</code>
-    </InvalidReturnType>
   </file>
   <file src="apps/files_external/lib/Lib/Storage/SMB.php">
-    <InvalidReturnStatement>
-      <code>IteratorDirectory::wrap($names)</code>
-    </InvalidReturnStatement>
-    <InvalidReturnType>
-      <code>opendir</code>
-    </InvalidReturnType>
     <RedundantCast>
       <code><![CDATA[(int)$e->getCode()]]></code>
       <code><![CDATA[(int)$e->getCode()]]></code>
@@ -1114,12 +1092,6 @@
       <code>filetype</code>
       <code>fopen</code>
     </InvalidNullableReturnType>
-    <InvalidReturnStatement>
-      <code>IteratorDirectory::wrap($files)</code>
-    </InvalidReturnStatement>
-    <InvalidReturnType>
-      <code>opendir</code>
-    </InvalidReturnType>
   </file>
   <file src="apps/files_external/lib/Listener/GroupDeletedListener.php">
     <MissingTemplateParam>
@@ -1154,7 +1126,7 @@
   </file>
   <file src="apps/files_external/lib/Service/BackendService.php">
     <InvalidArgument>
-      <code><![CDATA['OCA\\Files_External::loadAdditionalBackends']]></code>
+      <code>'OCA\\Files_External::loadAdditionalBackends'</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>dispatch</code>
@@ -1269,7 +1241,7 @@
   </file>
   <file src="apps/files_sharing/templates/public.php">
     <RedundantCondition>
-      <code><![CDATA[$_['hideFileList'] !== true]]></code>
+      <code>$_['hideFileList'] !== true</code>
       <code><![CDATA[isset($_['hideFileList']) && $_['hideFileList'] !== true]]></code>
     </RedundantCondition>
   </file>
@@ -1317,7 +1289,7 @@
   </file>
   <file src="apps/files_trashbin/lib/Storage.php">
     <InvalidArgument>
-      <code><![CDATA['OCA\Files_Trashbin::moveToTrash']]></code>
+      <code>'OCA\Files_Trashbin::moveToTrash'</code>
     </InvalidArgument>
     <InvalidOperand>
       <code><![CDATA[$this->mountPoint]]></code>
@@ -1472,7 +1444,7 @@
   <file src="apps/sharebymail/lib/ShareByMailProvider.php">
     <InvalidArgument>
       <code><![CDATA[$share->getId()]]></code>
-      <code><![CDATA[(int)$data['id']]]></code>
+      <code>(int)$data['id']</code>
     </InvalidArgument>
   </file>
   <file src="apps/systemtags/lib/Activity/Listener.php">
@@ -1566,7 +1538,7 @@
   </file>
   <file src="apps/user_ldap/lib/AppInfo/Application.php">
     <InvalidArgument>
-      <code><![CDATA['OCA\\User_LDAP\\User\\User::postLDAPBackendAdded']]></code>
+      <code>'OCA\\User_LDAP\\User\\User::postLDAPBackendAdded'</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>dispatch</code>
@@ -1941,7 +1913,7 @@
   </file>
   <file src="lib/private/Accounts/AccountManager.php">
     <InvalidArgument>
-      <code><![CDATA['OC\AccountManager::userUpdated']]></code>
+      <code>'OC\AccountManager::userUpdated'</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>dispatch</code>
@@ -2119,7 +2091,7 @@
   </file>
   <file src="lib/private/AppFramework/Routing/RouteConfig.php">
     <InvalidArrayOffset>
-      <code><![CDATA[$action['url-postfix']]]></code>
+      <code>$action['url-postfix']</code>
     </InvalidArrayOffset>
   </file>
   <file src="lib/private/AppFramework/Services/AppConfig.php">
@@ -2228,7 +2200,7 @@
   </file>
   <file src="lib/private/Authentication/TwoFactorAuth/Registry.php">
     <InvalidArrayAccess>
-      <code><![CDATA[$provider['provider_id']]]></code>
+      <code>$provider['provider_id']</code>
     </InvalidArrayAccess>
   </file>
   <file src="lib/private/BackgroundJob/QueuedJob.php">
@@ -2357,7 +2329,7 @@
       <code>getParams</code>
     </InternalMethod>
     <InvalidArrayOffset>
-      <code><![CDATA[$params['collation']]]></code>
+      <code>$params['collation']</code>
     </InvalidArrayOffset>
   </file>
   <file src="lib/private/DB/Connection.php">
@@ -2368,8 +2340,8 @@
       <code>$params</code>
     </InvalidArgument>
     <InvalidArrayOffset>
-      <code><![CDATA[$params['adapter']]]></code>
-      <code><![CDATA[$params['tablePrefix']]]></code>
+      <code>$params['adapter']</code>
+      <code>$params['tablePrefix']</code>
     </InvalidArrayOffset>
     <InvalidReturnStatement>
       <code><![CDATA[$this->adapter->lastInsertId($seqName)]]></code>
@@ -2415,7 +2387,7 @@
       <code>getParams</code>
     </InternalMethod>
     <InvalidArrayOffset>
-      <code><![CDATA[$params['collation']]]></code>
+      <code>$params['collation']</code>
     </InvalidArrayOffset>
   </file>
   <file src="lib/private/DB/QueryBuilder/QueryBuilder.php">
@@ -2610,10 +2582,10 @@
       <code>$user</code>
     </InvalidOperand>
     <RedundantCondition>
-      <code><![CDATA[get_class($provider) !== 'OCA\Files_Sharing\MountProvider']]></code>
+      <code>get_class($provider) !== 'OCA\Files_Sharing\MountProvider'</code>
     </RedundantCondition>
     <TypeDoesNotContainType>
-      <code><![CDATA[get_class($provider) === 'OCA\Files_Sharing\MountProvider']]></code>
+      <code>get_class($provider) === 'OCA\Files_Sharing\MountProvider'</code>
     </TypeDoesNotContainType>
   </file>
   <file src="lib/private/Files/Config/UserMountCache.php">
@@ -2663,19 +2635,19 @@
   </file>
   <file src="lib/private/Files/Node/HookConnector.php">
     <InvalidArgument>
-      <code><![CDATA['\OCP\Files::postCopy']]></code>
-      <code><![CDATA['\OCP\Files::postCreate']]></code>
-      <code><![CDATA['\OCP\Files::postDelete']]></code>
-      <code><![CDATA['\OCP\Files::postRename']]></code>
-      <code><![CDATA['\OCP\Files::postTouch']]></code>
-      <code><![CDATA['\OCP\Files::postWrite']]></code>
-      <code><![CDATA['\OCP\Files::preCopy']]></code>
-      <code><![CDATA['\OCP\Files::preCreate']]></code>
-      <code><![CDATA['\OCP\Files::preDelete']]></code>
-      <code><![CDATA['\OCP\Files::preRename']]></code>
-      <code><![CDATA['\OCP\Files::preTouch']]></code>
-      <code><![CDATA['\OCP\Files::preWrite']]></code>
-      <code><![CDATA['\OCP\Files::read']]></code>
+      <code>'\OCP\Files::postCopy'</code>
+      <code>'\OCP\Files::postCreate'</code>
+      <code>'\OCP\Files::postDelete'</code>
+      <code>'\OCP\Files::postRename'</code>
+      <code>'\OCP\Files::postTouch'</code>
+      <code>'\OCP\Files::postWrite'</code>
+      <code>'\OCP\Files::preCopy'</code>
+      <code>'\OCP\Files::preCreate'</code>
+      <code>'\OCP\Files::preDelete'</code>
+      <code>'\OCP\Files::preRename'</code>
+      <code>'\OCP\Files::preTouch'</code>
+      <code>'\OCP\Files::preWrite'</code>
+      <code>'\OCP\Files::read'</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>dispatch</code>
@@ -2718,7 +2690,7 @@
       <code>Node</code>
     </ImplementedReturnTypeMismatch>
     <InvalidArgument>
-      <code><![CDATA['\OCP\Files::' . $hook]]></code>
+      <code>'\OCP\Files::' . $hook</code>
     </InvalidArgument>
     <InvalidNullableReturnType>
       <code>FileInfo</code>
@@ -2781,7 +2753,7 @@
       <code>Promise\promise_for(
 					new Credentials($key, $secret)
 				)</code>
-      <code><![CDATA[\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())]]></code>
+      <code>\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())</code>
     </UndefinedFunction>
   </file>
   <file src="lib/private/Files/ObjectStore/S3ObjectTrait.php">
@@ -2831,11 +2803,9 @@
     </InvalidNullableReturnType>
     <InvalidReturnStatement>
       <code><![CDATA[$response->getBody()]]></code>
-      <code>IteratorDirectory::wrap($content)</code>
     </InvalidReturnStatement>
     <InvalidReturnType>
       <code>fopen</code>
-      <code>opendir</code>
     </InvalidReturnType>
     <NullableReturnStatement>
       <code>null</code>
@@ -3000,12 +2970,12 @@
   </file>
   <file src="lib/private/Group/Group.php">
     <InvalidArgument>
-      <code><![CDATA[IGroup::class . '::postAddUser']]></code>
-      <code><![CDATA[IGroup::class . '::postDelete']]></code>
-      <code><![CDATA[IGroup::class . '::postRemoveUser']]></code>
-      <code><![CDATA[IGroup::class . '::preAddUser']]></code>
-      <code><![CDATA[IGroup::class . '::preDelete']]></code>
-      <code><![CDATA[IGroup::class . '::preRemoveUser']]></code>
+      <code>IGroup::class . '::postAddUser'</code>
+      <code>IGroup::class . '::postDelete'</code>
+      <code>IGroup::class . '::postRemoveUser'</code>
+      <code>IGroup::class . '::preAddUser'</code>
+      <code>IGroup::class . '::preDelete'</code>
+      <code>IGroup::class . '::preRemoveUser'</code>
       <code>bool</code>
     </InvalidArgument>
     <InvalidOperand>
@@ -3060,8 +3030,8 @@
       <code>false</code>
     </InvalidArgument>
     <InvalidArrayOffset>
-      <code><![CDATA[$app['path']]]></code>
-      <code><![CDATA[$app['path']]]></code>
+      <code>$app['path']</code>
+      <code>$app['path']</code>
     </InvalidArrayOffset>
     <NullArgument>
       <code>null</code>
@@ -3185,9 +3155,6 @@
     </UndefinedFunction>
   </file>
   <file src="lib/private/Memcache/APCu.php">
-    <InvalidClass>
-      <code>\APCUIterator</code>
-    </InvalidClass>
     <InvalidReturnStatement>
       <code><![CDATA[apcu_add($this->getPrefix() . $key, $value, $ttl)]]></code>
     </InvalidReturnStatement>
@@ -3222,7 +3189,7 @@
       <code>$exifData</code>
     </InvalidReturnStatement>
     <InvalidReturnType>
-      <code><![CDATA[array{'gps': FileMetadata, 'size': FileMetadata}]]></code>
+      <code>array{'gps': FileMetadata, 'size': FileMetadata}</code>
     </InvalidReturnType>
   </file>
   <file src="lib/private/NavigationManager.php">
@@ -3432,8 +3399,8 @@
   </file>
   <file src="lib/private/Setup.php">
     <RedundantCondition>
-      <code><![CDATA[$content !== '']]></code>
-      <code><![CDATA[$type === 'pdo']]></code>
+      <code>$content !== ''</code>
+      <code>$type === 'pdo'</code>
     </RedundantCondition>
     <UndefinedVariable>
       <code>$vendor</code>
@@ -3463,7 +3430,7 @@
     <InvalidArgument>
       <code><![CDATA[$share->getId()]]></code>
       <code><![CDATA[$share->getId()]]></code>
-      <code><![CDATA[(int)$data['id']]]></code>
+      <code>(int)$data['id']</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>set</code>
@@ -3475,12 +3442,12 @@
   <file src="lib/private/Share20/Manager.php">
     <InvalidArgument>
       <code>$id</code>
-      <code><![CDATA['OCP\Share::postAcceptShare']]></code>
-      <code><![CDATA['OCP\Share::postShare']]></code>
-      <code><![CDATA['OCP\Share::postUnshare']]></code>
-      <code><![CDATA['OCP\Share::postUnshareFromSelf']]></code>
-      <code><![CDATA['OCP\Share::preShare']]></code>
-      <code><![CDATA['OCP\Share::preUnshare']]></code>
+      <code>'OCP\Share::postAcceptShare'</code>
+      <code>'OCP\Share::postShare'</code>
+      <code>'OCP\Share::postUnshare'</code>
+      <code>'OCP\Share::postUnshareFromSelf'</code>
+      <code>'OCP\Share::preShare'</code>
+      <code>'OCP\Share::preUnshare'</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>dispatch</code>
@@ -3669,7 +3636,7 @@
       <code>boolean|null</code>
     </ImplementedReturnTypeMismatch>
     <InvalidArgument>
-      <code><![CDATA[IUser::class . '::firstLogin']]></code>
+      <code>IUser::class . '::firstLogin'</code>
     </InvalidArgument>
     <NoInterfaceProperties>
       <code><![CDATA[$request->server]]></code>
@@ -3681,11 +3648,11 @@
   </file>
   <file src="lib/private/User/User.php">
     <InvalidArgument>
-      <code><![CDATA[IUser::class . '::changeUser']]></code>
-      <code><![CDATA[IUser::class . '::postDelete']]></code>
-      <code><![CDATA[IUser::class . '::postSetPassword']]></code>
-      <code><![CDATA[IUser::class . '::preDelete']]></code>
-      <code><![CDATA[IUser::class . '::preSetPassword']]></code>
+      <code>IUser::class . '::changeUser'</code>
+      <code>IUser::class . '::postDelete'</code>
+      <code>IUser::class . '::postSetPassword'</code>
+      <code>IUser::class . '::preDelete'</code>
+      <code>IUser::class . '::preSetPassword'</code>
     </InvalidArgument>
     <TooManyArguments>
       <code>dispatch</code>
@@ -3716,8 +3683,8 @@
       <code>ManagerEvent::EVENT_APP_UPDATE</code>
     </InvalidArgument>
     <InvalidArrayOffset>
-      <code><![CDATA[$dir['path']]]></code>
-      <code><![CDATA[$dir['url']]]></code>
+      <code>$dir['path']</code>
+      <code>$dir['url']</code>
     </InvalidArrayOffset>
     <NullArgument>
       <code>null</code>
@@ -3771,10 +3738,6 @@
     </UndefinedClass>
   </file>
   <file src="lib/private/legacy/OC_Util.php">
-    <InvalidOperand>
-      <code>$version</code>
-      <code>$version</code>
-    </InvalidOperand>
     <InvalidReturnType>
       <code>void</code>
     </InvalidReturnType>