Update core to PHP 7.4 standard

- Typed properties
- Port to LoggerInterface

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

10 files changed, 18 insertions, 70 deletions

diff --git a/core/Command/User/Add.php b/core/Command/User/Add.php
index 574be6e421c..24d11fbee6e 100644
--- a/core/Command/User/Add.php
+++ b/core/Command/User/Add.php
@@ -39,16 +39,9 @@ use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\Question;
 
 class Add extends Command {
-	/** @var \OCP\IUserManager */
-	protected $userManager;
+	protected IUserManager $userManager;
+	protected IGroupManager $groupManager;
 
-	/** @var \OCP\IGroupManager */
-	protected $groupManager;
-
-	/**
-	 * @param IUserManager $userManager
-	 * @param IGroupManager $groupManager
-	 */
 	public function __construct(IUserManager $userManager, IGroupManager $groupManager) {
 		parent::__construct();
 		$this->userManager = $userManager;
diff --git a/core/Command/User/AddAppPassword.php b/core/Command/User/AddAppPassword.php
index 65b572533f5..ec39cdc974e 100644
--- a/core/Command/User/AddAppPassword.php
+++ b/core/Command/User/AddAppPassword.php
@@ -41,18 +41,10 @@ use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\Question;
 
 class AddAppPassword extends Command {
-
-	/** @var IUserManager */
-	protected $userManager;
-
-	/** @var IProvider */
-	protected $tokenProvider;
-
-	/** @var ISecureRandom */
-	private $random;
-
-	/** @var IEventDispatcher */
-	private $eventDispatcher;
+	protected IUserManager $userManager;
+	protected IProvider $tokenProvider;
+	private ISecureRandom $random;
+	private IEventDispatcher $eventDispatcher;
 
 	public function __construct(IUserManager $userManager,
 								IProvider $tokenProvider,
diff --git a/core/Command/User/Disable.php b/core/Command/User/Disable.php
index 9120d28cc1f..bc819f39e1d 100644
--- a/core/Command/User/Disable.php
+++ b/core/Command/User/Disable.php
@@ -32,12 +32,8 @@ use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Disable extends Base {
-	/** @var IUserManager */
-	protected $userManager;
+	protected IUserManager $userManager;
 
-	/**
-	 * @param IUserManager $userManager
-	 */
 	public function __construct(IUserManager $userManager) {
 		$this->userManager = $userManager;
 		parent::__construct();
diff --git a/core/Command/User/Enable.php b/core/Command/User/Enable.php
index eb548a74d7e..f4e16eec4af 100644
--- a/core/Command/User/Enable.php
+++ b/core/Command/User/Enable.php
@@ -32,12 +32,8 @@ use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Enable extends Base {
-	/** @var IUserManager */
-	protected $userManager;
+	protected IUserManager $userManager;
 
-	/**
-	 * @param IUserManager $userManager
-	 */
 	public function __construct(IUserManager $userManager) {
 		$this->userManager = $userManager;
 		parent::__construct();
diff --git a/core/Command/User/Info.php b/core/Command/User/Info.php
index a93f65b7dce..1e89a8d0911 100644
--- a/core/Command/User/Info.php
+++ b/core/Command/User/Info.php
@@ -35,15 +35,9 @@ use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Info extends Base {
-	/** @var IUserManager */
-	protected $userManager;
-	/** @var IGroupManager */
-	protected $groupManager;
+	protected IUserManager $userManager;
+	protected IGroupManager $groupManager;
 
-	/**
-	 * @param IUserManager $userManager
-	 * @param IGroupManager $groupManager
-	 */
 	public function __construct(IUserManager $userManager, IGroupManager $groupManager) {
 		$this->userManager = $userManager;
 		$this->groupManager = $groupManager;
diff --git a/core/Command/User/LastSeen.php b/core/Command/User/LastSeen.php
index dc01ca549f3..5ea6c64d249 100644
--- a/core/Command/User/LastSeen.php
+++ b/core/Command/User/LastSeen.php
@@ -34,12 +34,8 @@ use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class LastSeen extends Base {
-	/** @var IUserManager */
-	protected $userManager;
+	protected IUserManager $userManager;
 
-	/**
-	 * @param IUserManager $userManager
-	 */
 	public function __construct(IUserManager $userManager) {
 		$this->userManager = $userManager;
 		parent::__construct();
diff --git a/core/Command/User/ListCommand.php b/core/Command/User/ListCommand.php
index 20422afbf9d..c254a8a11cf 100644
--- a/core/Command/User/ListCommand.php
+++ b/core/Command/User/ListCommand.php
@@ -33,17 +33,9 @@ use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ListCommand extends Base {
+	protected IUserManager $userManager;
+	protected IGroupManager $groupManager;
 
-	/** @var IUserManager */
-	protected $userManager;
-
-	/** @var IGroupManager */
-	protected $groupManager;
-
-	/**
-	 * @param IUserManager $userManager
-	 * @param IGroupManager $groupManager
-	 */
 	public function __construct(IUserManager $userManager,
 								IGroupManager $groupManager) {
 		$this->userManager = $userManager;
diff --git a/core/Command/User/Report.php b/core/Command/User/Report.php
index 149abc006f9..e080a617258 100644
--- a/core/Command/User/Report.php
+++ b/core/Command/User/Report.php
@@ -41,10 +41,8 @@ use Symfony\Component\Console\Output\OutputInterface;
 class Report extends Command {
 	public const DEFAULT_COUNT_DIRS_MAX_USERS = 500;
 
-	/** @var IUserManager */
-	protected $userManager;
-	/** @var IConfig */
-	private $config;
+	protected IUserManager $userManager;
+	private IConfig $config;
 
 	public function __construct(IUserManager $userManager,
 								IConfig $config) {
diff --git a/core/Command/User/ResetPassword.php b/core/Command/User/ResetPassword.php
index 174a9f4068d..21bc5cc45b0 100644
--- a/core/Command/User/ResetPassword.php
+++ b/core/Command/User/ResetPassword.php
@@ -40,9 +40,7 @@ use Symfony\Component\Console\Question\ConfirmationQuestion;
 use Symfony\Component\Console\Question\Question;
 
 class ResetPassword extends Base {
-
-	/** @var IUserManager */
-	protected $userManager;
+	protected IUserManager $userManager;
 
 	public function __construct(IUserManager $userManager) {
 		$this->userManager = $userManager;
diff --git a/core/Command/User/Setting.php b/core/Command/User/Setting.php
index 3e4830127cd..6e7c15375d1 100644
--- a/core/Command/User/Setting.php
+++ b/core/Command/User/Setting.php
@@ -36,16 +36,9 @@ use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 
 class Setting extends Base {
-	/** @var IUserManager */
-	protected $userManager;
+	protected IUserManager $userManager;
+	protected IConfig $config;
 
-	/** @var IConfig */
-	protected $config;
-
-	/**
-	 * @param IUserManager $userManager
-	 * @param IConfig $config
-	 */
 	public function __construct(IUserManager $userManager, IConfig $config) {
 		parent::__construct();
 		$this->userManager = $userManager;