diff options
author | Côme Chilliet <come.chilliet@nextcloud.com> | 2023-11-14 15:51:26 +0100 |
---|---|---|
committer | backportbot-nextcloud[bot] <backportbot-nextcloud[bot]@users.noreply.github.com> | 2023-12-04 16:23:23 +0000 |
commit | e48e67b0a43bca34c373387ac42184ba1f44fda0 (patch) | |
tree | 10c6cc788cc37bc15dc9864b8e238134bfbcb2b3 /core/js | |
parent | d0a72a103d220fe15d34237e427f1ae0fec450c5 (diff) | |
download | nextcloud-server-e48e67b0a43bca34c373387ac42184ba1f44fda0.tar.gz nextcloud-server-e48e67b0a43bca34c373387ac42184ba1f44fda0.zip |
Migrate missing index database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Diffstat (limited to 'core/js')
-rw-r--r-- | core/js/setupchecks.js | 12 | ||||
-rw-r--r-- | core/js/tests/specs/setupchecksSpec.js | 17 |
2 files changed, 0 insertions, 29 deletions
diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js index 5cd2cadaa2d..f926d1534a5 100644 --- a/core/js/setupchecks.js +++ b/core/js/setupchecks.js @@ -258,18 +258,6 @@ type: OC.SetupChecks.MESSAGE_TYPE_WARNING }); } - if (data.missingIndexes.length > 0) { - var listOfMissingIndexes = ""; - data.missingIndexes.forEach(function(element){ - listOfMissingIndexes += '<li>'; - listOfMissingIndexes += t('core', 'Missing index "{indexName}" in table "{tableName}".', element); - listOfMissingIndexes += '</li>'; - }); - messages.push({ - msg: t('core', 'The database is missing some indexes. Due to the fact that adding indexes on big tables could take some time they were not added automatically. By running "occ db:add-missing-indices" those missing indexes could be added manually while the instance keeps running. Once the indexes are added queries to those tables are usually much faster.') + '<ul>' + listOfMissingIndexes + '</ul>', - type: OC.SetupChecks.MESSAGE_TYPE_INFO - }) - } if (data.missingPrimaryKeys.length > 0) { var listOfMissingPrimaryKeys = ""; data.missingPrimaryKeys.forEach(function(element){ diff --git a/core/js/tests/specs/setupchecksSpec.js b/core/js/tests/specs/setupchecksSpec.js index 9cba013bb87..d48f92d5dc3 100644 --- a/core/js/tests/specs/setupchecksSpec.js +++ b/core/js/tests/specs/setupchecksSpec.js @@ -229,7 +229,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -281,7 +280,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -333,7 +331,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -385,7 +382,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -435,7 +431,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -488,7 +483,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: false, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -539,7 +533,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -621,7 +614,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -678,7 +670,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: ['recommendation1', 'recommendation2'], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -728,7 +719,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -782,7 +772,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -833,7 +822,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -881,7 +869,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -932,7 +919,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -983,7 +969,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -1033,7 +1018,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { @@ -1090,7 +1074,6 @@ describe('OC.SetupChecks tests', function() { hasPassedCodeIntegrityCheck: true, OpcacheSetupRecommendations: [], isSettimelimitAvailable: true, - missingIndexes: [], missingPrimaryKeys: [], cronErrors: [], cronInfo: { |