diff options
| author | provokateurin <kate@provokateurin.de> | 2024-11-15 14:25:51 +0100 |
|---|---|---|
| committer | provokateurin <kate@provokateurin.de> | 2024-11-25 10:29:19 +0100 |
| commit | cc8e69c303294131f1e411629ea6866e94ea26e5 (patch) | |
| tree | 8925603a3b193a456664d27c41d15fd76235ae25 /lib/private/OCM/OCMDiscoveryService.php | |
| parent | c0c6581dd0e1abb2b210cf51424d3e355dbd401a (diff) | |
| download | nextcloud-server-cc8e69c303294131f1e411629ea6866e94ea26e5.tar.gz nextcloud-server-cc8e69c303294131f1e411629ea6866e94ea26e5.zip | |
fix(OCMDiscoveryService): Also cache error results during discoveryfix/ocmdiscoveryservice/cache-errors
Signed-off-by: provokateurin <kate@provokateurin.de>
Diffstat (limited to 'lib/private/OCM/OCMDiscoveryService.php')
| -rw-r--r-- | lib/private/OCM/OCMDiscoveryService.php | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/lib/private/OCM/OCMDiscoveryService.php b/lib/private/OCM/OCMDiscoveryService.php index 279162c76f2..203df4bbf9b 100644 --- a/lib/private/OCM/OCMDiscoveryService.php +++ b/lib/private/OCM/OCMDiscoveryService.php @@ -55,7 +55,12 @@ class OCMDiscoveryService implements IOCMDiscoveryService { if (!$skipCache) { try { - $this->provider->import(json_decode($this->cache->get($remote) ?? '', true, 8, JSON_THROW_ON_ERROR) ?? []); + $cached = $this->cache->get($remote); + if ($cached === false) { + throw new OCMProviderException('Previous discovery failed.'); + } + + $this->provider->import(json_decode($cached ?? '', true, 8, JSON_THROW_ON_ERROR) ?? []); if ($this->supportedAPIVersion($this->provider->getApiVersion())) { return $this->provider; // if cache looks valid, we use it } @@ -85,8 +90,10 @@ class OCMDiscoveryService implements IOCMDiscoveryService { $this->cache->set($remote, $body, 60 * 60 * 24); } } catch (JsonException|OCMProviderException $e) { + $this->cache->set($remote, false, 5 * 60); throw new OCMProviderException('data returned by remote seems invalid - ' . ($body ?? '')); } catch (\Exception $e) { + $this->cache->set($remote, false, 5 * 60); $this->logger->warning('error while discovering ocm provider', [ 'exception' => $e, 'remote' => $remote @@ -95,6 +102,7 @@ class OCMDiscoveryService implements IOCMDiscoveryService { } if (!$this->supportedAPIVersion($this->provider->getApiVersion())) { + $this->cache->set($remote, false, 5 * 60); throw new OCMProviderException('API version not supported'); } |