fix(setupcheck): Catch Throwables from setup checks and show them to the admin

This avoids letting a buggy setup check from an application crash the
 setupcheck system. The throwable is shown instead.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

1 files changed, 6 insertions, 1 deletions

diff --git a/lib/private/SetupCheck/SetupCheckManager.php b/lib/private/SetupCheck/SetupCheckManager.php
index b8b6cfa11e7..fbf57d81fd3 100644
--- a/lib/private/SetupCheck/SetupCheckManager.php
+++ b/lib/private/SetupCheck/SetupCheckManager.php
@@ -30,6 +30,7 @@ use OC\AppFramework\Bootstrap\Coordinator;
 use OCP\Server;
 use OCP\SetupCheck\ISetupCheck;
 use OCP\SetupCheck\ISetupCheckManager;
+use OCP\SetupCheck\SetupResult;
 use Psr\Log\LoggerInterface;
 
 class SetupCheckManager implements ISetupCheckManager {
@@ -46,7 +47,11 @@ class SetupCheckManager implements ISetupCheckManager {
 			/** @var ISetupCheck $setupCheckObject */
 			$setupCheckObject = Server::get($setupCheck->getService());
 			$this->logger->debug('Running check '.get_class($setupCheckObject));
-			$setupResult = $setupCheckObject->run();
+			try {
+				$setupResult = $setupCheckObject->run();
+			} catch (\Throwable $t) {
+				$setupResult = SetupResult::error("An exception occured while running the setup check:\n$t");
+			}
 			$setupResult->setName($setupCheckObject->getName());
 			$category = $setupCheckObject->getCategory();
 			$results[$category] ??= [];