diff options
author | Morris Jobke <hey@morrisjobke.de> | 2020-09-16 15:53:51 +0200 |
---|---|---|
committer | Morris Jobke <hey@morrisjobke.de> | 2020-09-16 15:53:56 +0200 |
commit | 99c9423766a01feff5f9fd6ef67153d45158dcd7 (patch) | |
tree | 87ef47f14f65440e5541f28caba7b5431cbb9bad /lib/private | |
parent | 04a3580d19ae505efd0ac31e4c419bf5dd701563 (diff) | |
download | nextcloud-server-99c9423766a01feff5f9fd6ef67153d45158dcd7.tar.gz nextcloud-server-99c9423766a01feff5f9fd6ef67153d45158dcd7.zip |
Remove @suppress SqlInjectionChecker
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Diffstat (limited to 'lib/private')
-rw-r--r-- | lib/private/BackgroundJob/JobList.php | 2 | ||||
-rw-r--r-- | lib/private/Comments/Manager.php | 3 | ||||
-rw-r--r-- | lib/private/DB/Adapter.php | 3 | ||||
-rw-r--r-- | lib/private/DB/AdapterPgSql.php | 3 | ||||
-rw-r--r-- | lib/private/DB/Connection.php | 1 | ||||
-rw-r--r-- | lib/private/Files/Cache/Cache.php | 3 | ||||
-rw-r--r-- | lib/private/Files/Cache/Propagator.php | 2 | ||||
-rw-r--r-- | lib/private/Files/Config/UserMountCache.php | 1 | ||||
-rw-r--r-- | lib/private/Lock/DBLockingProvider.php | 4 | ||||
-rw-r--r-- | lib/private/Repair/CleanTags.php | 1 | ||||
-rw-r--r-- | lib/private/Repair/OldGroupMembershipShares.php | 1 | ||||
-rw-r--r-- | lib/private/Repair/RepairInvalidShares.php | 1 | ||||
-rw-r--r-- | lib/private/Security/Bruteforce/Throttler.php | 1 | ||||
-rw-r--r-- | lib/private/Setup/PostgreSQL.php | 1 |
14 files changed, 0 insertions, 27 deletions
diff --git a/lib/private/BackgroundJob/JobList.php b/lib/private/BackgroundJob/JobList.php index d9d80374cfd..37aecd61693 100644 --- a/lib/private/BackgroundJob/JobList.php +++ b/lib/private/BackgroundJob/JobList.php @@ -180,7 +180,6 @@ class JobList implements IJobList { * get the next job in the list * * @return IJob|null - * @suppress SqlInjectionChecker */ public function getNext() { $query = $this->connection->getQueryBuilder(); @@ -300,7 +299,6 @@ class JobList implements IJobList { * Remove the reservation for a job * * @param IJob $job - * @suppress SqlInjectionChecker */ public function unlockJob(IJob $job) { $query = $this->connection->getQueryBuilder(); diff --git a/lib/private/Comments/Manager.php b/lib/private/Comments/Manager.php index a0a670817f4..1acfe79824c 100644 --- a/lib/private/Comments/Manager.php +++ b/lib/private/Comments/Manager.php @@ -594,8 +594,6 @@ class Manager implements ICommentsManager { * @param int $folderId * @param IUser $user * @return array [$fileId => $unreadCount] - * - * @suppress SqlInjectionChecker */ public function getNumberOfUnreadCommentsForFolder($folderId, IUser $user) { $qb = $this->dbConn->getQueryBuilder(); @@ -935,7 +933,6 @@ class Manager implements ICommentsManager { * @param \DateTime $dateTime * @param IUser $user * @since 9.0.0 - * @suppress SqlInjectionChecker */ public function setReadMark($objectType, $objectId, \DateTime $dateTime, IUser $user) { $this->checkRoleParameters('Object', $objectType, $objectId); diff --git a/lib/private/DB/Adapter.php b/lib/private/DB/Adapter.php index f27a90dd690..562fea25f5c 100644 --- a/lib/private/DB/Adapter.php +++ b/lib/private/DB/Adapter.php @@ -130,9 +130,6 @@ class Adapter { } } - /** - * @suppress SqlInjectionChecker - */ public function insertIgnoreConflict(string $table,array $values) : int { try { $builder = $this->conn->getQueryBuilder(); diff --git a/lib/private/DB/AdapterPgSql.php b/lib/private/DB/AdapterPgSql.php index 7f7f5150780..77f0b6b7722 100644 --- a/lib/private/DB/AdapterPgSql.php +++ b/lib/private/DB/AdapterPgSql.php @@ -41,9 +41,6 @@ class AdapterPgSql extends Adapter { return $statement; } - /** - * @suppress SqlInjectionChecker - */ public function insertIgnoreConflict(string $table,array $values) : int { if ($this->isPre9_5CompatMode() === true) { return parent::insertIgnoreConflict($table, $values); diff --git a/lib/private/DB/Connection.php b/lib/private/DB/Connection.php index 3b24703d434..c5766dcd7e0 100644 --- a/lib/private/DB/Connection.php +++ b/lib/private/DB/Connection.php @@ -279,7 +279,6 @@ class Connection extends ReconnectWrapper implements IDBConnection { * @return int number of new rows * @throws \Doctrine\DBAL\DBALException * @throws PreConditionNotMetException - * @suppress SqlInjectionChecker */ public function setValues($table, array $keys, array $values, array $updatePreconditionValues = []) { try { diff --git a/lib/private/Files/Cache/Cache.php b/lib/private/Files/Cache/Cache.php index 77289e674b3..8a173f35197 100644 --- a/lib/private/Files/Cache/Cache.php +++ b/lib/private/Files/Cache/Cache.php @@ -254,8 +254,6 @@ class Cache implements ICache { * * @return int file id * @throws \RuntimeException - * - * @suppress SqlInjectionChecker */ public function insert($file, array $data) { // normalize file @@ -613,7 +611,6 @@ class Cache implements ICache { * @param string $targetPath * @throws \OC\DatabaseException * @throws \Exception if the given storages have an invalid id - * @suppress SqlInjectionChecker */ public function moveFromCache(ICache $sourceCache, $sourcePath, $targetPath) { if ($sourceCache instanceof Cache) { diff --git a/lib/private/Files/Cache/Propagator.php b/lib/private/Files/Cache/Propagator.php index 92fa6436548..c9200d33b11 100644 --- a/lib/private/Files/Cache/Propagator.php +++ b/lib/private/Files/Cache/Propagator.php @@ -63,7 +63,6 @@ class Propagator implements IPropagator { * @param string $internalPath * @param int $time * @param int $sizeDifference number of bytes the file has grown - * @suppress SqlInjectionChecker */ public function propagateChange($internalPath, $time, $sizeDifference = 0) { // Do not propogate changes in ignored paths @@ -156,7 +155,6 @@ class Propagator implements IPropagator { /** * Commit the active propagation batch - * @suppress SqlInjectionChecker */ public function commitBatch() { if (!$this->inBatch) { diff --git a/lib/private/Files/Config/UserMountCache.php b/lib/private/Files/Config/UserMountCache.php index 0dc3e5d4529..6fa9cd96bfe 100644 --- a/lib/private/Files/Config/UserMountCache.php +++ b/lib/private/Files/Config/UserMountCache.php @@ -375,7 +375,6 @@ class UserMountCache implements IUserMountCache { /** * @param array $users * @return array - * @suppress SqlInjectionChecker */ public function getUsedSpaceForUsers(array $users) { $builder = $this->connection->getQueryBuilder(); diff --git a/lib/private/Lock/DBLockingProvider.php b/lib/private/Lock/DBLockingProvider.php index f48bf57028f..2ad7c162f36 100644 --- a/lib/private/Lock/DBLockingProvider.php +++ b/lib/private/Lock/DBLockingProvider.php @@ -216,8 +216,6 @@ class DBLockingProvider extends AbstractLockingProvider { /** * @param string $path * @param int $type self::LOCK_SHARED or self::LOCK_EXCLUSIVE - * - * @suppress SqlInjectionChecker */ public function releaseLock(string $path, int $type) { $this->markRelease($path, $type); @@ -288,8 +286,6 @@ class DBLockingProvider extends AbstractLockingProvider { /** * release all lock acquired by this instance which were marked using the mark* methods - * - * @suppress SqlInjectionChecker */ public function releaseAll() { parent::releaseAll(); diff --git a/lib/private/Repair/CleanTags.php b/lib/private/Repair/CleanTags.php index 959eb50e5a7..f414ef09efc 100644 --- a/lib/private/Repair/CleanTags.php +++ b/lib/private/Repair/CleanTags.php @@ -171,7 +171,6 @@ class CleanTags implements IRepairStep { * @param string $sourceId * @param string $sourceNullColumn If this column is null in the source table, * the entry is deleted in the $deleteTable - * @suppress SqlInjectionChecker */ protected function deleteOrphanEntries(IOutput $output, $repairInfo, $deleteTable, $deleteId, $sourceTable, $sourceId, $sourceNullColumn) { $qb = $this->connection->getQueryBuilder(); diff --git a/lib/private/Repair/OldGroupMembershipShares.php b/lib/private/Repair/OldGroupMembershipShares.php index 2b2fd9cd470..38254188221 100644 --- a/lib/private/Repair/OldGroupMembershipShares.php +++ b/lib/private/Repair/OldGroupMembershipShares.php @@ -66,7 +66,6 @@ class OldGroupMembershipShares implements IRepairStep { * Must throw exception on error. * * @throws \Exception in case of failure - * @suppress SqlInjectionChecker */ public function run(IOutput $output) { $deletedEntries = 0; diff --git a/lib/private/Repair/RepairInvalidShares.php b/lib/private/Repair/RepairInvalidShares.php index 27defdeda01..1fc98a1d466 100644 --- a/lib/private/Repair/RepairInvalidShares.php +++ b/lib/private/Repair/RepairInvalidShares.php @@ -56,7 +56,6 @@ class RepairInvalidShares implements IRepairStep { /** * Adjust file share permissions - * @suppress SqlInjectionChecker */ private function adjustFileSharePermissions(IOutput $out) { $mask = \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_SHARE; diff --git a/lib/private/Security/Bruteforce/Throttler.php b/lib/private/Security/Bruteforce/Throttler.php index 61e18088e94..01c0e02ef8f 100644 --- a/lib/private/Security/Bruteforce/Throttler.php +++ b/lib/private/Security/Bruteforce/Throttler.php @@ -115,7 +115,6 @@ class Throttler { * @param string $action * @param string $ip * @param array $metadata Optional metadata logged to the database - * @suppress SqlInjectionChecker */ public function registerAttempt(string $action, string $ip, diff --git a/lib/private/Setup/PostgreSQL.php b/lib/private/Setup/PostgreSQL.php index 17ae991a1de..3d7a0b2a4b1 100644 --- a/lib/private/Setup/PostgreSQL.php +++ b/lib/private/Setup/PostgreSQL.php @@ -39,7 +39,6 @@ class PostgreSQL extends AbstractDatabase { /** * @param string $username * @throws \OC\DatabaseSetupException - * @suppress SqlInjectionChecker */ public function setupDatabase($username) { try { |