diff options
| author | Philipp Schaffrath <github@philipp.schaffrath.email> | 2017-01-10 12:10:36 +0100 |
|---|---|---|
| committer | Morris Jobke <hey@morrisjobke.de> | 2017-03-17 00:09:07 -0600 |
| commit | 2ccf544ad7c8bfc54600adb065156f04a8912c9f (patch) | |
| tree | 02e8efd96ba96be842ec092bbfa2c80c9873ec7f /tests/lib/DB/ConnectionTest.php | |
| parent | 39afcbd49feb4ba333746762fe7c9d4701db9860 (diff) | |
| download | nextcloud-server-2ccf544ad7c8bfc54600adb065156f04a8912c9f.tar.gz nextcloud-server-2ccf544ad7c8bfc54600adb065156f04a8912c9f.zip | |
Fixed failing test which was ignoring a required (not null) column (#26303)
* Fixed failing test which was ignoring a required (not null) column
* restored test to original, catching DriverException which also catches ConstraintViolationException
* catch ConstraintViolationException again
* removed unnecessary field from this test
* clobfield should be nullable
* clobfield now is nullable
* removed autoincrement since whenever this strategy is enabled, oracle would not throw constraint violation exceptions (needed for setValues), which mysql still does
* this field does not auto increment anymore
* mark integerfield as primary, since it is not getting marked as such through auto increment anymore,
integerfield default always has been 0 instead of null
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Diffstat (limited to 'tests/lib/DB/ConnectionTest.php')
| -rw-r--r-- | tests/lib/DB/ConnectionTest.php | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tests/lib/DB/ConnectionTest.php b/tests/lib/DB/ConnectionTest.php index b9c55c23339..2a0cd70f83a 100644 --- a/tests/lib/DB/ConnectionTest.php +++ b/tests/lib/DB/ConnectionTest.php @@ -124,8 +124,7 @@ class ConnectionTest extends \Test\TestCase { $this->connection->setValues('table', [ 'integerfield' => 1 ], [ - 'textfield' => 'foo', - 'clobfield' => 'not_null' + 'textfield' => 'foo' ]); $this->connection->setValues('table', [ |