diff options
author | Robin Appelman <robin@icewind.nl> | 2019-09-25 18:07:32 +0200 |
---|---|---|
committer | Robin Appelman <robin@icewind.nl> | 2019-09-25 18:09:45 +0200 |
commit | 733d4b6ccaeec30f931c23614b98013a1b2f674e (patch) | |
tree | 8df42f94e91c53423fbd301d911efb71d231b651 /tests | |
parent | 507eb30e1d7ab2ea31934796621cd6614c2af750 (diff) | |
download | nextcloud-server-733d4b6ccaeec30f931c23614b98013a1b2f674e.tar.gz nextcloud-server-733d4b6ccaeec30f931c23614b98013a1b2f674e.zip |
dont delete cache entries if deleting an object from object store failed
Signed-off-by: Robin Appelman <robin@icewind.nl>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/lib/Files/ObjectStore/FailDeleteObjectStore.php | 54 | ||||
-rw-r--r-- | tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php | 25 |
2 files changed, 79 insertions, 0 deletions
diff --git a/tests/lib/Files/ObjectStore/FailDeleteObjectStore.php b/tests/lib/Files/ObjectStore/FailDeleteObjectStore.php new file mode 100644 index 00000000000..4ad3798a467 --- /dev/null +++ b/tests/lib/Files/ObjectStore/FailDeleteObjectStore.php @@ -0,0 +1,54 @@ +<?php declare(strict_types=1); +/** + * @copyright Copyright (c) 2019 Robin Appelman <robin@icewind.nl> + * + * @license GNU AGPL version 3 or any later version + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +namespace Test\Files\ObjectStore; + + +use OCP\Files\ObjectStore\IObjectStore; + +class FailDeleteObjectStore implements IObjectStore { + private $objectStore; + + public function __construct(IObjectStore $objectStore) { + $this->objectStore = $objectStore; + } + + public function getStorageId() { + return $this->objectStore->getStorageId(); + } + + public function readObject($urn) { + return $this->objectStore->readObject($urn); + } + + public function writeObject($urn, $stream) { + return $this->objectStore->writeObject($urn, $stream); + } + + public function deleteObject($urn) { + throw new \Exception(); + } + + public function objectExists($urn) { + return $this->objectStore->objectExists($urn); + } +} + diff --git a/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php b/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php index 3b3827f460a..ce9c9d2cd69 100644 --- a/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php +++ b/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php @@ -181,4 +181,29 @@ class ObjectStoreStorageTest extends Storage { } $this->assertFalse($this->instance->file_exists('test.txt')); } + + public function testDeleteObjectFailureKeepCache() { + $objectStore = $this->instance->getObjectStore(); + $this->instance->setObjectStore(new FailDeleteObjectStore($objectStore)); + $cache = $this->instance->getCache(); + + $this->instance->file_put_contents('test.txt', 'foo'); + + $this->assertTrue($cache->inCache('test.txt')); + + $this->assertFalse($this->instance->unlink('test.txt')); + + $this->assertTrue($cache->inCache('test.txt')); + + $this->instance->mkdir('foo'); + $this->instance->file_put_contents('foo/test.txt', 'foo'); + + $this->assertTrue($cache->inCache('foo')); + $this->assertTrue($cache->inCache('foo/test.txt')); + + $this->instance->rmdir('foo'); + + $this->assertTrue($cache->inCache('foo')); + $this->assertTrue($cache->inCache('foo/test.txt')); + } } |