diff options
| author | Ferdinand Thiessen <opensource@fthiessen.de> | 2025-02-23 19:24:04 +0100 |
|---|---|---|
| committer | skjnldsv <skjnldsv@protonmail.com> | 2025-02-27 12:59:09 +0100 |
| commit | fb714dfd403e2fcab88a8db13f101e02720ba960 (patch) | |
| tree | 8b43a2a34f0c98b6cb59a78846dc5949ac939905 /tests | |
| parent | 62d122adfa8ade3f5fdb7888f5d40f7c023e4feb (diff) | |
| download | nextcloud-server-fb714dfd403e2fcab88a8db13f101e02720ba960.tar.gz nextcloud-server-fb714dfd403e2fcab88a8db13f101e02720ba960.zip | |
fix: Optimize repair step performance
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/lib/Repair/NC29/ValidateAccountPropertiesTest.php | 27 |
1 files changed, 26 insertions, 1 deletions
diff --git a/tests/lib/Repair/NC29/ValidateAccountPropertiesTest.php b/tests/lib/Repair/NC29/ValidateAccountPropertiesTest.php index cc43a63ca19..e113f180998 100644 --- a/tests/lib/Repair/NC29/ValidateAccountPropertiesTest.php +++ b/tests/lib/Repair/NC29/ValidateAccountPropertiesTest.php @@ -43,6 +43,7 @@ class ValidateAccountPropertiesTest extends TestCase { $users = [ $this->createMock(IUser::class), $this->createMock(IUser::class), + $this->createMock(IUser::class), ]; $this->userManager ->expects(self::once()) @@ -61,15 +62,39 @@ class ValidateAccountPropertiesTest extends TestCase { $account1->expects(self::once()) ->method('setProperty') ->with(IAccountManager::PROPERTY_PHONE, '', IAccountManager::SCOPE_LOCAL, IAccountManager::NOT_VERIFIED); + $account1->expects(self::once()) + ->method('jsonSerialize') + ->willReturn([ + IAccountManager::PROPERTY_DISPLAYNAME => [], + IAccountManager::PROPERTY_PHONE => [], + ]); + $account2 = $this->createMock(IAccount::class); $account2->expects(self::never()) ->method('getProperty'); + $account2->expects(self::once()) + ->method('jsonSerialize') + ->willReturn([ + IAccountManager::PROPERTY_DISPLAYNAME => [], + IAccountManager::PROPERTY_PHONE => [], + ]); + + $account3 = $this->createMock(IAccount::class); + $account3->expects(self::never()) + ->method('getProperty'); + $account3->expects(self::once()) + ->method('jsonSerialize') + ->willReturn([ + IAccountManager::PROPERTY_DISPLAYNAME => [], + ]); + $this->accountManager - ->expects(self::exactly(2)) + ->expects(self::exactly(3)) ->method('getAccount') ->willReturnMap([ [$users[0], $account1], [$users[1], $account2], + [$users[2], $account3], ]); $valid = false; $this->accountManager->expects(self::exactly(3)) |