1 files changed, 11 insertions, 27 deletions

diff --git a/apps/encryption/lib/Command/RecoverUser.php b/apps/encryption/lib/Command/RecoverUser.php
index fcdc3f15fb5..8da962ac8b1 100644
--- a/apps/encryption/lib/Command/RecoverUser.php
+++ b/apps/encryption/lib/Command/RecoverUser.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
@@ -16,33 +17,16 @@ use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\Question;
 
 class RecoverUser extends Command {
-
-	/** @var Util */
-	protected $util;
-
-	/** @var IUserManager */
-	protected $userManager;
-
-	/** @var  QuestionHelper */
-	protected $questionHelper;
-
-	/**
-	 * @param Util $util
-	 * @param IConfig $config
-	 * @param IUserManager $userManager
-	 * @param QuestionHelper $questionHelper
-	 */
-	public function __construct(Util $util,
+	public function __construct(
+		protected Util $util,
 		IConfig $config,
-		IUserManager $userManager,
-		QuestionHelper $questionHelper) {
-		$this->util = $util;
-		$this->questionHelper = $questionHelper;
-		$this->userManager = $userManager;
+		protected IUserManager $userManager,
+		protected QuestionHelper $questionHelper,
+	) {
 		parent::__construct();
 	}
 
-	protected function configure() {
+	protected function configure(): void {
 		$this
 			->setName('encryption:recover-user')
 			->setDescription('Recover user data in case of password lost. This only works if the user enabled the recovery key.');
@@ -59,20 +43,20 @@ class RecoverUser extends Command {
 
 		if ($isMasterKeyEnabled) {
 			$output->writeln('You use the master key, no individual user recovery needed.');
-			return 0;
+			return self::SUCCESS;
 		}
 
 		$uid = $input->getArgument('user');
 		$userExists = $this->userManager->userExists($uid);
 		if ($userExists === false) {
 			$output->writeln('User "' . $uid . '" unknown.');
-			return 1;
+			return self::FAILURE;
 		}
 
 		$recoveryKeyEnabled = $this->util->isRecoveryEnabledForUser($uid);
 		if ($recoveryKeyEnabled === false) {
 			$output->writeln('Recovery key is not enabled for: ' . $uid);
-			return 1;
+			return self::FAILURE;
 		}
 
 		$question = new Question('Please enter the recovery key password: ');
@@ -88,6 +72,6 @@ class RecoverUser extends Command {
 		$output->write('Start to recover users files... This can take some time...');
 		$this->userManager->get($uid)->setPassword($newLoginPassword, $recoveryPassword);
 		$output->writeln('Done.');
-		return 0;
+		return self::SUCCESS;
 	}
 }