1 files changed, 42 insertions, 94 deletions

diff --git a/apps/files/tests/HelperTest.php b/apps/files/tests/HelperTest.php
index 34d01bd7bcc..ba93fa0efdf 100644
--- a/apps/files/tests/HelperTest.php
+++ b/apps/files/tests/HelperTest.php
@@ -1,49 +1,28 @@
 <?php
+
+declare(strict_types=1);
 /**
- * @copyright Copyright (c) 2016, ownCloud, Inc.
- *
- * @author brumsel <brumsel@losecatcher.de>
- * @author Joas Schilling <coding@schilljs.com>
- * @author Morris Jobke <hey@morrisjobke.de>
- * @author Robin Appelman <robin@icewind.nl>
- * @author Roeland Jago Douma <roeland@famdouma.nl>
- * @author Vincent Petry <pvince81@owncloud.com>
- *
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *
+ * SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
+ * SPDX-License-Identifier: AGPL-3.0-only
  */
 
-use OCA\Files\Tests;
+use OC\Files\FileInfo;
+use OCA\Files\Helper;
 
-/**
- * Class Helper
- */
 class HelperTest extends \Test\TestCase {
-
-	private function makeFileInfo($name, $size, $mtime, $isDir = false) {
-		return new \OC\Files\FileInfo(
+	private static function makeFileInfo($name, $size, $mtime, $isDir = false): FileInfo {
+		return new FileInfo(
 			'/' . $name,
 			null,
 			'/',
-			array(
+			[
 				'name' => $name,
 				'size' => $size,
 				'mtime' => $mtime,
 				'type' => $isDir ? 'dir' : 'file',
 				'mimetype' => $isDir ? 'httpd/unix-directory' : 'application/octet-stream'
-			),
+			],
 			null
 		);
 	}
@@ -51,59 +30,60 @@ class HelperTest extends \Test\TestCase {
 	/**
 	 * Returns a file list for testing
 	 */
-	private function getTestFileList() {
-		return array(
+	private static function getTestFileList(): array {
+		return [
 			self::makeFileInfo('a.txt', 4, 2.3 * pow(10, 9)),
 			self::makeFileInfo('q.txt', 5, 150),
 			self::makeFileInfo('subdir2', 87, 128, true),
 			self::makeFileInfo('b.txt', 2.2 * pow(10, 9), 800),
 			self::makeFileInfo('o.txt', 12, 100),
 			self::makeFileInfo('subdir', 88, 125, true),
-		);
+		];
 	}
 
-	function sortDataProvider() {
-		return array(
-			array(
+	public static function sortDataProvider(): array {
+		return [
+			[
 				'name',
 				false,
-				array('subdir', 'subdir2', 'a.txt', 'b.txt', 'o.txt', 'q.txt'),
-			),
-			array(
+				['subdir', 'subdir2', 'a.txt', 'b.txt', 'o.txt', 'q.txt'],
+			],
+			[
 				'name',
 				true,
-				array('q.txt', 'o.txt', 'b.txt', 'a.txt', 'subdir2', 'subdir'),
-			),
-			array(
+				['q.txt', 'o.txt', 'b.txt', 'a.txt', 'subdir2', 'subdir'],
+			],
+			[
 				'size',
 				false,
-				array('a.txt', 'q.txt', 'o.txt', 'subdir2', 'subdir', 'b.txt'),
-			),
-			array(
+				['a.txt', 'q.txt', 'o.txt', 'subdir2', 'subdir', 'b.txt'],
+			],
+			[
 				'size',
 				true,
-				array('b.txt', 'subdir', 'subdir2', 'o.txt', 'q.txt', 'a.txt'),
-			),
-			array(
+				['b.txt', 'subdir', 'subdir2', 'o.txt', 'q.txt', 'a.txt'],
+			],
+			[
 				'mtime',
 				false,
-				array('o.txt', 'subdir', 'subdir2', 'q.txt', 'b.txt', 'a.txt'),
-			),
-			array(
+				['o.txt', 'subdir', 'subdir2', 'q.txt', 'b.txt', 'a.txt'],
+			],
+			[
 				'mtime',
 				true,
-				array('a.txt', 'b.txt', 'q.txt', 'subdir2', 'subdir', 'o.txt'),
-			),
-		);
+				['a.txt', 'b.txt', 'q.txt', 'subdir2', 'subdir', 'o.txt'],
+			],
+		];
 	}
 
-	/**
-	 * @dataProvider sortDataProvider
-	 */
-	public function testSortByName($sort, $sortDescending, $expectedOrder) {
+	#[\PHPUnit\Framework\Attributes\DataProvider('sortDataProvider')]
+	public function testSortByName(string $sort, bool $sortDescending, array $expectedOrder): void {
+		if (($sort === 'mtime') && (PHP_INT_SIZE < 8)) {
+			$this->markTestSkipped('Skip mtime sorting on 32bit');
+		}
 		$files = self::getTestFileList();
-		$files = \OCA\Files\Helper::sortFiles($files, $sort, $sortDescending);
-		$fileNames = array();
+		$files = Helper::sortFiles($files, $sort, $sortDescending);
+		$fileNames = [];
 		foreach ($files as $fileInfo) {
 			$fileNames[] = $fileInfo->getName();
 		}
@@ -112,36 +92,4 @@ class HelperTest extends \Test\TestCase {
 			$fileNames
 		);
 	}
-
-	public function testPopulateTags() {
-		$tagManager = $this->createMock(\OCP\ITagManager::class);
-		$tagger = $this->createMock(\OCP\ITags::class);
-
-		$tagManager->method('load')
-			->with('files')
-			->willReturn($tagger);
-
-		$data = [
-			['id' => 10],
-			['id' => 22, 'foo' => 'bar'],
-			['id' => 42, 'x' => 'y'],
-		];
-
-		$tags = [
-			10 => ['tag3'],
-			42 => ['tag1', 'tag2'],
-		];
-
-		$tagger->method('getTagsForObjects')
-			->with([10, 22, 42])
-			->willReturn($tags);
-
-		$result = \OCA\Files\Helper::populateTags($data, 'id', $tagManager);
-
-		$this->assertSame([
-			['id' => 10, 'tags' => ['tag3']],
-			['id' => 22, 'foo' => 'bar', 'tags' => []],
-			['id' => 42, 'x' => 'y', 'tags' => ['tag1', 'tag2']],
-		], $result);
-	}
 }