aboutsummaryrefslogtreecommitdiffstats
path: root/apps/files_external/lib/Command/Create.php
diff options
context:
space:
mode:
Diffstat (limited to 'apps/files_external/lib/Command/Create.php')
-rw-r--r--apps/files_external/lib/Command/Create.php112
1 files changed, 36 insertions, 76 deletions
diff --git a/apps/files_external/lib/Command/Create.php b/apps/files_external/lib/Command/Create.php
index 2b1ac7af3db..3307015518a 100644
--- a/apps/files_external/lib/Command/Create.php
+++ b/apps/files_external/lib/Command/Create.php
@@ -1,27 +1,10 @@
<?php
+
/**
- * @copyright Copyright (c) 2016, ownCloud, Inc.
- *
- * @author Joas Schilling <coding@schilljs.com>
- * @author Robin Appelman <robin@icewind.nl>
- * @author Roeland Jago Douma <roeland@famdouma.nl>
- *
- * @license AGPL-3.0
- *
- * This code is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License, version 3,
- * as published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License, version 3,
- * along with this program. If not, see <http://www.gnu.org/licenses/>
- *
+ * SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
+ * SPDX-License-Identifier: AGPL-3.0-only
*/
-
namespace OCA\Files_External\Command;
use OC\Core\Command\Base;
@@ -33,7 +16,9 @@ use OCA\Files_External\Lib\DefinitionParameter;
use OCA\Files_External\Lib\StorageConfig;
use OCA\Files_External\Service\BackendService;
use OCA\Files_External\Service\GlobalStoragesService;
+use OCA\Files_External\Service\StoragesService;
use OCA\Files_External\Service\UserStoragesService;
+use OCP\AppFramework\Http;
use OCP\IUserManager;
use OCP\IUserSession;
use Symfony\Component\Console\Input\ArrayInput;
@@ -43,42 +28,17 @@ use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
class Create extends Base {
- /**
- * @var GlobalStoragesService
- */
- private $globalService;
-
- /**
- * @var UserStoragesService
- */
- private $userService;
-
- /**
- * @var IUserManager
- */
- private $userManager;
-
- /** @var BackendService */
- private $backendService;
-
- /** @var IUserSession */
- private $userSession;
-
- function __construct(GlobalStoragesService $globalService,
- UserStoragesService $userService,
- IUserManager $userManager,
- IUserSession $userSession,
- BackendService $backendService
+ public function __construct(
+ private GlobalStoragesService $globalService,
+ private UserStoragesService $userService,
+ private IUserManager $userManager,
+ private IUserSession $userSession,
+ private BackendService $backendService,
) {
parent::__construct();
- $this->globalService = $globalService;
- $this->userService = $userService;
- $this->userManager = $userManager;
- $this->userSession = $userSession;
- $this->backendService = $backendService;
}
- protected function configure() {
+ protected function configure(): void {
$this
->setName('files_external:create')
->setDescription('Create a new mount configuration')
@@ -118,8 +78,8 @@ class Create extends Base {
parent::configure();
}
- protected function execute(InputInterface $input, OutputInterface $output) {
- $user = $input->getOption('user');
+ protected function execute(InputInterface $input, OutputInterface $output): int {
+ $user = (string)$input->getOption('user');
$mountPoint = $input->getArgument('mount_point');
$storageIdentifier = $input->getArgument('storage_backend');
$authIdentifier = $input->getArgument('authentication_backend');
@@ -130,32 +90,32 @@ class Create extends Base {
if (!Filesystem::isValidPath($mountPoint)) {
$output->writeln('<error>Invalid mountpoint "' . $mountPoint . '"</error>');
- return 1;
+ return self::FAILURE;
}
if (is_null($storageBackend)) {
$output->writeln('<error>Storage backend with identifier "' . $storageIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
- return 404;
+ return Http::STATUS_NOT_FOUND;
}
if (is_null($authBackend)) {
$output->writeln('<error>Authentication backend with identifier "' . $authIdentifier . '" not found (see `occ files_external:backends` for possible values)</error>');
- return 404;
+ return Http::STATUS_NOT_FOUND;
}
$supportedSchemes = array_keys($storageBackend->getAuthSchemes());
if (!in_array($authBackend->getScheme(), $supportedSchemes)) {
$output->writeln('<error>Authentication backend "' . $authIdentifier . '" not valid for storage backend "' . $storageIdentifier . '" (see `occ files_external:backends storage ' . $storageIdentifier . '` for possible values)</error>');
- return 1;
+ return self::FAILURE;
}
$config = [];
foreach ($configInput as $configOption) {
- if (!strpos($configOption, '=')) {
+ if (!str_contains($configOption, '=')) {
$output->writeln('<error>Invalid mount configuration option "' . $configOption . '"</error>');
- return 1;
+ return self::FAILURE;
}
- list($key, $value) = explode('=', $configOption, 2);
+ [$key, $value] = explode('=', $configOption, 2);
if (!$this->validateParam($key, $value, $storageBackend, $authBackend)) {
$output->writeln('<error>Unknown configuration for backends "' . $key . '"</error>');
- return 1;
+ return self::FAILURE;
}
$config[$key] = $value;
}
@@ -169,7 +129,7 @@ class Create extends Base {
if ($user) {
if (!$this->userManager->userExists($user)) {
$output->writeln('<error>User "' . $user . '" not found</error>');
- return 1;
+ return self::FAILURE;
}
$mount->setApplicableUsers([$user]);
}
@@ -184,10 +144,10 @@ class Create extends Base {
$output->writeln((string)$mount->getId());
}
}
- return 0;
+ return self::SUCCESS;
}
- private function validateParam($key, &$value, Backend $storageBackend, AuthMechanism $authBackend) {
+ private function validateParam(string $key, &$value, Backend $storageBackend, AuthMechanism $authBackend): bool {
$params = array_merge($storageBackend->getParameters(), $authBackend->getParameters());
foreach ($params as $param) {
/** @var DefinitionParameter $param */
@@ -201,7 +161,7 @@ class Create extends Base {
return false;
}
- private function showMount($user, StorageConfig $mount, InputInterface $input, OutputInterface $output) {
+ private function showMount(string $user, StorageConfig $mount, InputInterface $input, OutputInterface $output): void {
$listCommand = new ListCommand($this->globalService, $this->userService, $this->userSession, $this->userManager);
$listInput = new ArrayInput([], $listCommand->getDefinition());
$listInput->setOption('output', $input->getOption('output'));
@@ -209,16 +169,16 @@ class Create extends Base {
$listCommand->listMounts($user, [$mount], $listInput, $output);
}
- protected function getStorageService($userId) {
- if (!empty($userId)) {
- $user = $this->userManager->get($userId);
- if (is_null($user)) {
- throw new NoUserException("user $userId not found");
- }
- $this->userSession->setUser($user);
- return $this->userService;
- } else {
+ protected function getStorageService(string $userId): StoragesService {
+ if (empty($userId)) {
return $this->globalService;
}
+
+ $user = $this->userManager->get($userId);
+ if (is_null($user)) {
+ throw new NoUserException("user $userId not found");
+ }
+ $this->userSession->setUser($user);
+ return $this->userService;
}
}
generated by cgit v1.2.3 (git 2.39.1) at 2025-08-15 14:13:54 +0000