1 files changed, 14 insertions, 11 deletions

diff --git a/apps/files_external/tests/Command/ApplicableTest.php b/apps/files_external/tests/Command/ApplicableTest.php
index d4caadad343..59db18a42de 100644
--- a/apps/files_external/tests/Command/ApplicableTest.php
+++ b/apps/files_external/tests/Command/ApplicableTest.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /**
  * SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2016 ownCloud, Inc.
@@ -9,12 +11,13 @@ namespace OCA\Files_External\Tests\Command;
 use OCA\Files_External\Command\Applicable;
 use OCP\IGroupManager;
 use OCP\IUserManager;
+use PHPUnit\Framework\MockObject\MockObject;
 
-class ApplicableTest extends CommandTest {
-	private function getInstance($storageService) {
-		/** @var \OCP\IUserManager|\PHPUnit\Framework\MockObject\MockObject $userManager */
+class ApplicableTest extends CommandTestCase {
+	private function getInstance($storageService): Applicable {
+		/** @var IUserManager&MockObject $userManager */
 		$userManager = $this->createMock(IUserManager::class);
-		/** @var \OCP\IGroupManager|\PHPUnit\Framework\MockObject\MockObject $groupManager */
+		/** @var IGroupManager&MockObject $groupManager */
 		$groupManager = $this->createMock(IGroupManager::class);
 
 		$userManager->expects($this->any())
@@ -28,7 +31,7 @@ class ApplicableTest extends CommandTest {
 		return new Applicable($storageService, $userManager, $groupManager);
 	}
 
-	public function testListEmpty() {
+	public function testListEmpty(): void {
 		$mount = $this->getMount(1, '', '');
 
 		$storageService = $this->getGlobalStorageService([$mount]);
@@ -45,7 +48,7 @@ class ApplicableTest extends CommandTest {
 		$this->assertEquals(['users' => [], 'groups' => []], $result);
 	}
 
-	public function testList() {
+	public function testList(): void {
 		$mount = $this->getMount(1, '', '', '', [], [], ['test', 'asd']);
 
 		$storageService = $this->getGlobalStorageService([$mount]);
@@ -62,7 +65,7 @@ class ApplicableTest extends CommandTest {
 		$this->assertEquals(['users' => ['test', 'asd'], 'groups' => []], $result);
 	}
 
-	public function testAddSingle() {
+	public function testAddSingle(): void {
 		$mount = $this->getMount(1, '', '', '', [], [], []);
 
 		$storageService = $this->getGlobalStorageService([$mount]);
@@ -80,7 +83,7 @@ class ApplicableTest extends CommandTest {
 		$this->assertEquals(['foo'], $mount->getApplicableUsers());
 	}
 
-	public function testAddDuplicate() {
+	public function testAddDuplicate(): void {
 		$mount = $this->getMount(1, '', '', '', [], [], ['foo']);
 
 		$storageService = $this->getGlobalStorageService([$mount]);
@@ -98,7 +101,7 @@ class ApplicableTest extends CommandTest {
 		$this->assertEquals(['foo', 'bar'], $mount->getApplicableUsers());
 	}
 
-	public function testRemoveSingle() {
+	public function testRemoveSingle(): void {
 		$mount = $this->getMount(1, '', '', '', [], [], ['foo', 'bar']);
 
 		$storageService = $this->getGlobalStorageService([$mount]);
@@ -116,7 +119,7 @@ class ApplicableTest extends CommandTest {
 		$this->assertEquals(['foo'], $mount->getApplicableUsers());
 	}
 
-	public function testRemoveNonExisting() {
+	public function testRemoveNonExisting(): void {
 		$mount = $this->getMount(1, '', '', '', [], [], ['foo', 'bar']);
 
 		$storageService = $this->getGlobalStorageService([$mount]);
@@ -134,7 +137,7 @@ class ApplicableTest extends CommandTest {
 		$this->assertEquals(['foo'], $mount->getApplicableUsers());
 	}
 
-	public function testRemoveAddRemove() {
+	public function testRemoveAddRemove(): void {
 		$mount = $this->getMount(1, '', '', '', [], [], ['foo', 'bar']);
 
 		$storageService = $this->getGlobalStorageService([$mount]);