diff options
Diffstat (limited to 'apps/files_trashbin/tests/Controller/PreviewControllerTest.php')
-rw-r--r-- | apps/files_trashbin/tests/Controller/PreviewControllerTest.php | 136 |
1 files changed, 71 insertions, 65 deletions
diff --git a/apps/files_trashbin/tests/Controller/PreviewControllerTest.php b/apps/files_trashbin/tests/Controller/PreviewControllerTest.php index 685e4cebfd1..bb951c9c8c7 100644 --- a/apps/files_trashbin/tests/Controller/PreviewControllerTest.php +++ b/apps/files_trashbin/tests/Controller/PreviewControllerTest.php @@ -1,98 +1,86 @@ <?php + +declare(strict_types=1); /** - * @copyright Copyright (c) 2016, Roeland Jago Douma <roeland@famdouma.nl> - * - * @author Roeland Jago Douma <roeland@famdouma.nl> - * - * @license GNU AGPL version 3 or any later version - * - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as - * published by the Free Software Foundation, either version 3 of the - * License, or (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see <http://www.gnu.org/licenses/>. - * + * SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors + * SPDX-License-Identifier: AGPL-3.0-or-later */ namespace OCA\Files_Trashbin\Tests\Controller; use OCA\Files_Trashbin\Controller\PreviewController; +use OCA\Files_Trashbin\Trash\ITrashManager; use OCP\AppFramework\Http; use OCP\AppFramework\Http\DataResponse; use OCP\AppFramework\Http\FileDisplayResponse; +use OCP\AppFramework\Utility\ITimeFactory; use OCP\Files\File; use OCP\Files\Folder; use OCP\Files\IMimeTypeDetector; use OCP\Files\IRootFolder; -use OCP\Files\NotFoundException; use OCP\Files\SimpleFS\ISimpleFile; use OCP\IPreview; use OCP\IRequest; +use OCP\IUser; +use OCP\IUserSession; +use PHPUnit\Framework\MockObject\MockObject; use Test\TestCase; class PreviewControllerTest extends TestCase { - - /** @var IRootFolder|\PHPUnit_Framework_MockObject_MockObject */ - private $rootFolder; - - /** @var string */ - private $userId; - - /** @var IMimeTypeDetector|\PHPUnit_Framework_MockObject_MockObject */ - private $mimeTypeDetector; - - /** @var IPreview|\PHPUnit_Framework_MockObject_MockObject */ - private $previewManager; - - /** @var PreviewController */ - private $controller; - - public function setUp() { + private IRootFolder&MockObject $rootFolder; + private string $userId; + private IMimeTypeDetector&MockObject $mimeTypeDetector; + private IPreview&MockObject $previewManager; + private ITimeFactory&MockObject $time; + private ITrashManager&MockObject $trashManager; + private IUserSession&MockObject $userSession; + private PreviewController $controller; + + protected function setUp(): void { parent::setUp(); $this->rootFolder = $this->createMock(IRootFolder::class); $this->userId = 'user'; $this->mimeTypeDetector = $this->createMock(IMimeTypeDetector::class); $this->previewManager = $this->createMock(IPreview::class); + $this->time = $this->createMock(ITimeFactory::class); + $this->trashManager = $this->createMock(ITrashManager::class); + $this->userSession = $this->createMock(IUserSession::class); + $user = $this->createMock(IUser::class); + $user->expects($this->any()) + ->method('getUID') + ->willReturn($this->userId); + + $this->userSession->expects($this->any()) + ->method('getUser') + ->willReturn($user); $this->controller = new PreviewController( 'files_versions', $this->createMock(IRequest::class), $this->rootFolder, - $this->userId, + $this->trashManager, + $this->userSession, $this->mimeTypeDetector, - $this->previewManager + $this->previewManager, + $this->time ); } - public function testInvalidFile() { - $res = $this->controller->getPreview(''); + public function testInvalidWidth(): void { + $res = $this->controller->getPreview(42, 0); $expected = new DataResponse([], Http::STATUS_BAD_REQUEST); $this->assertEquals($expected, $res); } - public function testInvalidWidth() { - $res = $this->controller->getPreview('file', 0); + public function testInvalidHeight(): void { + $res = $this->controller->getPreview(42, 10, 0); $expected = new DataResponse([], Http::STATUS_BAD_REQUEST); $this->assertEquals($expected, $res); } - public function testInvalidHeight() { - $res = $this->controller->getPreview('file', 10, 0); - $expected = new DataResponse([], Http::STATUS_BAD_REQUEST); - - $this->assertEquals($expected, $res); - } - - public function testValidPreview() { + public function testValidPreview(): void { $userFolder = $this->createMock(Folder::class); $userRoot = $this->createMock(Folder::class); $trash = $this->createMock(Folder::class); @@ -111,26 +99,41 @@ class PreviewControllerTest extends TestCase { ->willReturn('myMime'); $file = $this->createMock(File::class); - $trash->method('get') - ->with($this->equalTo('file.1234')) - ->willReturn($file); + $trash->method('getById') + ->with($this->equalTo(42)) + ->willReturn([$file]); $file->method('getName') - ->willReturn('file.1234'); + ->willReturn('file.d1234'); + + $file->method('getParent') + ->willReturn($trash); + + $this->trashManager->expects($this->any()) + ->method('getTrashNodeById') + ->willReturn($file); $preview = $this->createMock(ISimpleFile::class); + $preview->method('getName')->willReturn('name'); + $preview->method('getMTime')->willReturn(42); $this->previewManager->method('getPreview') ->with($this->equalTo($file), 10, 10, true, IPreview::MODE_FILL, 'myMime') ->willReturn($preview); $preview->method('getMimeType') ->willReturn('previewMime'); - $res = $this->controller->getPreview('file.1234', 10, 10); + $this->time->method('getTime') + ->willReturn(1337); + + $this->overwriteService(ITimeFactory::class, $this->time); + + $res = $this->controller->getPreview(42, 10, 10, false); $expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'previewMime']); + $expected->cacheFor(3600 * 24); $this->assertEquals($expected, $res); } - public function testTrashFileNotFound() { + public function testTrashFileNotFound(): void { $userFolder = $this->createMock(Folder::class); $userRoot = $this->createMock(Folder::class); $trash = $this->createMock(Folder::class); @@ -144,17 +147,17 @@ class PreviewControllerTest extends TestCase { ->with('files_trashbin/files') ->willReturn($trash); - $trash->method('get') - ->with($this->equalTo('file.1234')) - ->willThrowException(new NotFoundException()); + $trash->method('getById') + ->with($this->equalTo(42)) + ->willReturn([]); - $res = $this->controller->getPreview('file.1234', 10, 10); + $res = $this->controller->getPreview(42, 10, 10); $expected = new DataResponse([], Http::STATUS_NOT_FOUND); $this->assertEquals($expected, $res); } - public function testTrashFolder() { + public function testTrashFolder(): void { $userFolder = $this->createMock(Folder::class); $userRoot = $this->createMock(Folder::class); $trash = $this->createMock(Folder::class); @@ -169,11 +172,14 @@ class PreviewControllerTest extends TestCase { ->willReturn($trash); $folder = $this->createMock(Folder::class); - $trash->method('get') - ->with($this->equalTo('folder')) + $this->trashManager->expects($this->any()) + ->method('getTrashNodeById') ->willReturn($folder); + $trash->method('getById') + ->with($this->equalTo(43)) + ->willReturn([$folder]); - $res = $this->controller->getPreview('folder', 10, 10); + $res = $this->controller->getPreview(43, 10, 10); $expected = new DataResponse([], Http::STATUS_BAD_REQUEST); $this->assertEquals($expected, $res); |