1 files changed, 11 insertions, 13 deletions

diff --git a/apps/user_ldap/tests/LDAPTest.php b/apps/user_ldap/tests/LDAPTest.php
index 51ed0c2b462..6da592ad6a1 100644
--- a/apps/user_ldap/tests/LDAPTest.php
+++ b/apps/user_ldap/tests/LDAPTest.php
@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /**
  * SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
@@ -6,20 +8,20 @@
 namespace OCA\User_LDAP\Tests;
 
 use OCA\User_LDAP\LDAP;
+use PHPUnit\Framework\MockObject\MockObject;
 use Test\TestCase;
 
 class LDAPTest extends TestCase {
-	/** @var LDAP|\PHPUnit\Framework\MockObject\MockObject */
-	private $ldap;
+	private LDAP&MockObject $ldap;
 
 	protected function setUp(): void {
 		parent::setUp();
 		$this->ldap = $this->getMockBuilder(LDAP::class)
-			->setMethods(['invokeLDAPMethod'])
+			->onlyMethods(['invokeLDAPMethod'])
 			->getMock();
 	}
 
-	public function errorProvider() {
+	public static function errorProvider(): array {
 		return [
 			[
 				'ldap_search(): Partial search results returned: Sizelimit exceeded at /srv/http/nextcloud/master/apps/user_ldap/lib/LDAP.php#292',
@@ -31,14 +33,10 @@ class LDAPTest extends TestCase {
 		];
 	}
 
-	/**
-	 * @param string $errorMessage
-	 * @param bool $passThrough
-	 * @dataProvider errorProvider
-	 */
-	public function testSearchWithErrorHandler(string $errorMessage, bool $passThrough) {
+	#[\PHPUnit\Framework\Attributes\DataProvider('errorProvider')]
+	public function testSearchWithErrorHandler(string $errorMessage, bool $passThrough): void {
 		$wasErrorHandlerCalled = false;
-		$errorHandler = function ($number, $message, $file, $line) use (&$wasErrorHandlerCalled) {
+		$errorHandler = function ($number, $message, $file, $line) use (&$wasErrorHandlerCalled): void {
 			$wasErrorHandlerCalled = true;
 		};
 
@@ -48,7 +46,7 @@ class LDAPTest extends TestCase {
 			->expects($this->once())
 			->method('invokeLDAPMethod')
 			->with('search', $this->anything(), $this->anything(), $this->anything(), $this->anything(), $this->anything())
-			->willReturnCallback(function () use ($errorMessage) {
+			->willReturnCallback(function () use ($errorMessage): void {
 				trigger_error($errorMessage);
 			});
 
@@ -59,7 +57,7 @@ class LDAPTest extends TestCase {
 		restore_error_handler();
 	}
 
-	public function testModReplace() {
+	public function testModReplace(): void {
 		$link = $this->createMock(LDAP::class);
 		$userDN = 'CN=user';
 		$password = 'MyPassword';